From: Suren Baghdasaryan <surenb@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yu Zhao <yuzhao@google.com>,
Kent Overstreet <kent.overstreet@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH mm-unstable v1 3/3] mm/codetag: add pgalloc_tag_copy()
Date: Thu, 5 Sep 2024 17:03:33 -0700 [thread overview]
Message-ID: <CAJuCfpE323zBTNhE7Ui_JCiNn4cb-w+Hu3Paxi00EicWULLfwA@mail.gmail.com> (raw)
In-Reply-To: <20240905162524.72c5bbefa075adb466ea6057@linux-foundation.org>
On Thu, Sep 5, 2024 at 4:25 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 3 Sep 2024 15:36:49 -0600 Yu Zhao <yuzhao@google.com> wrote:
>
> > Add pgalloc_tag_copy() to transfer the codetag from the old folio to
> > the new one during migration. This makes original allocation sites
> > persist cross migration rather than lump into compaction_alloc, e.g.,
> > # echo 1 >/proc/sys/vm/compact_memory
> > # grep compaction_alloc /proc/allocinfo
> >
> > Before this patch:
> > 132968448 32463 mm/compaction.c:1880 func:compaction_alloc
> >
> > After this patch:
> > 0 0 mm/compaction.c:1880 func:compaction_alloc
> >
>
> I'm thinking that [2/3] should be backported?
Yes, should be CC'ed to stable #6.10
>
> And possibly this one, but for that we should identify a Fixes:, please.
I think for this one Fixes: dcfe378c81f7 ("lib: introduce support for
page allocation tagging") would be the most appropriate.
I'll review all 3 fixes later today.
Thanks!
next prev parent reply other threads:[~2024-09-06 0:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 21:36 [PATCH mm-unstable v1 1/3] mm/codetag: fix a typo Yu Zhao
2024-09-03 21:36 ` [PATCH mm-unstable v1 2/3] mm/codetag: fix pgalloc_tag_split() Yu Zhao
2024-09-06 3:00 ` Suren Baghdasaryan
2024-09-03 21:36 ` [PATCH mm-unstable v1 3/3] mm/codetag: add pgalloc_tag_copy() Yu Zhao
2024-09-05 23:25 ` Andrew Morton
2024-09-06 0:03 ` Suren Baghdasaryan [this message]
2024-09-06 3:27 ` Suren Baghdasaryan
2024-09-06 2:41 ` [PATCH mm-unstable v1 1/3] mm/codetag: fix a typo Suren Baghdasaryan
2024-09-06 2:43 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJuCfpE323zBTNhE7Ui_JCiNn4cb-w+Hu3Paxi00EicWULLfwA@mail.gmail.com \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox