From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8918C48260 for ; Tue, 13 Feb 2024 08:17:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AD946B007D; Tue, 13 Feb 2024 03:17:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35D7E6B007E; Tue, 13 Feb 2024 03:17:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FE1D6B0080; Tue, 13 Feb 2024 03:17:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0DD7F6B007D for ; Tue, 13 Feb 2024 03:17:22 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D4154C0116 for ; Tue, 13 Feb 2024 08:17:21 +0000 (UTC) X-FDA: 81786075882.10.BDD825C Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf21.hostedemail.com (Postfix) with ESMTP id 215AD1C000A for ; Tue, 13 Feb 2024 08:17:19 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=txA9HJZW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707812240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hC5Sp72DpOGszEFoskDK+zxBIS3uARFrNh6dT/DOYpw=; b=1ngMJfYsBgv9QH1Ed3u6lvHMvq1PVLo1LS9xN36uhXeZmaIEM+00TWtpoIIDkuebQEOuvJ CXbhQjEQfZzZnTHjA/3jawEfL7GU/R4bFr2yibcBTpkktnxfqNg4HljMVi0jtQLIRo5O33 /3XCj0vbS5pfO+5Sz9kXrL02sS4lu8M= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=txA9HJZW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707812240; a=rsa-sha256; cv=none; b=Gpg6/gBHrVpT99WAhzwJq9ykoXdC9/SuTvfs1+D9hsrH5KkklaEp/ITKqKWhs1PZ735oB5 23L3MgfWCe0YzY4HNNgZXksE9AOa5m8Afb1oeoCMdiysX5E3BT2omQMxy2V6HGfnCrC7fJ T6g3ZSy++CPWS6MZ51rqSnDwdTh3uns= Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-db3a09e96daso3414231276.3 for ; Tue, 13 Feb 2024 00:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707812239; x=1708417039; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hC5Sp72DpOGszEFoskDK+zxBIS3uARFrNh6dT/DOYpw=; b=txA9HJZWiHaOiqJ0Ho7pfYIW3Q3vYezvJs7/tnv7u6XKxJp17p+iMQI8Ei6s0eh2Xt ACxti9xo7n+NVW5TSp3HOuXIiytssl1GrVv8w8xxQPmz1tN45RGCnpn4feIrqOfKexFA 7T602iJGIHMi15axC/ZbtOXiAVWEMlgGzRe/KaPJRFgQdYo434BXPTTG4tar+8RJ89rB IZdbN/SrPu44PHwSHWV8ehV0YOHT55bReVLEbBgju9rKt1D/BXfJ186miV1Tu++mwTnB sd4bp9cBrXhsmRPBk8PvPkRnAKe0caf8WhUg7pwu0vzxXQ4C2gajnqFl+Amib8NGOHnZ mAuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707812239; x=1708417039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hC5Sp72DpOGszEFoskDK+zxBIS3uARFrNh6dT/DOYpw=; b=mOzOQdmWmBBHPweUETOXl7mnVIKEDOAlB8AmOHnCfe/otmnqmbM5fgs/EUIFnI6Ya0 Wt0LGcdaF/lO/NC+1b+4MG3OYKnw0DciCXy7QwI2y4CJ0f7zww1zAxb2NevYjrajKjeu AdgS/51cYYXkZ9ACvMC0XQ6F8ikLihfGHAfHGGseN09iYK01uqfdasqS82iy2h8rywWT KzCQ4oBOON8TiDMuJwRTCjXPxg5AruczK6WzQb9qwPAbgTFtGFuyh8EWIYFsdUEmXwLH Ge45ioquKpkf8OzxLl79Y0QbG6eCcfs6+FmHIKC1zsh99KaYVPnkHpI8295Gd44Uj7ao fUnA== X-Gm-Message-State: AOJu0YyXSWm2k6nJuxLCkTWpK2z8SE2L4cDumJqCyNbrYBrBNNHRGpFa YeLUF8Xayi/AP69W7g+zMZ1DR2iJoCHcCKbahd2Z/h6DBteFB/o2LVGmLZznUZZMeupK8GYrYl0 BtvqMebt/6KtDxxnYYrPW0Kbgu6gZ1/ho7lIe X-Google-Smtp-Source: AGHT+IHjpakmjDseMf+FthsBajS4lohi+4SNf65A0StZavoAeiHzVp/HPng86atAuU0FiQuCDBbDYkv0F+8/PL8mBAs= X-Received: by 2002:a25:6841:0:b0:dcd:24b6:1aee with SMTP id d62-20020a256841000000b00dcd24b61aeemr45209ybc.47.1707812238953; Tue, 13 Feb 2024 00:17:18 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-32-surenb@google.com> <202402121606.687E798B@keescook> <20240212192242.44493392@gandalf.local.home> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 13 Feb 2024 00:17:04 -0800 Message-ID: Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() To: Kent Overstreet Cc: Steven Rostedt , Kees Cook , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 215AD1C000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: os3onpmcjgk3e8esmhefwgf5thrkfx4b X-HE-Tag: 1707812239-304258 X-HE-Meta: U2FsdGVkX19ndqd6NBylPxmFfOBoOBmYXcVV9acgBrI4wGuSJ2bkMDM4YSNicveDf31NP3h0LjbXtn+rxBWm5o2rKUVa6wNRoYS7STe9AhnC32kwDl3bpoElE1yTRRJQ0aw0IvBQKtAOWDgWoQkKoQIa7eu51U2IoXyA4uYF69qlSw97ruzwuDT04eEAbKZMDADphWS0Xs0dB+3NPThFmxiOBGjBo1vaksJq90vy7hyxoXBozxod3t3jUUcDzxR47m9ibCakE70nse1L9/+GpM0BOzfSXtTOq0Q5MjmSChVaQO+6LY/QPAxGnucgILHRH45Mwlo1JbFyxPvFS4Nj7eybqyu0aoHhf7vFVhZBBzcAkLE/tsxanu1Na4PLk5jSSzXEP2+pRd8Ub0/8tM7lCg/2tD/aBKQ6cc2ET+Q5roCy13kIHcQE259Axib9GbijGtxvfy3QWWD41Fgbl13y/8d7oVUYzw6Kdur/lRAxmEmX0TKWretJGZJ/4nMFe+l/136qJW3WlM1oD7LS35hFy9e4VWPxUUXwTOSPbNV88eBFwVbU9VlntBT5tw0osAVKUMrNBdQG57bMj6tY+aGaHz0dSouexbh4GIzlBR3i+GVhkOtwLEjuukHcKHQn8jUpolQWWRs13W1RuPINhBHqhRJfG6Zpf0pOTii5AddxYt7vT5yDi/nd9oIg3AbV3Hz2tKazNcAcNdYRAo0XeXBkWWKHQocT2rfQcDqTDL1+Ml6nHjLwEjZuNu6ULBoVT7tejcGBtPaJJrwfPW89wwTudoLqIDckyXPZtnl7UzxrXrkzgTPL8qzRmtVoMmUzaRV1yYHuMHcn/XgcQbQnVKOx0aI7wRGJoY0PpyljUuyCPRdk3p+cppxwSMHLRtkU8FC9Juxn8svPGBIDB4Z/kBCa5ldyRmOghcrrSeTPm108dEmTHXz4SgD9Uzc8rWOWdF8o1mJ+r0uwotScvU171aQ rQoHT+xp VPImCQCrbLTDecO4W0OkunxTJvHJDQWGKZPFYjGyERxXOvBJIYzyN+lwg6MFPlb6rAUMtoHXUC1+VM5z2xjpwYD+SmppYgrzdCoIfN8oRgqRhYoKWtePn2nYGDSMZR+TUYfeiotFHu61HOYTB7K+FOZd54SGlP54obJ24C11n2rt6q1Z7OgCWDvnL9amxiuZ474f6pKibO+asERR4hkYFvxUrd0oeZXRUP6ocTclfkjnw2KrCNAlb+V8cLKY3VVdrMYY0CdIhVL7dcfnYLJQZ20E32QTesscy6ZzW3Gi34gqh7A68TNdvWf/mNMXwT2HNpAFf7iXaNGeZCh8P41oDYN4SrsmgiXDoncmh1Asj1/ll72v2LbytmyTYk5o7cxdluZIoRj+N63tRIztPSyvM/743wKLDnq9YRgHip/4/IG18qUI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 8:33=E2=80=AFPM Kent Overstreet wrote: > > On Mon, Feb 12, 2024 at 07:22:42PM -0500, Steven Rostedt wrote: > > On Mon, 12 Feb 2024 16:10:02 -0800 > > Kees Cook wrote: > > > > > > #endif > > > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > > > + { > > > > + struct seq_buf s; > > > > + char *buf =3D kmalloc(4096, GFP_ATOMIC); > > > > > > Why 4096? Maybe use PAGE_SIZE instead? > > > > Will it make a difference for architectures that don't have 4096 PAGE_S= IZE? > > Like PowerPC which has PAGE_SIZE of anywhere between 4K to 256K! > > it's just a string buffer We should document that __show_mem() prints only the top 10 largest allocations, therefore as long as this buffer is large enough to hold 10 records we should be good. Technically we could simply print one record at a time and then the buffer can be smaller.