From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5323C4345F for ; Tue, 16 Apr 2024 23:57:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CAE96B008C; Tue, 16 Apr 2024 19:57:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 179A96B0092; Tue, 16 Apr 2024 19:57:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0401E6B0093; Tue, 16 Apr 2024 19:57:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DB1DA6B008C for ; Tue, 16 Apr 2024 19:57:16 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 99842140A42 for ; Tue, 16 Apr 2024 23:57:16 +0000 (UTC) X-FDA: 82017058872.12.E7EB600 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf20.hostedemail.com (Postfix) with ESMTP id CD0D51C0004 for ; Tue, 16 Apr 2024 23:57:14 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gz7ryBdv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713311834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IC8mWV6b6QzlZE6JFnyR9+zfyszn/P9cKrq9cHY85Yc=; b=yzTrCrWQzdVxtbIELSqO65fwGcC/JCGyyzyE458LiR9HUOuhDUjPYYyGe8GreMlZS6rSzi RJ3IAPrg5Xn7YPQ9jvlz+IQZ/dyQSazkbVmIlzQ9wBf48tQdG9fr01Fuv40I+/HkQjL7cC afdaIMMTSwdG5zct4EI4gpErXMbUDO8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gz7ryBdv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713311834; a=rsa-sha256; cv=none; b=DWSQAw1jWenWVHZ/Sx0Zf1QNKaHJKqxLQrO6N7oleSltutxZgSfcQrW51oEt9nKouikgUg 10XgFHlqP6EBrumHBmYRVjOKqjfCZaMpl/+IiDWITga8qH6xsAD+uZFEpkDNw9kHMz3q39 yUVn+0whp73WhbKl1WhJARf1Ut22nP8= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-dc236729a2bso4828317276.0 for ; Tue, 16 Apr 2024 16:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713311834; x=1713916634; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IC8mWV6b6QzlZE6JFnyR9+zfyszn/P9cKrq9cHY85Yc=; b=gz7ryBdv92GzYGKkQCP9jmRgBIInAfBfznx8D/6dtv1Y58ei+u447L9LZXlBWClKcr 2S/ncJQnQglrr2WOfYllCuj9IAn4QinOIn4JrVk0b91xd0EQoLsMKuddMzKrmGyoLJh2 y7LuNb3UyrYVkrX/BeaQYSdDfgOYe4LUIhN1q5P/G3ha5CSBHNk/Vckpdz9+yxLwo073 OOnCh0vhsCD7dOt92OAs6jZiPyRO7mFjeu/HgbffowSdB3AjTBYtrihnDFqk10wRRxZX xtYVE1p+zGwk5q6OdH9P+/NtKrXlPP+PBAVdWXeqhTLJU5tqOY6je/Q7NwnnyX2JU7Yy nfgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713311834; x=1713916634; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IC8mWV6b6QzlZE6JFnyR9+zfyszn/P9cKrq9cHY85Yc=; b=BoWi75kSknJCkv9dQZVvLt8+J7foPtMsm0vq0+imBqc4+/j7d99H9dB2rk1w20+euE DUNWqT4adCGwU0X+6USAosinF47MoJVB/TOcDRtsj0Grf9B3LdVtG/yTedVwJLrZAtKd NzHt0Vtb9gZ0Vs0hXHb4P29GenDThFXYOF6XziRaPl0U15+872qu6VeZiXC3JAaY5x8T gOjzLbcMfkWWVMd/X/eUvNM460oAOeCWSBKdV121AnwxmsjO+CxG3tc2gaPr41VOJqAD nZGmG0XuGbn6XD9lI11ZfdiT5KmUKeeoLygye9ELLYhlDNwAs2xynj6OcKSnpo30cKqf Hcrg== X-Forwarded-Encrypted: i=1; AJvYcCWxg6PXjhwxelbFpUuAdDATO5P0bL+1biDu+U0uYizjBI3tMCuROGHBl41qUEzcMyQcOVtkHQ/Aopc8VfpAfF3UoOk= X-Gm-Message-State: AOJu0YwHlSZ2757XkseEK7q2k2W9FbH9HCwSjaaTGfVNTU1Py61s0KBE 1VD07SbtOcZUe36Ngu+4WBkgTOfv623NAqWejFzOV98Rf5hHtj0z5yqnSDx/SaQfziDnk+ECpQf TiFJy+Rat9qWq6d++lCsvQbVn7wecYraZQSM0 X-Google-Smtp-Source: AGHT+IHMoPAxpjKDVaNQ+EXB0M8jdi1kEZvbp6UZM4KQDz6GqswGDJkg4CfM8mkE05Ermcc37rOU3hCGAd+Av5etk6Q= X-Received: by 2002:a25:8b01:0:b0:de0:ed33:da8c with SMTP id i1-20020a258b01000000b00de0ed33da8cmr13045167ybl.59.1713311833463; Tue, 16 Apr 2024 16:57:13 -0700 (PDT) MIME-Version: 1.0 References: <6b5281d8-2998-4e66-b65e-45a0e68e5780@moroto.mountain> In-Reply-To: <6b5281d8-2998-4e66-b65e-45a0e68e5780@moroto.mountain> From: Suren Baghdasaryan Date: Tue, 16 Apr 2024 23:57:01 +0000 Message-ID: Subject: Re: [linux-next:master 2720/3921] lib/alloc_tag.c:142 alloc_tag_init() warn: passing zero to 'PTR_ERR' To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton , Kent Overstreet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CD0D51C0004 X-Stat-Signature: uzjs6wjgnnizrf5gmm858aqwgn79rqdh X-HE-Tag: 1713311834-936471 X-HE-Meta: U2FsdGVkX181ktHWwS2P0iu8Fx176VJ9TnKN2vuIHm89kkxjMDV5F/CLc4r+iwu4N9C6eaYzHC5TuOtaJtvBAMFda5GZkc2onw5wI41mWaTRckZgBBpE4Azu13+AZpggZCQ5i/FwbZLLOZEfUAKtxDltE2nyqp/sY2NZVoC3Cg7tKm7AClczwGaSmhMsiDAkgc0xCQ8YtmIH873S+hdGXWClshfp5HqKcU8kJc4a1SXX2xkYFbWqYcn2ev80HAUcMvhjrnNFRIwQ1iZKU9faPZdLHgfNjrX59oV17Mnwi4A7Vds4nfzSa9/E7ZUNeZf40EsaJc/VwrGMbRY4CkJeHelpuX7qkyM40BFWZhOy2+DVI/tzEjCLifH97r3DN6vK06VkswBG9vbDCBZSEPtlsv/7Bxqtx49oDw5aV/hqrETrFidZCiBA78G2hLjspucmVOnErS2hXzuZEusklYidT5JiOITgn9oh4rOsbkKWQMSqmpslkcQsXJTGWt8Nrbk96lF96avgwibBMGvGtELOOYrsTYeDUYsB00UF+n61guhQihuQVvuA6WH51e30gZ2GlZBLpujtqIdH9HXZaiE2ZIFwrty81RAnUMwJsB6AX/ZRWBF5S6Tf4qmefVUQIO2Bm68D7n/jI4TVudIctATq6R5nsTX/ofuhHH7tVbcV+Y+cJBKdmPF4ZPIMEyEPZYxoZN7mMMRu8DswP6ge0kXl59okb6xwodZsoxXZQ5eF5zLzxNIqOEMEDdKM1QPeBTBdotmwBosFADcMoXjjuhOZohMXYqTzb+qaz+XuoQRTAZCy4mFAm1MSw7aiWRA1k/ga9cKxZkVP98b7fglVitW0X02di4xHzURQk0dm1HWkWSwQWzUxoADbSppZHMsFEKi/4tGzvvWzsg/MoJFWTotQ+5Vt+SJ2yjxncMiaEmpYw+aX2ksqDYY1UHMpLJRmCwlTQAKGZO+xYGYnSR/U2Du CV22H3LB OqHirKSNXMrT39oXltQPGf6xpHGoHfGuBvcao/2LT9XYTiXduWK5nR2g8ST15TE8Svce3QaraHK8mea0R8ttunUA12T6j0D5XL6dbc2zYEOfyJDkOGUlL9VrHrAQ+2XOcyOJYZfzfZgEjBzZVwTX7sLEffSwudeyZWwA/jDCxoNBYzwp70jaJXlcOWO1Nf91bsqPNbDkVJDhUzB1aDOaVAh31yAdWKJQvzTcEwZNNwIhxu/xONfK4KiPe7k0wBK9occ2FsWO9tuFe5inFO3ubc65IXUowkdgl3VhagILfK7pf+TLzFqa0Kkc9/dKPDnAS8spbrNshgL36Ik2NwC4dPF+0cEFV/xV5aXTLxp2ZryzcHiNkOkIJFvAab2LuGe18kCLsYBF2aWZB+p/f3F7t4okaV7+aknJPUJIvWz6mdnbdbk/ks3gN3o6AD8ehcHbpy84mXaMKXBNAbcPbP370dzA5m8TMofsznsjY/Bcpf+aXKe5//ZvTwvC7Guzey04bO/wslQBuAmr8vtEWd/XaLhoL7dzzSn2TWI3t06uOS9DOMmI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 5, 2024 at 6:51=E2=80=AFAM Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: 8568bb2ccc278f344e6ac44af6ed010a90aa88dc > commit: 9e2dcefa791e9d14006b360fba3455510fd3325d [2720/3921] lib: add all= ocation tagging support for memory allocation profiling > config: microblaze-randconfig-r081-20240405 (https://download.01.org/0day= -ci/archive/20240405/202404051340.7Wo7oiJ5-lkp@intel.com/config) > compiler: microblaze-linux-gcc (GCC) 13.2.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202404051340.7Wo7oiJ5-lkp@intel.com/ > > smatch warnings: > lib/alloc_tag.c:142 alloc_tag_init() warn: passing zero to 'PTR_ERR' > > vim +/PTR_ERR +142 lib/alloc_tag.c > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 132 static int __init allo= c_tag_init(void) > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 133 { > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 134 const struct code= tag_type_desc desc =3D { > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 135 .section = =3D "alloc_tags", > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 136 .tag_size= =3D sizeof(struct alloc_tag), > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 137 .module_u= nload =3D alloc_tag_module_unload, > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 138 }; > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 139 > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 140 alloc_tag_cttype = =3D codetag_register_type(&desc); > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 141 if (IS_ERR_OR_NUL= L(alloc_tag_cttype)) > ^^^^^^^^^^^^^= ^^^^^^^^^^^^^^^^^^^ > This should just be IS_ERR(). I have written a blog that has more > details: > > https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and= -null/ Sorry for the delay, I somehow missed this report. You are absolutely right about the fix. codetag_register_type() never returns NULL, so IS_ERR() should be used here. I'll post a fix shortly. Thanks, Suren. > > 9e2dcefa791e9d Suren Baghdasaryan 2024-03-21 @142 return PT= R_ERR(alloc_tag_cttype); > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki >