From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81535C4332F for ; Wed, 19 Oct 2022 00:12:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECA416B0072; Tue, 18 Oct 2022 20:12:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7A5D6B0073; Tue, 18 Oct 2022 20:12:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D41B66B0074; Tue, 18 Oct 2022 20:12:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C0A496B0072 for ; Tue, 18 Oct 2022 20:12:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7E8F91409EE for ; Wed, 19 Oct 2022 00:12:08 +0000 (UTC) X-FDA: 80035771536.13.C727051 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf16.hostedemail.com (Postfix) with ESMTP id 3D32918002B for ; Wed, 19 Oct 2022 00:12:08 +0000 (UTC) Received: by mail-yb1-f169.google.com with SMTP id i127so8174281ybc.11 for ; Tue, 18 Oct 2022 17:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Jna0LWDs2gplNvdaC5RjeZ7sSKNcNgKBH+clH9nfsnQ=; b=Y7NRHCCholGYVX0rlQiB4fXLGvUqYExV9+g0EoWPq48f0K2NaAjTSDoWAZviH2lt95 5TPNHRnBeh+WfktGG7pPRElFCbtGZaic5XatkjzfzY5sv/LpX+0LXDpFYg/EzjNYZem3 UMMM56vxMa/jqA7geuiA2IgQCLZp45s4Id7UBwTfBxfooWZrnj+NhhNMnAiFU24Fs3Hr 8pmQEyVpmZQZLuYLImsCMoZdrUbBVywQu0z+UeJgdSEjHZD9BIc7mEgzykzZWpPTvB7v lNW6xZvW22Hc1AL264pUcFl/x8p43cdorsd6lOP5Q5LRjzm4mxyWGTiX6BQxODf5ZIH/ AYbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jna0LWDs2gplNvdaC5RjeZ7sSKNcNgKBH+clH9nfsnQ=; b=Sn00xflOmoyYmSPfMgrsn0gwYi5ushim66jaaXsiVQRAGyL2XYiPk1svJv6h7yz3JU daVmreF+h50FexVTk8dyA8PtKW1gVs/dwFli+R6Rz/f634Bk4dbEaL6g7SQU/sYSqYPv DWt8Vt5dp2b7Pv24Z3cLgygIq3nUYMYjVm2V4S5A2sL4tc8FCs2ZtnRlFryr0SwKRKoh lP6vn7dSY7oicpwZcu3WvtlzInLMpKI13v97sNA7oj6OleTE8Iu0dMC/PQeBI5z2g6CL ZYsFTRKnMC4F1kFjCF/ozp19i5fZsWld+E+nElQK1+9rxkH02tNUmgOGm8kqXtxZtpiB 4UJQ== X-Gm-Message-State: ACrzQf1W2SF3doctIhx2um9q7kLouUDeU3saJZklyToeGPf41aJDM60e gWBD0PJWGJCom6s26CXYGV97kjx8PrXYnf2CiSyQ0A== X-Google-Smtp-Source: AMsMyM5jqVrs2PiY7C2AHyT4DfbYmcm2nTPaadmm4elFiM8lFx5z74eiHGIIuOYJiWsztYPrH+8UEcYtsEu91knUS2M= X-Received: by 2002:a25:2:0:b0:6c4:dc1:d37c with SMTP id 2-20020a250002000000b006c40dc1d37cmr4430021yba.380.1666138327301; Tue, 18 Oct 2022 17:12:07 -0700 (PDT) MIME-Version: 1.0 References: <20221018235051.152548-1-zokeefe@google.com> <20221018235051.152548-4-zokeefe@google.com> In-Reply-To: <20221018235051.152548-4-zokeefe@google.com> From: Suren Baghdasaryan Date: Tue, 18 Oct 2022 17:11:55 -0700 Message-ID: Subject: Re: [PATCH man-pages v2 3/4] process_madvise.2: CAP_SYS_ADMIN cleanup To: Zach OKeefe Cc: Alejandro Colomar , Michael Kerrisk , Yang Shi , linux-mm@kvack.org, linux-man@vger.kernel.org, Minchan Kim Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666138328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jna0LWDs2gplNvdaC5RjeZ7sSKNcNgKBH+clH9nfsnQ=; b=wXYNH6e7ZGm1VMi5vYMTddghKo7rrdjrv0AJ5KpHUZXjJukmCQtFmMicfu9etBO9rZXteg 2/hJ/RYmvOOne6pgbEIf9wIErTT016R+R4tYq/3x+Ogx0YSdUTt/FtA9ydfCjt818W474C +QV2xLPNdJ4frjlhaAmW9gdTdktKbco= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Y7NRHCCh; spf=pass (imf16.hostedemail.com: domain of surenb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666138328; a=rsa-sha256; cv=none; b=i/25mtiI4y7/QJ7dl5kpo4XtTrC1WeI6ceIolYoU3+2veyiaRZgJPf7qZfW/VobI76H3sJ Q8vCR1TianFcW5l5+JrOuotgkcS002R11i0CshPgWDNTj/fVsf6h9tE4RmKAHzJwqHV6tg d/R1j9dKtlKw1DluPpwD2gbOxLZqQho= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3D32918002B X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Y7NRHCCh; spf=pass (imf16.hostedemail.com: domain of surenb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: ipoauhcznqh8mnpdredq3gctsbdmezkm X-HE-Tag: 1666138328-301285 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 18, 2022 at 4:51 PM Zach OKeefe wrote: > > From: Zach O'Keefe > > The initial commit of process_madvise(2) to man-pages project included > an error, indicating that CAP_SYS_ADMIN capability was required when, in > fact, CAP_SYS_NICE was the required capability. > > The initial commit of process_madvise(2) to Linux, commit ecb8ac8b1f14 > ("mm/madvise: introduce process_madvise() syscall: an external memory > hinting API"), relied on PTRACE_MODE_ATTACH_FSCREDS (see ptrace(2)), > but was amended by commit 96cfe2c0fd23 ("mm/madvise: replace ptrace > attach requirement for process_madvise") which replaced this with a > combination of PTRACE_MODE_READ and CAP_SYS_NICE (PTRACE_MODE_READ to > prevent leaking ASLR metadata and CAP_SYS_NICE for influencing process > performance). > > Correct this in the man-page for process_madvise(2). Thanks for fixing my mistake! > > Fixes: a144f458b ("process_madvise.2: Document process_madvise(2)") > Cc: Suren Baghdasaryan > Cc: Minchan Kim > Signed-off-by: Zach O'Keefe Reviewed-by: Suren Baghdasaryan > --- > man2/process_madvise.2 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/man2/process_madvise.2 b/man2/process_madvise.2 > index 6208206e4..7bee1a098 100644 > --- a/man2/process_madvise.2 > +++ b/man2/process_madvise.2 > @@ -113,7 +113,8 @@ check (see > in addition, > because of the performance implications of applying the advice, > the caller must have the > -.B CAP_SYS_ADMIN > +.\" commit 96cfe2c0fd23ea7c2368d14f769d287e7ae1082e > +.B CAP_SYS_NICE > capability. > .SH RETURN VALUE > On success, > -- > 2.38.0.413.g74048e4d9e-goog >