From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f178.google.com (mail-qc0-f178.google.com [209.85.216.178]) by kanga.kvack.org (Postfix) with ESMTP id 3F9CD6B0035 for ; Wed, 17 Sep 2014 00:15:07 -0400 (EDT) Received: by mail-qc0-f178.google.com with SMTP id c9so1258837qcz.37 for ; Tue, 16 Sep 2014 21:15:07 -0700 (PDT) Received: from mail-qc0-x22b.google.com (mail-qc0-x22b.google.com [2607:f8b0:400d:c01::22b]) by mx.google.com with ESMTPS id u3si18174250qaf.95.2014.09.16.21.15.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 16 Sep 2014 21:15:06 -0700 (PDT) Received: by mail-qc0-f171.google.com with SMTP id x13so1275577qcv.2 for ; Tue, 16 Sep 2014 21:15:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140916223402.GL15807@hpx.cz> References: <20140916223402.GL15807@hpx.cz> Date: Tue, 16 Sep 2014 21:15:06 -0700 Message-ID: Subject: Re: [PATCH] kvm: Faults which trigger IO release the mmap_sem From: Andres Lagar-Cavilla Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Cc: Paolo Bonzini , Gleb Natapov , Rik van Riel , Peter Zijlstra , Mel Gorman , Andy Lutomirski , Andrew Morton , Andrea Arcangeli , Sasha Levin , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org On Tue, Sep 16, 2014 at 3:34 PM, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > [Emergency posting to fix the tag and couldn't find unmangled Cc list, > so some recipients were dropped, sorry. (I guess you are glad though).] > > 2014-09-16 14:01-0700, Andres Lagar-Cavilla: >> On Tue, Sep 16, 2014 at 1:51 PM, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: >> > 2014-09-15 13:11-0700, Andres Lagar-Cavilla: >> >> +int kvm_get_user_page_retry(struct task_struct *tsk, struct >> >> mm_struct *mm, >> > >> > The suffix '_retry' is not best suited for this. >> > On first reading, I imagined we will be retrying something from >> > before, >> > possibly calling it in a loop, but we are actually doing the first and >> > last try in one call. >> >> We are doing ... the second and third in most scenarios. async_pf did >> the first with _NOWAIT. We call this from the async pf retrier, or if >> async pf couldn't be notified to the guest. > > I was thinking more about what the function does, not how we currently > use it -- nothing prevents us from using it as first somewhere -- but > yeah, even comments would be off then. > Good point. Happy to expand comments. What about _complete? _io? _full? >> >> Apart from this, the patch looks good. The mm/ parts are minimal, so >> >> I >> >> think it's best to merge it through the KVM tree with someone's >> >> Acked-by. >> > >> > I would prefer to have the last hunk in a separate patch, but still, >> > >> > Acked-by: Radim Kr=C4=8Dm=C3=A1=C5=99 >> >> Awesome, thanks much. >> >> I'll recut with the VM_BUG_ON from Paolo and your Ack. LMK if anything >> else from this email should go into the recut. > > Ah, sorry, I'm not maintaining mm ... what I meant was > > Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 Cool cool cool Andres > > and I had to leave before I could find a good apology for > VM_WARN_ON_ONCE(), so if you are replacing BUG_ON, you might want to > look at that one as well. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org