linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yongkai Wu <nic.wuyk@gmail.com>
To: mike.kravetz@oracle.com
Cc: mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hugetl.c: keep the page mapping info when free_huge_page() hit the VM_BUG_ON_PAGE
Date: Wed, 14 Nov 2018 23:37:49 +0800	[thread overview]
Message-ID: <CAJtqMcZr-UUBBzYZpbJ_+j-8Thg1GMy6G2=fnmoMgmgpS-Ojmw@mail.gmail.com> (raw)
In-Reply-To: <dc39308b-1b9e-0cce-471c-64f94f631f97@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]

Dear Mike,
Glad to get your reply.I am sorry for late reply because i am on business
trip today.I will tell more detail about the issue i met later.
And because i have no experience how to send a kernel patch correctly,so it
may takes some time for me to learn that before i resend the patch.

Best regards

On Wed, Nov 14, 2018 at 2:05 AM Mike Kravetz <mike.kravetz@oracle.com>
wrote:

> On 11/13/18 7:12 AM, Yongkai Wu wrote:
> > Dear Maintainer,
> > Actually i met a VM_BUG_ON_PAGE issue in centos7.4 some days ago.When
> the issue first happen,
> > i just can know that it happen in free_huge_page() when doing soft
> offline huge page.
> > But because page->mapping is set to null,i can not get any further
> information how the issue happen.
> >
> > So i modified the code as the patch show,and apply the new code to our
> produce line and wait some time,
> > then the issue come again.And this time i can know the whole file path
> which trigger the issue by using
> > crash tool to get the inode、dentry and so on,that help me to find a way
> to reproduce the issue quite easily
> > and finally found the root cause and solve it.
>
> Thank you for the information and the patch.
>
> As previously stated by Michal, please add some additional information to
> the
> change log (commit message) and fix the formatting of the patch.
>
> Can you tell us more about the root cause of your issue?  What was the
> issue?
> How could you reproduce it?  How did you solve it?
> --
> Mike Kravetz
>

[-- Attachment #2: Type: text/html, Size: 1889 bytes --]

  reply	other threads:[~2018-11-14 15:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 12:38 Yongkai Wu
2018-11-13 13:04 ` Michal Hocko
2018-11-13 15:12   ` Yongkai Wu
2018-11-13 15:24     ` Michal Hocko
2018-11-13 18:04     ` Mike Kravetz
2018-11-14 15:37       ` Yongkai Wu [this message]
2018-11-15  8:30       ` Yongkai Wu
2018-11-15  8:52         ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJtqMcZr-UUBBzYZpbJ_+j-8Thg1GMy6G2=fnmoMgmgpS-Ojmw@mail.gmail.com' \
    --to=nic.wuyk@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mike.kravetz@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox