From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D72C43331 for ; Fri, 3 Apr 2020 02:20:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B390D2077D for ; Fri, 3 Apr 2020 02:20:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F8ndQdYw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B390D2077D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 64B558E0008; Thu, 2 Apr 2020 22:20:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FBC78E0007; Thu, 2 Apr 2020 22:20:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 539078E0008; Thu, 2 Apr 2020 22:20:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 38C538E0007 for ; Thu, 2 Apr 2020 22:20:00 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 04F5D40CD for ; Fri, 3 Apr 2020 02:20:00 +0000 (UTC) X-FDA: 76664938560.26.box71_3a298b2a68539 X-HE-Tag: box71_3a298b2a68539 X-Filterd-Recvd-Size: 5940 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Apr 2020 02:19:59 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id bp12so2896700qvb.7 for ; Thu, 02 Apr 2020 19:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r8cH9HY4G4p39wStCeNyi1My0N+YNgXKEhlT3F5N1u4=; b=F8ndQdYwCRYoWB5Ww5ltZOEsRfMoB2zC8709XdUe4Ql3IAQJeFTq1I6PJRlD/8mZfG 6YSCPZKByfpNQ9HObzyQNM2YNijLy0JYRKGryGo4ZVs0nrzpv5RIsJcfCKUPz/dmLCOJ QLcipb5PV/POfAzVUcLfnuRydh1aMQoZEjufdSquAz5nDUgieAeZ/0fAiukETvl/GPlQ PsBKfYcXplYX9tIsiTpycyOF2MgdVG4P3UbTgNjTgPtRmcz4H0a+NBoH90IZIrsp3eXC K4pzqZ6rkDNqN8g9MFdEAlDmOzeY4J3WaZuIsCIHqP+AL7imG5vRSFHDJEqu4rF++j2g qkXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r8cH9HY4G4p39wStCeNyi1My0N+YNgXKEhlT3F5N1u4=; b=uQYQRMCWBeW6eyw3EvdU1LN7FxNAWXwgDaARzpRNS+RvwFJCZirD0ODGHCnfVth5kM 3HsHsRuZV8DFy9D+neQ8yUs/J+s2/UnbOPniHzbLJh/gz2OGt6RUaVvZj2TlNHJ6UTag L6+YlRyfYX2rCrut2x+VdSlFt35z2qOInJxcNJBsy29Tr4S1dNJSJN3dbG7wogBIRhk7 vHWCF2ND/aBlvdlDfS9n+mXscMdUIM2qZPaNhbIxoX6/jSuqicIzZm11ZxaAW48rM9cV w47fXpUFE9iPlQBWupQjZGBizb2zLmxZImXaY1cULg+1/k67BHRS5jwytYWZgheIGGzw o81A== X-Gm-Message-State: AGi0PubS9DC4kzujb/utVcgy0XYtE9dH4JSYflAwSnmyjLBhtDx6xDsB eebiL4HEoghDfw8lCCi2dMOrWsVE6/07BtV1B5U= X-Google-Smtp-Source: APiQypIZRqXoeU71IjkWHSu9C+YFBAJ1NmuY1ZhrzS1w6NE/mNjiI8SOUI9ccsAcTnZhXb9Z5VLdXPbspzuXMeR1eOQ= X-Received: by 2002:a0c:fe01:: with SMTP id x1mr6215005qvr.243.1585880399006; Thu, 02 Apr 2020 19:19:59 -0700 (PDT) MIME-Version: 1.0 References: <20200402232236.2218713-1-aslan@fb.com> <20200403002705.GP21484@bombadil.infradead.org> In-Reply-To: <20200403002705.GP21484@bombadil.infradead.org> From: Aslan Bakirov Date: Fri, 3 Apr 2020 03:19:48 +0100 Message-ID: Subject: Re: [PATCH v3] mm: cma: NUMA node interface To: Matthew Wilcox Cc: Aslan Bakirov , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com, riel@surriel.com, Roman Gushchin , mhocko@kernel.org, hannes@cmpxchg.org Content-Type: multipart/alternative; boundary="000000000000d6d1e005a2598dc3" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000d6d1e005a2598dc3 Content-Type: text/plain; charset="UTF-8" On Fri, Apr 3, 2020 at 1:27 AM Matthew Wilcox wrote: > On Thu, Apr 02, 2020 at 04:22:37PM -0700, Aslan Bakirov wrote: > > +static inline int __init cma_declare_contiguous(phys_addr_t base, > > + phys_addr_t size, phys_addr_t limit, > > + phys_addr_t alignment, unsigned int order_per_bit, > > + bool fixed, const char *name, struct cma **res_cma) > > + { > > This { should be in the first column. > > - addr = memblock_phys_alloc_range(size, alignment, > > - highmem_start, > limit); > > + addr = memblock_alloc_range_nid(size, alignment, > > + highmem_start, limit, nid, false); > > Two extra tabs, not one. > > Thanks for the comments. Addressed them. --000000000000d6d1e005a2598dc3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Apr 3, 2020 at 1:27 AM Matthe= w Wilcox <willy@infradead.org= > wrote:
On T= hu, Apr 02, 2020 at 04:22:37PM -0700, Aslan Bakirov wrote:
> +static inline int __init cma_declare_contiguous(phys_addr_t base,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0phys_addr_t size, phys_addr_t limit,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0phys_addr_t alignment, unsigned int order_per_bit,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0bool fixed, const char *name, struct cma **res_cma)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0{

This { should be in the first column.=C2=A0

> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0addr =3D memblock_phys_alloc_range(size, alignment,
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 highmem_start, limit);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0addr =3D memblock_alloc_range_nid(size, alignment,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 highmem_start, limit, nid, false);

Two extra tabs, not one.

Thanks for the comments. Addressed them.=C2=A0
<= /div>
--000000000000d6d1e005a2598dc3--