From: Aslan Bakirov <aslanbekirov@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Aslan Bakirov <aslan@fb.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, kernel-team@fb.com, riel@surriel.com,
Roman Gushchin <guro@fb.com>,
mhocko@kernel.org, hannes@cmpxchg.org
Subject: Re: [PATCH v3] mm: cma: NUMA node interface
Date: Fri, 3 Apr 2020 03:19:48 +0100 [thread overview]
Message-ID: <CAJth39jAYvCvMruAPCB+jjwB0VrcSbfLw2VeUNcJ7k+zKoRTdA@mail.gmail.com> (raw)
In-Reply-To: <20200403002705.GP21484@bombadil.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Fri, Apr 3, 2020 at 1:27 AM Matthew Wilcox <willy@infradead.org> wrote:
> On Thu, Apr 02, 2020 at 04:22:37PM -0700, Aslan Bakirov wrote:
> > +static inline int __init cma_declare_contiguous(phys_addr_t base,
> > + phys_addr_t size, phys_addr_t limit,
> > + phys_addr_t alignment, unsigned int order_per_bit,
> > + bool fixed, const char *name, struct cma **res_cma)
> > + {
>
> This { should be in the first column.
> > - addr = memblock_phys_alloc_range(size, alignment,
> > - highmem_start,
> limit);
> > + addr = memblock_alloc_range_nid(size, alignment,
> > + highmem_start, limit, nid, false);
>
> Two extra tabs, not one.
>
> Thanks for the comments. Addressed them.
[-- Attachment #2: Type: text/html, Size: 1512 bytes --]
next prev parent reply other threads:[~2020-04-03 2:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 23:22 Aslan Bakirov
2020-04-03 0:27 ` Matthew Wilcox
2020-04-03 2:19 ` Aslan Bakirov [this message]
2020-04-03 2:12 Aslan Bakirov
2020-04-03 5:02 ` Ira Weiny
2020-04-03 9:51 ` Aslan Bakirov
2020-04-03 10:01 ` Michal Hocko
2020-04-03 10:21 ` Aslan Bakirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJth39jAYvCvMruAPCB+jjwB0VrcSbfLw2VeUNcJ7k+zKoRTdA@mail.gmail.com \
--to=aslanbekirov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aslan@fb.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=riel@surriel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox