From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E71C5C43331 for ; Fri, 3 Apr 2020 10:22:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9B1B2208E4 for ; Fri, 3 Apr 2020 10:22:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kppkoxna" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B1B2208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 114FF8E0008; Fri, 3 Apr 2020 06:22:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C7AE8E0007; Fri, 3 Apr 2020 06:22:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F26A18E0008; Fri, 3 Apr 2020 06:22:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id D7C3B8E0007 for ; Fri, 3 Apr 2020 06:22:04 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8C2D4181AEF10 for ; Fri, 3 Apr 2020 10:22:04 +0000 (UTC) X-FDA: 76666153368.25.spade47_2f31f7af15e06 X-HE-Tag: spade47_2f31f7af15e06 X-Filterd-Recvd-Size: 6690 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Apr 2020 10:22:04 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id b62so7377144qkf.6 for ; Fri, 03 Apr 2020 03:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gkew20bpFlSLF5VuYZLI3iK1Blony7mFYeebt7FQgqQ=; b=Kppkoxnaja+fFtYNWLkpaGTsPKWRsoUyC+vUhRu33ZsRilaeyvFMV0fM/pzDK1IBxp yhbo47aeGZg83E3syaYYUyCOxDlmjXGi0GFYyQIYZhbOsB0cvbBOw9xHCd8Eu0QgOOXu k6arnCSrhYBf/WJfU8Yrz0QqkVbvinT9bwB4SXJdpnVOzfip68904p7TUHHj+YugX3J8 8FMjKZM7QOvel/jYXPMu0+exVY5EoEhnrDXoOCJpFohas229vAKErdU/NV+oOCX8PFKH 8LR++pRKynM0qjsi5Bzgg89RPkKnTJSc3dQl1ye/52c4LGNwm75KhI4obz1fzEArIwiY R86w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gkew20bpFlSLF5VuYZLI3iK1Blony7mFYeebt7FQgqQ=; b=Bijy5akohNYGtFawRat9+ekujb1Q/BWmPZiY8wg1x6RF2/O6JXn+aAa9vzrJgmLYoI dwT8+oFb7BYwSFUVww5hKDpvHVzqXME5ULqic0TmZpSMMa5A1SGNz+FCp5OCPGtmNzVy 4hCFCVWoqqlEVsxOGEun9PHzub38SQzIDQ/2jDxCCi/8eWeJBV/TxVu9nA4+LW9ipdi0 ozCmcN2UIUrT+DF9Du6iWKBZoSYfnoNw0CA7oIv8qVcOEKs+sAZoKGksnKEM8cUzfKyu /7RbksPKphcqXT0v8wgnOSYVZtMGyPNdO5/R34ivVATctrmhN7VUENpB8gzBiuN3fgLV UEpA== X-Gm-Message-State: AGi0Pua8wtKWadD4uM4Lwg+YJMTK5BFYiUN8fSDg6FjFw55IPpatWq4S +E4q2sJQ1SkVfdnkLiYaycKjjnQawV0VUsS16m8= X-Google-Smtp-Source: APiQypKroAEK4R2aenYLnqNf4+S6W5rbJjF9nR3VHVSa8p4msxYVjkzSd3re9sr1b5+0B+Vt602JbLghPDCxSZNPYMg= X-Received: by 2002:ae9:ebc1:: with SMTP id b184mr7814435qkg.49.1585909323528; Fri, 03 Apr 2020 03:22:03 -0700 (PDT) MIME-Version: 1.0 References: <20200403021254.2842224-1-aslan@fb.com> <20200403050205.GI3952565@iweiny-DESK2.sc.intel.com> <20200403100120.GY22681@dhcp22.suse.cz> In-Reply-To: <20200403100120.GY22681@dhcp22.suse.cz> From: Aslan Bakirov Date: Fri, 3 Apr 2020 11:21:52 +0100 Message-ID: Subject: Re: [PATCH v3] mm: cma: NUMA node interface To: Michal Hocko Cc: Ira Weiny , Aslan Bakirov , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com, riel@surriel.com, Roman Gushchin , hannes@cmpxchg.org Content-Type: multipart/alternative; boundary="000000000000dffe6905a2604921" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000dffe6905a2604921 Content-Type: text/plain; charset="UTF-8" On Fri, Apr 3, 2020 at 11:01 AM Michal Hocko wrote: > On Fri 03-04-20 10:51:32, Aslan Bakirov wrote: > > On Fri, Apr 3, 2020 at 6:02 AM Ira Weiny wrote: > > > > > On Thu, Apr 02, 2020 at 07:12:56PM -0700, Aslan Bakirov wrote: > > > > I've noticed that there is no interfaces exposed by CMA which would > let > > > me > > > > to declare contigous memory on particular NUMA node. > > > > > > > > This patchset adds the ability to try to allocate contiguous memory > on > > > > specific node. It will fallback to other nodes if the specified one > > > > doesn't work. > > > > > > > > Implement a new method for declaring contigous memory on particular > node > > > > and keep cma_declare_contiguous() as a wrapper. > > > > > > Is there an additional patch which uses this new interface? > > > > > > Generally the patch seems reasonable but we should have a user. > > > > > > Thanks for the comments. Yes, actually, this is the version 3 of first > > patch ([PATCH 1/2] mm: cma: NUMA node interface) > > of patchset. Second patch, which uses this interface is "[PATCH 2/2] > mm: > > hugetlb: Use node interface of cma" > > It would have been much more clear to send those two patches together as > you can see. > Sincerely apologies, sent them again. > -- > Michal Hocko > SUSE Labs > --000000000000dffe6905a2604921 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Apr 3, 2020 at 11:01 AM Micha= l Hocko <mhocko@kernel.org> = wrote:
On Fri 03= -04-20 10:51:32, Aslan Bakirov wrote:
> On Fri, Apr 3, 2020 at 6:02 AM Ira Weiny <ira.weiny@intel.com> wrote:
>
> > On Thu, Apr 02, 2020 at 07:12:56PM -0700, Aslan Bakirov wrote: > > > I've noticed that there is no interfaces exposed by CMA = which would let
> > me
> > > to declare contigous memory on particular NUMA node.
> > >
> > > This patchset adds the ability to try to allocate contiguous= memory on
> > > specific node. It will fallback to other nodes if the specif= ied one
> > > doesn't work.
> > >
> > > Implement a new method for declaring contigous memory on par= ticular node
> > > and keep cma_declare_contiguous() as a wrapper.
> >
> > Is there an additional patch which uses this new interface?
> >
> > Generally the patch seems reasonable but we should have a user. >
>
>=C2=A0 Thanks for the comments. Yes, actually, this is the version 3 of= first
> patch ([PATCH 1/2] mm: cma: NUMA node interface)
>=C2=A0 of patchset. Second patch, which uses this interface is=C2=A0 &q= uot;[PATCH 2/2] mm:
> hugetlb: Use node interface of cma"

It would have been much more clear to send those two patches together as you can see.
Sincerely apologies, sent them again.
=C2=A0
--
Michal Hocko
SUSE Labs
--000000000000dffe6905a2604921--