From: Jaewon Kim <jaewon31.kim@gmail.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Jaewon Kim <jaewon31.kim@samsung.com>,
minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
s.suk@samsung.com
Subject: Re: [PATCH] zram_drv: add __GFP_NOWARN flag on call to zs_malloc
Date: Wed, 30 Mar 2022 18:11:46 +0900 [thread overview]
Message-ID: <CAJrd-Ushm_t6voCEuTpx=Y9cms2QsRPvjkO-JAdLcwcedZ3k-A@mail.gmail.com> (raw)
In-Reply-To: <YkQZi5WFAwbqWKNZ@dhcp22.suse.cz>
2022년 3월 30일 (수) 오후 5:49, Michal Hocko <mhocko@suse.com>님이 작성:
>
> On Wed 30-03-22 10:06:18, Michal Hocko wrote:
> > On Wed 30-03-22 14:25:02, Jaewon Kim wrote:
> > > The page allocation with GFP_NOIO may fail. And zram can handle this
> > > allocation failure. We do not need to print log for this.
> >
> > GFP_NOIO doesn't have any special meaning wrt to failures. zram
> > allocates from the memory reclaim context which is a bad design IMHO.
>
> Btw. I forgot to mention that GFP_NOIO doesn't have any different
> meaning than GFP_KERNEL from this (PF_MEMALLOC) allocation context
> because this request will never perform a reclaim.
Thank you for reply
Yes it was kswapd with PF_MEMALLOC, but I thought this zs_malloc could
fail on direct reclaim context.
I think zram is gracefully handling this ENOMEM situation, it actually
accounts the failed count as zram stats.
The failed page will be tried to swap out again later.
Yes I need to look into more about this memory shortage.
But I thought there were too many ALLOC_HADER requests in a short
time, and I want to see other
allocation failure logs like one with GFP_ATOMIC instead of this
zs_malloc failure log.
> --
> Michal Hocko
> SUSE Labs
prev parent reply other threads:[~2022-03-30 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220330052214epcas1p250cff6b3168a1c9c253e1fe70e68ca8b@epcas1p2.samsung.com>
2022-03-30 5:25 ` Jaewon Kim
2022-03-30 8:06 ` Michal Hocko
2022-03-30 8:41 ` Sergey Senozhatsky
2022-03-30 8:49 ` Michal Hocko
2022-03-30 9:11 ` Jaewon Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJrd-Ushm_t6voCEuTpx=Y9cms2QsRPvjkO-JAdLcwcedZ3k-A@mail.gmail.com' \
--to=jaewon31.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jaewon31.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=s.suk@samsung.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox