From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B58F6CF9C68 for ; Sat, 21 Sep 2024 07:51:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4FFE6B007B; Sat, 21 Sep 2024 03:51:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A01FE6B0082; Sat, 21 Sep 2024 03:51:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EEE76B0085; Sat, 21 Sep 2024 03:51:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6D8C86B007B for ; Sat, 21 Sep 2024 03:51:17 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 71EEA808B2 for ; Sat, 21 Sep 2024 07:51:16 +0000 (UTC) X-FDA: 82587974952.18.5DB7AA1 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf04.hostedemail.com (Postfix) with ESMTP id C352340006 for ; Sat, 21 Sep 2024 07:51:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WSLgYwdz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of jingxiangzeng.cas@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=jingxiangzeng.cas@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726905041; a=rsa-sha256; cv=none; b=i5ufTZxiYOJPXGmuO25dscNa0N60ak9O143NycF/N7Ivl91/R1RZTSV8tcvAG1POX7eL6w urHM+SGjSjaJRtOkEjnHoIa2DjCpWWRgX+yeDsPxYMz33yZHJn+Rdl91Nn0unou5ZCkB4m Fl14VORCTQa64As0PpzgNK8PAhl/pVA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WSLgYwdz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of jingxiangzeng.cas@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=jingxiangzeng.cas@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726905041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sBaYPDTXxYwaESqW8DBuiZi7wSnkr5v5D0zlShXrWOo=; b=R9tnWBZ2VbEdPOpWrRp40KroA3OrKpTS7DC0ksAGjgQUxOnxhddX3MIs7lSpwi4h06mAn8 UQoVncJWjfqv9HVLHkexpqQbULM/SFHfgDMOQCYWVdjx6aBgRfE2iz1ReD6a2NY7RXyYcx ngKWESNgTODgzcDSXrjptsindmKmCo8= Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-71798661a52so2206170b3a.0 for ; Sat, 21 Sep 2024 00:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726905073; x=1727509873; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sBaYPDTXxYwaESqW8DBuiZi7wSnkr5v5D0zlShXrWOo=; b=WSLgYwdzCwgcZO9oAvImWFH7V7CUb3ixl0v/Ph5r3AyLxFFfgL8KSQTjnEqR69MNrR heEY3N+9Iig4NT9tq51JrkLUBn73Q0uIt+YAOXoqG8YIwrmi4tdtJfO9CFCtxLxcaBWB 5Ec0zGifmuEn+fiUUuW1MhxcPt7yhZia7+9SCuoQt67AwCJVceZgvyVBAo40wLCXLyNt iWDoJBJICqkn78lRRYjkgrrYbrc8FbXmIMQBMa/SDtLruzeBy/QlQQuvK09zEBiVjtsu ol6MrKHBS6WMWEAVPkSRtCtQhUdfFqYXRjQi1MYCDGOcewZNbC6X7sHDvs2NJTcS19Nw 7Xbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726905073; x=1727509873; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sBaYPDTXxYwaESqW8DBuiZi7wSnkr5v5D0zlShXrWOo=; b=t6iXfXpzWrbV8hKG0dnlxoFRHdL9YvPAzKw91PlGaVPspmpK6lBTxi+sOuIZ888hkm AFP1UGFsGsOC7FoSJLUm2SUFIm2cAs9s7JZ3GlhHSpbljGGXAZobzKDfpT3p31LTafyV G58TWgQGjMN6CqIIjoukCFQL6/mfOIwFh5fmKASYP3hwOqXBF1aU6cb7qxqb+ygzUr+1 vEdYDgQeWNpld8SAA6ihGGD4hAYuE7Cu591AbPx0OIqrWnw2dzmbdcpvDL2CUe6hvip1 oWBw5rQNiuaShs5Ze9N3MUkLys4gK1Dquj80cNdRYz8HSst6zYnxDpETA2Tzp2EcV/jq f1DQ== X-Gm-Message-State: AOJu0YzaoUoUIFhiX7p4Iq6S/VkE67Vvi35rIwSd/XyDuIgIOPZZSTBR AD/5D4yb4DsYg1ra1GbLWYrAYENQ3IzdY683bZh0kqEE7gYtfOb35d8A17ratooaK7AngronPhb 0Ap4NzEbU+zhvTYmTjjdmnwU8pVwMBncn X-Google-Smtp-Source: AGHT+IGZwn+VHNRYjAYnGmPX5f/AYK0jICvMvI2FP0cILSB0OBhtqtYl0eEoesDVuPDwaZJvKMba0MvbHNyHr+foQC8= X-Received: by 2002:a05:6a00:660e:b0:717:98e7:3d0 with SMTP id d2e1a72fcca58-7198e14025dmr12457725b3a.0.1726905073361; Sat, 21 Sep 2024 00:51:13 -0700 (PDT) MIME-Version: 1.0 References: <20240913084453.3605621-1-jingxiangzeng.cas@gmail.com> <20240916004134.0ef2f50862b59079e1ac2928@linux-foundation.org> In-Reply-To: <20240916004134.0ef2f50862b59079e1ac2928@linux-foundation.org> From: jingxiang zeng Date: Sat, 21 Sep 2024 15:51:01 +0800 Message-ID: Subject: Re: [PATCH V2] mm/memcontrol: add per-memcg pgpgin/pswpin counter To: Andrew Morton Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, linuszeng@tencent.com, linux-kernel@vger.kernel.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, shakeel.butt@linux.dev, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: C352340006 X-Rspamd-Server: rspam01 X-Stat-Signature: c88pjaibwu3bezqrgayj7mtfowesttgj X-HE-Tag: 1726905074-926402 X-HE-Meta: U2FsdGVkX1+nKLFeNwkP8wYMb/DUk17sErZVj07M6nnjsvqOwxB7zo3l6MGDX2W0ZYcA+V6EfnCjOhc1LccX8Q8pVmgOJ9vPZA3r0kBm9r3IbFwc58Ky7XewT+TD470oq8Z0U0oIx4tyMsDRFkmrtSZKV6oz7cXeCDVR+pWwFE0kL03OEdHQPMuPHZBQVQ6v633oFV7WrDYpgIEvRQVNqXJcoHvFBlUxMJX9MzAySnZC8O0Fqxt4ECBZyveCx0cNF7hQj9Erbt6wLfEvIRztwh1V09M5KMNsi+/7og4x1pXb3RElnNab3y0DqRmq17GBgALKJHR4XQ5G8UzTuTPqoggMdPl5FjNYQ0sc8N1HfKcc5H4lWBPsFEILwf9ek7OakiunHb6aTc4LX0+fFLNZbVvnK4RoFcpG9BLbKGp9/XogTKcYUhlF6KrQrNnvlZR6f82YEflD2Yxa1ui1h8SlkvWwofcHuHfIHu+WXlVk+lRlygdIaKYWx5RY0hs0BxAaINRwz8FlyGtAW2wQKIfQiCH5L7vT3udm4rJy4N1TTDm+DhalVMMTs22zHEmeO9eXD2l/HwRlxSmertqz0pdlbBeJWq4KM0OQvuzokJvu6/VY5q/Z9zJUj5zgQ/dSkQex7HVBDewC2DMCS589Rj2izr9he2BKTINbPSe8C8XU6dmR6ubfPAWCF1HmJ+mIytBdZDUco0kpkoNZbtqWFgnIFMPi8eSy/p53x8XyfoUsdw/EwPgI98988QIgOe32/Yi9DfkANC5KLEaj6xVP6wDOyzP+Px1cFONIByW+NP1iOvqlx+zuGHgQmBbi8pihHIV1ddiUeQA079UN+Xzt21ZMsK3LlspLLHcdjSDwfGQXrfIoB0n6M1Ug4b6UedwR+76f/ltD27QSySrjuioUGafGi17BjpyOVSyunCs49+jtC8SKKVXukmcLoZ8+9j+Y/H5b0QHW9v2uy2NYC9hKU6f aEWQLBGe tpjG6S2xq2ymJu5wvMQPNZBoLtqCwVVGqawmkUQDUJeM/QYgJTloWa3nX06tpfk14acnXTzJJKcdIM2w7QtLWPv0JEEZx1loCp4/bXcMwWlb+HjXVi4rVKTROHQuc8BCr6enbHm185rHDC72nHQXcAKp3S4sz7PUphAvNAjtaVnMnFfRFWPdvqaj8Y2sTUwI+SHFC/LXMkOjsrf2b/KUeH+IAweBGPxOi5B3Y5+f2Fpej4Fy6uqY/qSzldUTAk1IwX/2u9J7mp6tQ0a7wM2rkS1t1E75zD1+uZ3qtFxaFkaNgbadZ3Z3R+yE57tP6IDDetEz5TXmorDS8A3IJ9GV6XerIOz409K4Ew5STOx7KOG6/FPUJOccsXPDy/Bp2EHFeue+t/b3YTOgjz9f/pXkrqpNqmwgEO2RWBdBn5YpauBXwL3qqP5cp+khKQqkbmwJnjZjvvLKhepIvWC8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 16 Sept 2024 at 15:41, Andrew Morton wrote: > > On Fri, 13 Sep 2024 16:44:53 +0800 Jingxiang Zeng wrote: > > > From: Jingxiang Zeng > > > > In proactive memory reclamation scenarios, it is necessary to estimate the > > pswpin and pswpout metrics of the cgroup to determine whether to continue > > reclaiming anonymous pages in the current batch. This patch will collect > > these metrics and expose them. > > > > Please explain the differences between v1 and v2: Currently, the PSWPIN and PSWPOUT fields are only used in proactive memory reclamation scenarios, but memory.reclaim is only exposed in cgroup v2, so here we simply delete these fields in cgroup v1. > > --- a/mm/memcontrol-v1.c~mm-memcontrol-add-per-memcg-pgpgin-pswpin-counter-v2 > +++ a/mm/memcontrol-v1.c > @@ -2729,8 +2729,6 @@ static const char *const memcg1_stat_nam > static const unsigned int memcg1_events[] = { > PGPGIN, > PGPGOUT, > - PSWPIN, > - PSWPOUT, > PGFAULT, > PGMAJFAULT, > }; > _ >