From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D14FC28B30 for ; Thu, 20 Mar 2025 08:40:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 762C9280003; Thu, 20 Mar 2025 04:40:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71155280001; Thu, 20 Mar 2025 04:40:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DB23280003; Thu, 20 Mar 2025 04:40:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3D614280001 for ; Thu, 20 Mar 2025 04:40:30 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D0945120E46 for ; Thu, 20 Mar 2025 08:40:29 +0000 (UTC) X-FDA: 83241282978.01.E31A485 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf24.hostedemail.com (Postfix) with ESMTP id 02A4A180003 for ; Thu, 20 Mar 2025 08:40:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DBhdNCoz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of jingxiangzeng.cas@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=jingxiangzeng.cas@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742460028; a=rsa-sha256; cv=none; b=wB2N6TuT43WNH3v+GpNHuvXZEB+rEjGiGa+Z/cm5/lx16yQdqDtwCSp5fYExXYjNsOMJpi OUEH6Q2vOyMu2HWGQ0JtWXQKRFv9uPShMOznUGSVgoj+QLfQMP8+sYyZ8NQ9lDdGLqQSwu nL+K99GjWl0TMnBYBmxwJyX7FPGxC28= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DBhdNCoz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of jingxiangzeng.cas@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=jingxiangzeng.cas@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742460028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dVd/ZBXvrG6lnjcdZIt7lLZlK0ue2XgKgxaXwwHZOX8=; b=Her9XP2l7mU8gb4DU2vCpNqcfMJpBiMf0zcPHjViNW81xXo+/B8ssBEVF/p2VgggOKweBo f9H3XDTD0IaUrH6xKyJti9QI4Us3JH7PSXqVvxiD3vcKdheW2RFa8GnOC7AMct3Q8PPSmG /CU0h/RhtiaPr/4GC0CiOq4uacF80Kw= Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-300fefb8e06so957720a91.0 for ; Thu, 20 Mar 2025 01:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742460027; x=1743064827; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dVd/ZBXvrG6lnjcdZIt7lLZlK0ue2XgKgxaXwwHZOX8=; b=DBhdNCozYX5QtKzDPcQb6cAxSa9Iyomk+Oz5E8iEaBRpaI9plgt1DJ2yEhMk7TV8ko Qpbd7Lzh9KPQ3bmOboqcXE8U4aWulVBf/zwqQYcrAbjnnTBIK+c3Fj6vfaZQNEiWljMt h9BlmoS5n7pYL07f1aLNHAiyAeYKiv7Mpn2TvMLrjEOz+OKa1bcWemXfsHOfYzFywlmc jmnTq/+9j6wWOlSNmTsse9JViOPim0MKrycd3c4pp5s8kF4MY/C4JHHr37QgpQrrHE2k wH+CfE7QlYKDAmhloE5sMwFal05SY0EQzS58Fz1qGMMrVeoZg1Nqq88ELh039wqMIOf6 YBXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742460027; x=1743064827; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dVd/ZBXvrG6lnjcdZIt7lLZlK0ue2XgKgxaXwwHZOX8=; b=TNqcEkyB0sMWRmYdSeiv/HnUngPmfDH70ywKXg7cO7bGE4beBVcGEL8Vqgn1otueCa NpfyTkL989X3uWFYXmyrFIa7BdFrvoALCmOpEakBVZU+coZx0CbNMzWzNe6Zt/fb626u spethlVgtKJn3pOVdboltFjEuLC0ftdoj2KG6oFqb2NwDS/v97sxpNs3ZrLNss11CZSz 5ZTYTKPftACIr+fZWZCciHuK+XoRHPIEnqVZZIn25J2dCLKicjcEpaD61p+t0ElPJCyV OnsrBFwqb4RWLt0D7ahThdaPN/7kVAzpdgORXGpxoxh0LiBtKFaktJYjlRNdT3b0xWpC raZw== X-Forwarded-Encrypted: i=1; AJvYcCU7FGFqRHgqIj1t4GdUjwc8obPxTNefwBQX18jwx9NUjDEAx4vGfr8kgDgxrkE5npH+yH6FmeocPg==@kvack.org X-Gm-Message-State: AOJu0Yz5p2iey0gU/fmh5cajJR0nKtgYPpZrWk0K+8E5VqVadRGJfFdv ngTb/B82+Y8N5OQ5NFbQo6PzSo7FrQeRPgfDcqEqml8RDguHderYlKt7KwF7wTNt8XiZKGXXPcs 7XAA4QQVarkF4rNzG8qydrchSQwk= X-Gm-Gg: ASbGncuDO4vRXC/wAGcrZsNzMNBgPpsObfUbYpopY5SzExRGTODpbAPt9RKamoA4gBk 2C7N7LOrVro276sLXBMuN0Lk38RVIe5pdYDzkEmFsWjnTIwgTktJnKLr8zydAnqK48EFRBZWyA7 SpSzfJrgPzPzrnVPpiNAV8fTW0xm+sGtBdw4A4 X-Google-Smtp-Source: AGHT+IFnbz5qpFjRctSSuumMXr+KaUxXcHLgw2e5AyzG2DYxcLVSBzkyHZbKqDi1snIiVqAsLymg1Mn94/xMonoJpDM= X-Received: by 2002:a17:90b:1648:b0:2ff:6788:cc67 with SMTP id 98e67ed59e1d1-301be206e87mr6955304a91.34.1742460026630; Thu, 20 Mar 2025 01:40:26 -0700 (PDT) MIME-Version: 1.0 References: <20250319064148.774406-1-jingxiangzeng.cas@gmail.com> <20250319064148.774406-4-jingxiangzeng.cas@gmail.com> In-Reply-To: From: jingxiang zeng Date: Thu, 20 Mar 2025 16:40:15 +0800 X-Gm-Features: AQ5f1Joe6olwPvvRJlL2ei-eL43OXN8oSn3ipfQx4xJ7f7Wo8JpKOMpsLQNudSM Message-ID: Subject: Re: [RFC 3/5] mm/memcontrol: do not scan anon pages if memsw limit is hit To: Shakeel Butt Cc: Jingxiang Zeng , akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, kasong@tencent.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 02A4A180003 X-Rspamd-Server: rspam05 X-Stat-Signature: a1xxxbhphbe9nar1di7j36uk5pbxufc4 X-HE-Tag: 1742460027-993802 X-HE-Meta: U2FsdGVkX18TKKsAPG6pUL5Ya8+nSVXtd7DSyl1K6IkBY9Go1gkUI+SBRem15BhjTAUvRodYu6+l5k51O9ybkUOeg2ZWd8DSMNJlC/huwNsk3U2dDdsjCQMUL52/O2eRKyaNDldt0wJjA92pizWKLIfA0ZRt5HR6pnjbYhvrl1NEi8gTtmdxtpnnX/s6UD0ZDpDP2Zboybw/F8nwEe/JZq/g1QSONZXCKYZRpWKqxw+vT44Sg2p/qPoxycJoAXrW2CRIz6wAN7IlOtVI74EjeeqSA3p+I1x51a2WPy+jQpQNq2i0MyseZxz4bs8SElvZF53hgsJqvCW0/25SzUdRvDBipEAzYnLiYy1Fe0xfBiDDFX7MNElCCcgkADxweH1Q0dDpjUO8V8rxXosDx0diLGvEWZAWjXg47b86UbWYqzO46x/IWEcConc8Ev4uwXVid1Fba1Z4zd0KMllAT23TbRPtALEclPvBS/xZ3E0S4TvJj2tZZGGxNO3PjejFljL2XHjNrRdfZlC1x+Jz7qbSK6C2HUeNU/ml62fF4y5qLnNNwk7K+OaCeekggRqKCbswDTv5vbNsqaKllktEhbPJvaxdcFVo6Qh/cQJvhN+gt3CqxIwJ/GjSMbZ4sv5ttLTgst9utGi82I8B9yILtMmdFbPlrv93rz9jtK+ozw0seYI6imMQmLF8mf73wzEwa3ZZW5IMEzdCposbDUVSBgeQyC9T1H8w6TTWA+azs58IEIPuM8TdnyyTlTOfec/p1q2wJxVtlfIfg6CrGBuh4iI9VbyeepjnQu0kZtdzrhQX9pAwTCY5/jua4fjwZCuuur/hEQ34wfwIUJf2qahQHC456XTPjPwyxZfCrrlRh5gBBvn0THQDLj5No07t2totlDOAam7qwRdgU9wi5GZAnthcANLFmKnBUfQ2lRm1LsRlAHFW6MQZoQPct0Kjb2osE/RY9j9LjKsK5Brqm3SUs7T yUmFYDw7 UlyWA6KDj6x5Oh70N54Otaisbkgef7mbrw8OVfOJV+JGaUzBqbO53jhnxvPFZTqx8D42VrRz+TUz0+wiD+x/deFn3XtedM+PB8h+vt0rQanQtWDNPvBz79eqv9rAkUO0Z+qec6SPLp+415QcidQr8sTLCZ/FAiz/FiAyV3MRJjBBZKox5vOH8Zt9PLsf+VzZ478WJmWdsHthuY5TJo0/QvJq9JW8cLbLZp02JiXsnsbjOwPeEhq1H1eKna+zmMNeKBj/Wm4vY43MENsBmtDlQ25pUjIeIqwP1baDAGKyF1arFxGkCL4CdJTq8amT6KZaVpNcAWVoVlyuI2sWX4ojWccYfc3g8hecfBI/3UVcy46Vn4MSUNxrOfCSRnA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 20 Mar 2025 at 03:36, Shakeel Butt wrote: > > On Wed, Mar 19, 2025 at 02:41:46PM +0800, Jingxiang Zeng wrote: > > From: Zeng Jingxiang > > > > When memory recycling is triggered by the hard watermark of > > What is hard watermark? memory.memsw.limit_in_bytes. > > > memsw, anonymous pages do not want to be recycled any further. > > This is consistent with the processing method of cgroup v2. > > > > Signed-off-by: Zeng Jingxiang > > Is this patch orthogonal to the series or is it needed for v1 as well? Yes, it is needed for cgroupv1 as well > > > --- > > mm/memcontrol.c | 15 +++++++++++---- > > 1 file changed, 11 insertions(+), 4 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index c1171fb2bfd6..623ebf610946 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -5072,14 +5072,21 @@ void __mem_cgroup_uncharge_swap(swp_entry_t entry, unsigned int nr_pages) > > > > long mem_cgroup_get_nr_swap_pages(struct mem_cgroup *memcg) > > { > > + struct page_counter *pg_counter; > > long nr_swap_pages = get_nr_swap_pages(); > > > > - if (mem_cgroup_disabled() || do_memsw_account()) > > + if (mem_cgroup_disabled()) > > return nr_swap_pages; > > - for (; !mem_cgroup_is_root(memcg); memcg = parent_mem_cgroup(memcg)) > > + for (; !mem_cgroup_is_root(memcg); memcg = parent_mem_cgroup(memcg)) { > > + if (do_memsw_account()) > > + pg_counter = &memcg->memsw; > > + else > > + pg_counter = &memcg->swap; > > + > > nr_swap_pages = min_t(long, nr_swap_pages, > > - READ_ONCE(memcg->swap.max) - > > - page_counter_read(&memcg->swap)); > > + READ_ONCE(pg_counter->max) - > > + page_counter_read(pg_counter)); > > + } > > return nr_swap_pages; > > } > > > > -- > > 2.41.1 > > >