From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1477FA3727 for ; Fri, 13 Sep 2024 08:06:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C2DA6B00AC; Fri, 13 Sep 2024 04:06:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 572196B00AE; Fri, 13 Sep 2024 04:06:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 460DC6B00AF; Fri, 13 Sep 2024 04:06:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2EAEA6B00AC for ; Fri, 13 Sep 2024 04:06:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A954B809E5 for ; Fri, 13 Sep 2024 08:06:06 +0000 (UTC) X-FDA: 82558981932.24.DA7F43F Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf11.hostedemail.com (Postfix) with ESMTP id E33D740010 for ; Fri, 13 Sep 2024 08:06:04 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eGm+XLO7; spf=pass (imf11.hostedemail.com: domain of jingxiangzeng.cas@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=jingxiangzeng.cas@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726214711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zblplU9yow7GMYopy1E/IBLw2FDfeEv6pZ/jZLC49h0=; b=Y0klSaftTvXMotZ2kyNeJCgf1M7NIeQkstcb531OTDAupZoLh4HIPcjS5pzBNPGvFfwwyz BdvsR3Kn5cSts0CeNg1IeZ3aiCurNaVfPsj5PVAEabjcQpJIo9XkesT5itgEqOUNV1OCgM DVnAW69wLRii9ovA50UloDjNHoIIU/0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eGm+XLO7; spf=pass (imf11.hostedemail.com: domain of jingxiangzeng.cas@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=jingxiangzeng.cas@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726214711; a=rsa-sha256; cv=none; b=SWBvKal17iaMNjk+UarqAeT97rOpl9DWkBMnIOoCl0k3e9U3fFncswPnIIAhmIgeoltjD5 8Ff9PAdYPB5xLjaoGI1KbOEYjysndjNUSc43smn/n7cfcdr3uTyKdNY3Kg86xooY1ld7Gf IfSYlQk9xNIa+fgww/iScJziiAlxyhc= Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2db89fb53f9so1298764a91.3 for ; Fri, 13 Sep 2024 01:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726214763; x=1726819563; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zblplU9yow7GMYopy1E/IBLw2FDfeEv6pZ/jZLC49h0=; b=eGm+XLO7Rk1E8HsDKux0wqmIeLq5wKjU4QYtc2OIj2fI+05bEUeLT+tMekzvpiZl0s lyDzz0b6EzGGA5ktzo5okwbEX+Qfac8+zxFDVhPrJ8UX7FsNF6pYKJOPrW1VeY6ZvhhD MhtLhPlusmdovxSpXDWFv2UtrMfi7OB0xYWD++u7jP9HAyVU9MORDMmseOi3rBBhjkbq QJHzus79MiB0f15N5XfCyuq+Xz3XyJPlmx1ychFMkKHyGs+1sL17nbPrcjKtVqVvpn/M xLPUAoMagdrYdv0QhnjweOXoDXzCjO6IIRHUQxoWMpMdPHQS97WAxtXlAWHMJyHJGdQo fTCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726214763; x=1726819563; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zblplU9yow7GMYopy1E/IBLw2FDfeEv6pZ/jZLC49h0=; b=qGGH1dOhB/QwR8y6qXQLcJm6O4RE9WtBpB+EkDuIIXKq/FJyy4YqPPe6FiwWLOeQg4 ZLYmLYIL3X6/3dCxxA8zsacjTQXoJDPYJ44pmbc541AJqzswqBiQvqpGt5IWBfUG4xCm l9VKjo4Si4Mrh2wFfABKz76zaprXR/uL5W+nBs3dPRVze3Rre1pQLQtZ98lTcrTjomeW HIsK7YjjR5T/dPQfgoo/Hr0rxDie4WuHfmRypEd2torkW88/B9dXaDl3O0Ml8HygHGIH /72vWO0tKvYMONdhFo14LTypYewyyiDdcfba8GRmOI/kZhO60mZaA2QkFD1hMeyavi9x 9KRw== X-Forwarded-Encrypted: i=1; AJvYcCX44vqaTYYrcwa44snn+VOedNeDT4S0o1F2cboIagfTB6zzlLAuolp6Adl4mI7uim1BHeUu4UOGXA==@kvack.org X-Gm-Message-State: AOJu0YwuCSxVmg4TbkHx4Wdc8ZyS0+zTxWnYUHjd30m2T7OcZZ0fmU1d /p6WH6ABGA3qH21NnKkEL845XzfUR4sapLDH5NUYzIgE8B3Tw5xBOSpOix5KUGcDHMaEzlXGQeZ jXfqUPSd1zxn7hkp/9EINoOLXEQw= X-Google-Smtp-Source: AGHT+IHYLysGhGvGSCWMgEKAQslDaU+U3KUnr4CmtkyWsPOGe1CgIgN36TZphXJZQCjB2EDJUI11vidz1KiElaAKFpU= X-Received: by 2002:a17:90a:4b09:b0:2bd:7e38:798e with SMTP id 98e67ed59e1d1-2dba0064f3dmr6016181a91.28.1726214763248; Fri, 13 Sep 2024 01:06:03 -0700 (PDT) MIME-Version: 1.0 References: <20240830082244.156923-1-jingxiangzeng.cas@gmail.com> In-Reply-To: From: jingxiang zeng Date: Fri, 13 Sep 2024 16:05:51 +0800 Message-ID: Subject: Re: [PATCH] mm/memcontrol: add per-memcg pgpgin/pswpin counter To: Shakeel Butt Cc: Jingxiang Zeng , linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: E33D740010 X-Stat-Signature: qdyaqe145susmnk6c38ppszejshncf7f X-HE-Tag: 1726214764-675652 X-HE-Meta: U2FsdGVkX18fBkacRo8F3JOCAU/Z7f/K6aXgWVkT7Ktt6rgbtseOOVLXU/swb2vkwj+iWpj4mvafheA4Ntc5/KSrmsyRL9lg/w7toPdq2BQ4guVZlzBf6OUBjUnoMHZ083hv2Dattwz15dPk4ii+VUUrZnSRq4jD9PdqzDx2LbWVwtKhkbD8Y2ku249y+Gg4BNY1mzuVHeJJGYpVzB9m2mgEUaiLffd9Fvc9jhA0Cq0ffOGlsMaEiePXqQinTOmzEwjbNiwuqvCg2AJt27efnWa8HvO0imVr7Of82IHxY/HvvKYQi7U2OrC6Wimff+ao1VCKpHqmmB4GtG6YspbGi2I7tVyLbSZKTvKsTG3xfuacFVysBISG8sN0NmI67VXO9BS8zgTbW8rsSUFCEB/M8A6YPRN1IxfPkSak+C5p5CzfwPFTkbTMEb+K61P9f9MSADyjnbX7ggwnFiryRxAZiHqiuIsSO1hkUtyB+aGK7+6UipArdiza+/DiDXTJGVfDLEaXaaKJwbUyikkRhgWOnV/DJLbTxyqqEOXv1nSWnAW37wrQLR0xuz814wiVSoJOuztLdP/Fbl225QEcucH1VHwCujURwKTRV3AWAIuvCrZdldU1Zq9h+BFo6gJ6VYpqxKCeH2JF4iji9LyBBGVG563ecm27QYT5hqWHK72JE+7YsSaw42I2KsMF+nWNpiE39Fd4FMBB2lzkSq3RQsWQVaeIIDMiXe+XjDykTjUoibTNx8uItAzLSr7+mg9H+ldC3i0z2DOwD+DHjibsaghmCrdrf6BmDbOh3l9R6pgZpA/RNDkepsrcBDveseT40H8hu4yCpkZbsDY6hORb+FQaXsZopcDql+rUXni7Rc9rizWaEHiBCVrP76seu5iD3RgmVGTKe4kDXCP43QhIxQ+GjgubnnUSyDs6jvPqjkqkXxcKWtKJZ3ZCuqIz4PMi1PGbblZ5TbcVfcYiGWB3HB4 xIDOde3C 6G/bG9p/CvO14/G7g/x/F7W5GohYfzz2/ZnRg8blmShGXYZcv78d9wuaM38uD4d9AqoS4tpKpsY+VdUn6Q5SMObqoBPW3uSKnj1tZqkIlfLOTyQiy7ZvsjTXThCWlsDhMIFNJ7yUYvM2WyNgvZHdOuFhnMZ8dUMlO7gmzYVgBZDGBUgl5yy4S/ktNlPd4xat7AEtCY80UJMWFZ+j981p/y+OcB+obAyPOrTJaBYvZyh9jstI7AJbXomLRpn3jp8eH35O/XdKjqviQbQw9OLSrOS/y6x5RbImev5kK3QOYTKqF4VqGVXvLT/ZxkFsKwBbbot1TB4rmNgf19pyF3ejdxbuGgNPA3Hkyn69tkXQVZn74bf/0mW8BSIWcgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 10 Sept 2024 at 15:10, Shakeel Butt wrote: > > On Fri, Aug 30, 2024 at 04:22:44PM GMT, Jingxiang Zeng wrote: > > From: Jingxiang Zeng > > > > In proactive memory reclamation scenarios, it is necessary to > > estimate the pswpin and pswpout metrics of the cgroup to > > determine whether to continue reclaiming anonymous pages in > > the current batch. This patch will collect these metrics and > > expose them. > > Please explain a bit more on how these metrics will be used to make > a decision to continue to do proactive reclaim or not. Currently there is simply no way to know exactly how many anon page was faulted in through SWAP for each cgroup. One may use workingset refault as an indicator but it is inaccurate due to shadow reclaim. We have a proactive reclaim agent that sets a forced swappiness dynamically for each reclaim, so we can reclaim file or anon pages striclty. Knowing the anon page swapin status is a huge win for estimating the workload status. And the swapout info is also important for getting an idea of how much swapout is effective for a cgroup. > > > > > Signed-off-by: Jingxiang Zeng > > --- > > mm/memcontrol-v1.c | 2 ++ > > mm/memcontrol.c | 2 ++ > > mm/page_io.c | 4 ++++ > > 3 files changed, 8 insertions(+) > > > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > > index b37c0d870816..44803cbea38a 100644 > > --- a/mm/memcontrol-v1.c > > +++ b/mm/memcontrol-v1.c > > @@ -2729,6 +2729,8 @@ static const char *const memcg1_stat_names[] = { > > static const unsigned int memcg1_events[] = { > > PGPGIN, > > PGPGOUT, > > + PSWPIN, > > + PSWPOUT, > > PGFAULT, > > PGMAJFAULT, > > }; > > As Yosry said, no need to add these in v1. > > thanks, > Shakeel >