From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA49EB64DA for ; Wed, 12 Jul 2023 16:07:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88DC38D0001; Wed, 12 Jul 2023 12:07:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 816F76B0080; Wed, 12 Jul 2023 12:07:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B76E8D0001; Wed, 12 Jul 2023 12:07:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 54B406B007E for ; Wed, 12 Jul 2023 12:07:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 049A7140304 for ; Wed, 12 Jul 2023 16:07:43 +0000 (UTC) X-FDA: 81003440448.12.C6E3358 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf27.hostedemail.com (Postfix) with ESMTP id 576CC400E2 for ; Wed, 12 Jul 2023 16:06:47 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ionos.com header.s=google header.b=V0Mwyzpf; spf=pass (imf27.hostedemail.com: domain of haris.iqbal@ionos.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=haris.iqbal@ionos.com; dmarc=pass (policy=quarantine) header.from=ionos.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689178008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8X6ArMXh62A5UxRR3ZN+q1CvObhoeb8ltfmXU1xj+zw=; b=zlXHOjnzxOtNSuJTzIqz4DMDYQHtQgNtIl+c36eQyW7T91hNAQETmMdfxJGLhSADvKBsps KpzldHvLeeUBoaeFmof5+7KpyYmq3NdC8euN+gExc15+rDTCUxwfKzVXwqVoPREZPjsxpU 2Q2LmCOeBm+WtOgVRB1pMxK5Cuh4j8U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689178008; a=rsa-sha256; cv=none; b=E10CP8zdybgeg245aPV4ZJZ6yF9dtbwcvW6kC548d5GXOcMSnBd5crms1z3QVqPWaug+e5 5EYfqi0WBvHl8N4NIR9X4EZRzNmcfu8m4YYSUp/+5oxaZ2xKG65dh8MKir/mJNz+T4KS4s D5XFnESkbe8BU/mwPcZYyLXTyDrEPi8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=ionos.com header.s=google header.b=V0Mwyzpf; spf=pass (imf27.hostedemail.com: domain of haris.iqbal@ionos.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=haris.iqbal@ionos.com; dmarc=pass (policy=quarantine) header.from=ionos.com Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-4fb863edcb6so11538960e87.0 for ; Wed, 12 Jul 2023 09:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; t=1689178006; x=1691770006; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8X6ArMXh62A5UxRR3ZN+q1CvObhoeb8ltfmXU1xj+zw=; b=V0Mwyzpfv5NHo344FebMkemb4OkDhqesSJzk3oLJrC1sXingJzi/DqoHJPX3cM7/kU /daZbGumusx7p3ETz9bL+dV7+a249DzrdJ5ucaxUqFs1cH4q4UNK1aBbCP0kRMVezgvK Gb0u18D1omT5qk875/bvJSIuyWWXlLKu5WnA0OT929rTcOY7rHqZVsWOvIcdQTq+Q4TI Xty8IQiQ2uEFjkBqRHhjaYUeIIjdk3TlKuW6ZBNL29/kZI8LKdOXvAAi+FiRNxSMUXsG 92h/diWQ5jGfG/Pc/9JTOLcLZ2bS8Hyd3sIfxIs/rFITeR6YjIQmonhcUevYE5m/zN7s SmPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689178006; x=1691770006; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8X6ArMXh62A5UxRR3ZN+q1CvObhoeb8ltfmXU1xj+zw=; b=HW5dSRqIaJuod2qSJ8pSUsm5Swtrb3UBHOHTd9wdRB01fxGv3VEbtEV3+fqVelxseq Z2Y9HEqxVVmg6VjeDERlKlE7mGFGk7ydoOZ+ScdefnUltnJJu94sjM6heTp8naxSfW9Z 19bFqJX9j3uv0ymypBkHNS76HYhSwBlK6ZUvYelwZ6XcGqwzuL4TfZ01nQz1yFJZ3IOn CnqGrtQFG4prWJArSgIxwe64IwMNophBrFpTJYkrTzjY7munWakKKlEh09KRihM+koiz D9CVwKbTD1/WQr7EheVM0GIXqg2kP1ggTxo+glbGhzal8KgviAgMmllUZFYIu5ZufEOZ ck7g== X-Gm-Message-State: ABy/qLar+zsz4QdHBZCLDMJ8RKWD0FgYAISsPzCrYVI4t3le5vLzfWue M6/vlakdg4sKFXk5hOtoNvNqSFM5GGaFOJRoGpY3yQ== X-Google-Smtp-Source: APBJJlHjPtNIqZNhhKZT3JSG1orBAozCwd3+TwwvFjulJuToD7D5iIrA7grwKZQU8Z67qc0UJ0oDxWof6WbkdfMRi3A= X-Received: by 2002:ac2:5b1d:0:b0:4fb:7a90:1abe with SMTP id v29-20020ac25b1d000000b004fb7a901abemr15797051lfn.49.1689178006211; Wed, 12 Jul 2023 09:06:46 -0700 (PDT) MIME-Version: 1.0 References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> In-Reply-To: From: Haris Iqbal Date: Wed, 12 Jul 2023 18:06:35 +0200 Message-ID: Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions To: Christoph Hellwig Cc: Jan Kara , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: kppmu1xymcphpasy95zwiigmw33dcg3b X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 576CC400E2 X-Rspam-User: X-HE-Tag: 1689178007-137408 X-HE-Meta: U2FsdGVkX18GVZYrbX2M7/kVFFT5Z2ob9Gizmh8U/pMISRKHGzT0hAZbZRRomP9SzGsz/D3EzUi9g4kKXCaWlDstz4zZjH0iexpk9Xq2bbhjwd76wASyjfaJvmu8BV0nlpvinidU6u15Yh3ZtjFVa7LtBohOL8UHhWFbowiFEcq2DE9Kf5BrskGX2au2VCLgc80gZlhuuNtIsuiGVi4RecCkWvOoZme+wILEntvFSA/w8BMj3iwQ75FTmi/tkeQtpEqCXy0bpr6T6hfGq6lH9f5dB1HhUVV4gvVnC7ts68SanqEYUg8OFnWO525cw7ih+kf1de0RxhZpgQAtFBCZDe586CrL4Z0QoaUPrd28GGGs+RR9TqAZmd8NJVn6cH/gePlAC75GycJPrdeXj4U7xcxwD4IGWxgXz3spsmeAJlEKj6g9BgHnSMD8A1ZAky8Bz/DA3Ufl/SIw6WBCA51hYBQq78pzf8NwREE+AoUClf9ZeCzNVOtXXm6pPssvnPtzo24EeCG1zRGAk1lmdHJB3apVY24BZMoUbTcJ+SWvDL/+iM5JjE8GJfMiL4mMIUBruze2fVjpjz0OfSDZQvDbmG1aAhr4p5Ro5x36N5AL1Q2iaykcavl9A5erHz116yR2j0MVHBX8Y6+p+YoXOV4JirIZ2mEo2r7+DZjc9vD7u8lpvjRI3c00d5KTRqJqQsQ0EkG6Jz9tiNIwpIbRsLFELMjowRJqd3vnyvvAzP+5sKhVUKEpaEkg0i2ZlnMQ9Do++A4XnKOZTuMWzx82yh9s+utq0z04CwgEuKUIGwOIeUEV1mgFYSMVY57QaCmCxNzO1V3xU7lyqfUvNCKLwNKnhgJ7F/GPmOhCbpxPl3gP0WZOFFXxKFEjfpQIgYETLMUMAdvcGzGiOyYcuNBHBUkT/CpfP875OXxIX64ilhQ5y8AMRZ3CFFia2oD74GE+N7j+oJPwM8tmvvgYdL+pOmD MRaektE7 arqwjUKOyTPSVcNOZa5ZXfVpAz0xPsS/X1G8bFXUG5V7+qSnLTMrBTA5yZKI50w2zZdI5mwcQEPV/UABnPMfwHkVyyoQyRxww7YvmMV0Ooan+yn1qjk1Qq2ZOTgiaxLjLyMBEjoBoUjD0j8Qj6LO3iRGmg93xRfWnBnI0WXfFCmVmcb3Xf5PeWotS+EGyxgoAwsMmkrGl47rs35ORUX4lOc/4MODWBab1/taX9xzXqf+9uQyCBq1TbYwKxnHz1nM53c7ewlKeCC/sUtmsY+e+kll3sWMujPWb8pNpqt53iEoGC5gEKqx6RqPdshhgvWyZ3mLqYQCbkpeSO1gL2AvIarPJzJTp5sTW6+fSUVICHsngdK0eSerLS63a6VqwXgFnZukG3R/b0r9+wdHpFnWr7LhXOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000665, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 6, 2023 at 5:38=E2=80=AFPM Christoph Hellwig wrote: > > On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > > Create struct bdev_handle that contains all parameters that need to be > > passed to blkdev_put() and provide blkdev_get_handle_* functions that > > return this structure instead of plain bdev pointer. This will > > eventually allow us to pass one more argument to blkdev_put() without > > too much hassle. > > Can we use the opportunity to come up with better names? blkdev_get_* > was always a rather horrible naming convention for something that > ends up calling into ->open. > > What about: > > struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *ho= lder, > const struct blk_holder_ops *hops); > struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode, > void *holder, const struct blk_holder_ops *hops); > void bdev_release(struct bdev_handle *handle); +1 to this. Also, if we are removing "handle" from the function, should the name of the structure it returns also change? Would something like bdev_ctx be better? (Apologies for the previous non-plaintext email) > > ?