From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF90AEB64DA for ; Wed, 12 Jul 2023 13:39:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05FB26B0072; Wed, 12 Jul 2023 09:39:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00FF16B0075; Wed, 12 Jul 2023 09:39:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF3316B0078; Wed, 12 Jul 2023 09:39:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CE8F16B0072 for ; Wed, 12 Jul 2023 09:39:26 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 95B60140123 for ; Wed, 12 Jul 2023 13:39:26 +0000 (UTC) X-FDA: 81003066732.30.059F7AA Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf27.hostedemail.com (Postfix) with ESMTP id 0101C40004 for ; Wed, 12 Jul 2023 13:39:22 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ionos.com header.s=google header.b="HvU/baPM"; spf=pass (imf27.hostedemail.com: domain of haris.iqbal@ionos.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=haris.iqbal@ionos.com; dmarc=pass (policy=quarantine) header.from=ionos.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689169163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+evqX27DGBiWJkyZnqGeEHQI9QcDiX7JHwbrqFd6EpQ=; b=fGxfxiBYJupQKvkZvA3nQU6Nbs3cp8No8caCH2LVoaBAY43Krb8h8ajuvQmEiVJOgA0Jw+ vwQN/XvSocTcUVLHKYcReiNt3It4slSGyo6gybQDK/EqcNdCnHnDOIS7rK+W6S/n0TzQ8I +PS9KLYsoDfu2vMXCuXWq4qAYNHfSe4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689169163; a=rsa-sha256; cv=none; b=UGjIEqVOI8z+hX/KKh9Tiayyq6bD1tLxvbK35RQs4gc5MNp+q6KsfcQzOhND9St35fnp4A rLizwUvbKtqQABEJIQuhgljqQonBt3NfbuRuYuOnV+7122y2qFDzfYVRpRoPm4xxk2ujF1 JvmcM64gddhrAu9L42vmNtbpPIsCblM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=ionos.com header.s=google header.b="HvU/baPM"; spf=pass (imf27.hostedemail.com: domain of haris.iqbal@ionos.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=haris.iqbal@ionos.com; dmarc=pass (policy=quarantine) header.from=ionos.com Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-4fafe87c6fbso11257467e87.3 for ; Wed, 12 Jul 2023 06:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; t=1689169161; x=1691761161; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+evqX27DGBiWJkyZnqGeEHQI9QcDiX7JHwbrqFd6EpQ=; b=HvU/baPM6sZwTLnq/qfa5rJyKcj7shqfM6D7Yb+G9g3ZYKTi3s0EcBiC7f7tIEjtdm QA5axW7VPwPnkXZzytIsv3row1wqxHmeDpHZnctYAtNdrbiFmseznOuEbaqL8+1ZuCdx mHq0tH1oyBhuyYi3VnGKgi7s+kfN3fJslBaL8GJuknQcFsq3zqBycULjxCNTh0AQw7xm 1wOmoQ5WDMp1n00gvCTlg6QVLQFj2LlfqH5fv/sX4+XD5tLQqI3TVk0j8HJlphtzaXvc STEw6QCxnVvzKbvtX6kVCmEnTLJyBGmZAtS0H4Rhh3ZkO7nx2ZhYYIcL3MQBWzCiQS8O xksA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689169161; x=1691761161; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+evqX27DGBiWJkyZnqGeEHQI9QcDiX7JHwbrqFd6EpQ=; b=cHhntxXEkjrYXppq0p/jdhsrMA7RV2goAugpcqfOiMy8HKUHk5vXZxbU7utMidz5bl zPVniPwg5sf0F8QnpbdbJsariN9SM07QKdvTUtIAjLS0YL1Hc46gIGsATvIt258n49gC keeCB4PM9iK3yelM8DHdJWiX4HQBwd9HcjcBLb/AarknvSsUKWpBNGMfNi6jBV9J7CoP BH0yVeMmUt1dFkV39RV1jsTkjm3Omv8EHv3Hy6nU5iFshyWqvtJHg7UFELqXe3ex6SeB p7Zp7Ln0QRHmg7e/sFthO61gD8y51lKoXu2G00hpB18mMY7ZuOZRomOwf12aRERia7su Z9Dw== X-Gm-Message-State: ABy/qLbnLcFilZs0EdU4HsM/Cj7a3cQ+ilL710gngg6E4CmJQW7ciGWD oGQ3hph0LIziM4Y4fK/f/Dt8sCEk3B+IAXAro4b6kg== X-Google-Smtp-Source: APBJJlEI1gyVFA9e0vzN1OZw8HqZ9LgUDYjdSVkcc/YNKBWyCbO3ruOl1C16YRvIxaIjAxVOOIhj+dxwF3VF9wwHpIo= X-Received: by 2002:a05:6512:34cd:b0:4fb:82ac:9d23 with SMTP id w13-20020a05651234cd00b004fb82ac9d23mr13814794lfr.36.1689169161029; Wed, 12 Jul 2023 06:39:21 -0700 (PDT) MIME-Version: 1.0 References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> In-Reply-To: From: Haris Iqbal Date: Wed, 12 Jul 2023 15:39:09 +0200 Message-ID: Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions To: Christoph Hellwig Cc: Jan Kara , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000cf1dc906004a5728" X-Stat-Signature: ywn11sz5h4sata185y3x98mbcsykx4z1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0101C40004 X-Rspam-User: X-HE-Tag: 1689169162-814907 X-HE-Meta: U2FsdGVkX1/7g4gKLBmxQpQqSti5pMOe33yUiyTzdUx15rYGREwODpWQz6KUrocxX5ShFyDyAmmuAgsRVa2Jk/9Mjtv3fXl7IzodRl50vPTct6f5YvAlAfB4tPNDJLF7Gy5Msl0mHmVrFjVo5C0tkpxFrUA9o3iVcVdClA4+bDJyChx647JGDgzphZacz3Ukdkv9x+06+kZf113RkheTNR94qqVWx1dI0Tjx2PWFQgDppqh2NOrKYPxY//MvaGKJ2zk3oLMd4x8J43ckM4uBM+7MXxpFHFNIlm276jdq26eK1NWMJyL8UUnCi/woJkgN7voSyYKeBP7PcjB4B4bbilwyF1qwzUY9QclyzR9mMhPcqZR0vB2pvfv4PkykkK8bLTXaumybxO8eXJkcsSBSauzz8Q83HjQxn6f8VD84RiOdypyGwMWC0JOAFFZewfL/YWHxh1v60FycXkqPNSDD8xdevWgX5O0FUSlsxZGkpLf7Inam3tQiNBYgYx7q+pGeTMnDm6wGYCj2FyzZNygEuBUr5Ii0+PBDFbsc8qQoItoUWt5x2U8aIMyGRZfWSOibLvpHplyOsdN5b72sjuhMLFRl2za7liE03cfxuNMdetpdhrChb7q10rtYjX7+oa+UfRr8KvIP67Ybwa1Dt64ZBgEBtjFIV62Hj9qixlC/EuOPqg5tM0C3Lj6yYCd5W5uCz4AFJflpMHNNU5y4I2mqpjVin0tKRd1iWj06dT7ra13Uo/coeE5Rq712YDeG+LRTWAbOCn6Zsh849H3KYaJim0zitVcyRVep23jlzr41rRXCQsEa3/ZrqISOtXnpUKcHD1NhbDCz3sAQOt2edItUl3yfjBeYtCJmYmnqyt8t4c8ROh37L9hGXpgc2ToUuU32cIAXv+rertMGnuflx3h/Wo7e9nUcUB7sa5Y3cPgydunjED6BMjmJi1zdOxLKBB0YIXBEEHWPr+G3nnUj5nk /lm6mBit dGEWgYtPsGgCSuiCRVvPI3OfJ1O+R3uEGjYqzCXyDGN2QmL6avVUBlcU9xZljMqKeKhh3qDNs5AnJRBwvkMD1vkIsfMhZqXNUv2jQ3friOltmCxo5hAqretQBIYRI7e15BnMkjmBvE4RthFOkREr30gATI7NBU8Aj05HKS3uCqpUlI/GxYK3vQSzTFn/HzGaEyzcBD8zJ0AfnkWfeUlod6teeY2lr+dUFASK60LHSjC7Ka/QPCYNZhoYIwpScyE78mIX822fHB5Qajee1S8UJ+UqZoM+uu7ICPblXzUNodJwSm02sNRJoqPievF2kMPCcsNcZz24e1wxBmxLX+bfgrbXT8gR11i9jUXOkuG942Fqfig9arvwpg6X0v+eP6lR65FA5wSw0D+b/sLukBZppuQOFCRVgBvGMFWuvrIcbt8OlM05X4C6d1jH/20G8j1mj31x0AYnPOWQoyVEDbB4TCIESLOWGcjpyPlveGAFcZqSeCuUK24DdRCKNTwURJY/LROvy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000cf1dc906004a5728 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 6, 2023 at 5:38=E2=80=AFPM Christoph Hellwig wrote: > On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > > Create struct bdev_handle that contains all parameters that need to be > > passed to blkdev_put() and provide blkdev_get_handle_* functions that > > return this structure instead of plain bdev pointer. This will > > eventually allow us to pass one more argument to blkdev_put() without > > too much hassle. > > Can we use the opportunity to come up with better names? blkdev_get_* > was always a rather horrible naming convention for something that > ends up calling into ->open. > > What about: > > struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void > *holder, > const struct blk_holder_ops *hops); > struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode, > void *holder, const struct blk_holder_ops *hops); > void bdev_release(struct bdev_handle *handle); > +1 to this. Also, if we are removing "handle" from the function, should the name of the structure it returns also change? Would something like bdev_ctx be better? > > ? > --000000000000cf1dc906004a5728 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Jul 6, 2023 at 5:38=E2=80=AFP= M Christoph Hellwig <hch@infradead.= org> wrote:
On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote:
> Create struct bdev_handle that contains all parameters that need to be=
> passed to blkdev_put() and provide blkdev_get_handle_* functions that<= br> > return this structure instead of plain bdev pointer. This will
> eventually allow us to pass one more argument to blkdev_put() without<= br> > too much hassle.

Can we use the opportunity to come up with better names?=C2=A0 blkdev_get_*=
was always a rather horrible naming convention for something that
ends up calling into ->open.

What about:

struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *hold= er,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 const struct blk_ho= lder_ops *hops);
struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 void *holder, const= struct blk_holder_ops *hops);
void bdev_release(struct bdev_handle *handle);

+1 to this.
Also, if we are removing "handle" f= rom the function, should the name of the structure it returns also change? = Would something like bdev_ctx be better?
=C2=A0

?
--000000000000cf1dc906004a5728--