From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD5DD6B6DA for ; Wed, 30 Oct 2024 22:51:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C96616B0099; Wed, 30 Oct 2024 18:51:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C479B6B009A; Wed, 30 Oct 2024 18:51:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0E566B009B; Wed, 30 Oct 2024 18:51:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8C4F16B0099 for ; Wed, 30 Oct 2024 18:51:22 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3ED56810AE for ; Wed, 30 Oct 2024 22:51:22 +0000 (UTC) X-FDA: 82731766152.14.88730F6 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf27.hostedemail.com (Postfix) with ESMTP id BEACA4000C for ; Wed, 30 Oct 2024 22:50:53 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z1SxKxr+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of joannelkoong@gmail.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=joannelkoong@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730328519; a=rsa-sha256; cv=none; b=O33kTgKvMAb+oPX6w3BdduLQ/oosOXIkKjP1P5SUP6h4IRmijTtDfxKLvdMqnoAJc/XxLQ Ni7M0vvKyJ80mPxVxyxeI1LxVvI3ykhKQOBjJoCMhvfqzU0Y4wsKm1CuKg/zrR6eoK5D9C ppeYWuJ3HXV8Ze/bJwEO+x3HfLiqp4U= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z1SxKxr+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of joannelkoong@gmail.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=joannelkoong@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730328519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a9+mkQS/Xq2VnALxHggjQcZlPNoXcl/QA/fNr8RdeY4=; b=MT8yTWH/rs5xTpyCZQ05aI/KHe2XxLbUy7b/huZ2pnkJLMRa6+XawYV4jZ83qWHSt7iyFR 6P+9DSpOiu5sd6AaBGt2NQtzE3NBGThnhMWWccyOSGTXN6gCw6O5GPr7HOp1TAAOsmuy0z 08Sjr2nHD9yPJdJ7cF5egnmlMdISWeQ= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-460c1ba306bso2554921cf.2 for ; Wed, 30 Oct 2024 15:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730328679; x=1730933479; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=a9+mkQS/Xq2VnALxHggjQcZlPNoXcl/QA/fNr8RdeY4=; b=Z1SxKxr+12x8oaxEjpy5AZwMK2C3vuCMZFt5BMgbEPR2kflVgOSc6FrWRdj4m+nA6g k0zs5R3EMXzIGGRX9t0yFLle4R9buYlqKMWDDSiJ6JGXDSQDIZOfGEf5oQCxtt5w/KmA EyeaoKFgCaxyca/enJFHHukma/YmtOXawhNpeXhNy5ZLRyL0043YKaY+ZxvB6mvr16gJ PpzigToJk/7eN4J6b8umd2iBNacxwZ85aZThmsZa6oqhj0d03mbzEtc0MlO245Wqv0Bo KkAJ2JJZtsdwHOjTjMtkVrOA175LQkQBOwuoGH7ck6JrPmXF8NGJqmtS4C4dqA1Plws3 qoEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730328679; x=1730933479; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a9+mkQS/Xq2VnALxHggjQcZlPNoXcl/QA/fNr8RdeY4=; b=M8EpfwKSFb5DDQJgKcN1VyDhg78PhO6xrzj/4w0XtZQZThFB1RBG2DUED98WDNO7qe EWTn4D5lt+CDkyKuAtbOVfysyG23xByLmVsAbgYEP7J1DonOGMNjC4Df2fwXU2MmYIUR MwHuTYgrO3b/IUsuc85PZj/C5TsQdplW0FexSON+qsf/RH34cYAAjm5+xNDK76OzjZqf Lc6BscWFtdAIs12jlbuvQtnB/6qYRpW+WFMD5Jx/tpG9L1t+OHrPahzpmfWuvVDpMIRE MNIOXs4bIMnIHDyFT1wWgE/0ymPJeHr/Z9DVK2sNcrZGCi3xzCwohdvW+ZWUt59+YHLW EFMw== X-Forwarded-Encrypted: i=1; AJvYcCVVgOCTW9zqUMcxWpx4lQabz4xMeoiKRrwlnrFxevPBaf6W5i8FWFKf6r4KzOpp0opeoVDVPeCAYg==@kvack.org X-Gm-Message-State: AOJu0YxNLn+hoxgIH8nCaIa2rKb6tsH29eKXpBTAiO6oJmRTavCdwpQ5 VqlVnHAp6ST7U7Z7/zP4cOKhcR7Hqlxd0t/dDOBD2BmkpUU/2Nu2PQ/pa+dp8yMO2IHyNfOyu90 MrFiqlbOQjl1H7pCVFGHLfPV84wU= X-Google-Smtp-Source: AGHT+IGoNHmBEo6OiZmC9ikMO2u2OFawnsHhSspSXpWPT1EwaoDW/0LgfL3fQcSklPOjI+oSKjceQpkCFVOkA2Z9OkQ= X-Received: by 2002:a05:622a:486:b0:45e:ff67:e058 with SMTP id d75a77b69052e-4613c19dd98mr273279091cf.44.1730328679584; Wed, 30 Oct 2024 15:51:19 -0700 (PDT) MIME-Version: 1.0 References: <3e4ff496-f2ed-42ef-9f1a-405f32aa1c8c@linux.alibaba.com> <0c3e6a4c-b04e-4af7-ae85-a69180d25744@fastmail.fm> <023c4bab-0eb6-45c5-9a42-d8fda0abec02@fastmail.fm> In-Reply-To: From: Joanne Koong Date: Wed, 30 Oct 2024 15:51:08 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] fuse: remove tmp folio for writebacks and internal rb tree To: Bernd Schubert Cc: Shakeel Butt , Jingbo Xu , Miklos Szeredi , linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, hannes@cmpxchg.org, linux-mm@kvack.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: p9ncecco49re53xmoyme9jyifqbthzhz X-Rspamd-Queue-Id: BEACA4000C X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1730328653-558597 X-HE-Meta: U2FsdGVkX19Q5Ptot88NKcyBVppgkjEY4pQe4EX17XdUMlf6H+mFyWjDzkCTZDTyG1QTsYnR+NerMJJT7f4zaZJSW4+K543XCUDkjsRZyuQB/FdnTr1qB0S+W71X3V7VvQPDpP8fVs5gqmnNEquCKsCDWM9iLQxa0SujsuEMQXQ2FZM1gUf4P+Dln9Rx06jhhxlJAKJ1zt7bJ15Ocz+gsNc69nzGA6VvTPl/iI8cVcBrHnX/hrDpGxjcAHAv/NRv/GqknIaW8WNkgLcDXPFiF88PVHDAYmZRCGa2gtOl+GS/ln/6jvG0gV1PP7QuzMSyCQ3ul/cVvcrLyM17Ncxv8NaHR8jB7/oLx1F2fOUOoc19EaGhnnprhn+YFQySWhP7KwJ3uCqOBy4QOw+sQgYWkQvpisbd+U+Nrc5TO85QFjhuJiFSyleEhmIN7ietYCyIrX4Rqs7GV4XOJl7++5vRBeEIbppP/hpSbpqQDcHcm/0e3juL8fEuCUMbF0OkGnZy3ux4bcYBuvoobEfgmwOau/2fds2jWiPPzr/kkXnlHyIo1FE0zyo7f6jnIIguObytW+8giaD6GidogWF28xGWcffe0jK0PKdTXF4RBM1Qi+dH/XLgh0KrqWECwheh8xVBWuE7uJHVcGdXFo2yO5JXLaXaMjYNHdl/MCyGMbHc6akm3uIw1+JdJUq1CzpUw2DId93P9cL3E+PejcBM5sr2lbV6YJcmvT9y5LOZdAPubZkoypZCghm1E+Vy0Ar3mZd4P+M14z9AOW82Womfmh/sfqKZUgKPxv5mGeCjv0HtXZDF8p70Rb9PEA+njd1luJrOtoThk40oDG7TiXrAncDZYMvCze0s+VJPqsXucPX2mi2Avc+isY3YGI8iNU3oDhv4oRqgSuwxrfh9+Kz02RuhK96atGdkFQruIxf7F0RUxSHvRZzEDUDXz6Wwgs4NDfyF7wDZ26gLPU3iNz1u22z welPyeIF I6KLkAjqPeKkSwy7y3DqI+hbFauJMuM5ul3dmH3/OcWThauVdcosuERSZp+/x6o8q7oxNFd2SKZKRWRJjvm6EI4eIqbMvXQ6YtixYnSXsCslububEfxvAjbANKsht1yde3i4yAvcWPeNrxIr19ZVMnMZloHHSjQaZVl3q8VTwbxSjJbknvryElsVEapk9PSXecVQ1VpMdX8kG7pT1C9nmtZx9T8G/aK+Ycfz2rL4vVOr0uuAXIa3gMN3RGmMZnPh9AWMjoOF9iX79jbJHJkUjNWMUJx02frRtkorwbrSmK1n1Ir9sxAfIXNK7TFAzWmbJpQw6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.316910, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 30, 2024 at 3:17=E2=80=AFPM Bernd Schubert wrote: > > > > On 10/30/24 22:56, Shakeel Butt wrote: > > On Wed, Oct 30, 2024 at 10:35:47AM GMT, Joanne Koong wrote: > >> On Wed, Oct 30, 2024 at 10:27=E2=80=AFAM Bernd Schubert > >> wrote: > >>> > >>> > >>> Hmm, if tmp pages can be compacted, isn't that a problem for splice? > >>> I.e. I don't understand what the difference between tmp page and > >>> write-back page for migration. > >>> > >> > >> That's a great question! I have no idea how compaction works for pages > >> being used in splice. Shakeel, do you know the answer to this? > >> > > > > Sorry for the late response. I still have to go through other unanswere= d > > questions but let me answer this one quickly. From the way the tmp page= s > > are allocated, it does not seem like they are movable and thus are not > > target for migration/compaction. > > > > The page with the writeback bit set is actually just a user memory page > > cache which is moveable but due to, at the moment, under writeback it > > temporarily becomes unmovable to not cause corruption. > > Thanks a lot for your quick reply Shakeel! (Actually very fast!). > > With that, it confirms what I wrote earlier - removing tmp and ignoring > fuse writeback pages in migration should not make any difference > regarding overall system performance. Unless I miss something, > more on the contrary as additional memory pressure expensive page > copying is being removed. > Thanks for the information Shakeel, and thanks Bernd for bringing up this point of discussion. Before I celebrate too prematurely, a few additional questions: Are tmp pages (eg from folio_alloc(GFP_NOFS | __GFP_HIGHMEM, 0)) and page cache pages allocated from the same memory pool? Or are tmp pages allocated from a special memory pool that isn't meant to be compacted/optimized? If they are allocated from the same memory pool, then it seems like there's no difference between tmp pages blocking a memory range from being compacted vs. a page cache page blocking a memory range from being compacted (by not clearing writeback). But if they are not allocated from the same pool, then it seems like the page cache page blocking migration could adversely affect general system performance in a way that the tmp page doesn't? Thanks, Joanne > > Thanks, > Bernd