From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE0F5D1713B for ; Mon, 21 Oct 2024 21:05:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 324FF6B0099; Mon, 21 Oct 2024 17:05:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D4376B009A; Mon, 21 Oct 2024 17:05:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 175616B009B; Mon, 21 Oct 2024 17:05:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EF00F6B0099 for ; Mon, 21 Oct 2024 17:05:28 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E104780A6A for ; Mon, 21 Oct 2024 21:05:14 +0000 (UTC) X-FDA: 82698839790.25.642B3E7 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 0FBF21C0019 for ; Mon, 21 Oct 2024 21:05:07 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SqrwRSzf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of joannelkoong@gmail.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=joannelkoong@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729544689; a=rsa-sha256; cv=none; b=V9XIyRRCv4SByjH6mmRhrMYd0Nt4pA8gutU30elTnC1qtZCZ0xCUSjxVhidFKGeIg9lD4D ED33D5DeUCEuvsIM6rVH2bamm18/Jl+Czo5vifHiHYKKFy7VNBV/L2yXb4g6n3u1VTpeGS 4VbTveDBnQISpJ3v8bDY4+CnwNDqkkI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SqrwRSzf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of joannelkoong@gmail.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=joannelkoong@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729544689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z3ZA0BEr3sDTt6qlbLanXjDgNX5vwNVdkrw+XZQzJvg=; b=b1y5fWTfYxAU2q9AFenCFCfQ65e0YaxQLYXq19w1zBLSy94lRciT7/ZkUHs0SnBCs/zvKu /T1ZjLOhOSoQBn0SIO+2Dlhtuzx0T8QpC2ZEWGFgyqGHph0EgYki7Rh3+Pid0RuZbXO0Im PAPDd82Kwt7BCP8wfm6VRugyF9J5pLI= Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7b12a02596aso321321085a.2 for ; Mon, 21 Oct 2024 14:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729544725; x=1730149525; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z3ZA0BEr3sDTt6qlbLanXjDgNX5vwNVdkrw+XZQzJvg=; b=SqrwRSzfT9LcUxJbvNwxhSwVhsQACxx1Mp1QM4/gUuzaNaaOI+cdwkRgEjx/f5fqWB w7nGtOTD2T9UgVa+FaL3dQHFM2rKFFHy0kiqwz3Fssn/utcAAh95Bv43t2MSzkrPtUb3 zjP2AH6XUzTPNKyrIqxMzKZP+HMvxkSWu2URXcnxfmRUnoMFLqQn3uXXJs1zToAGq/Um f6wJRR7jvoWxRRoYnwmpidZen3DNSUEPa1PdnlIoYdjR1aUlZw5WkVjSagGk3M0g+TeB khIpUqOMawF5Z4WFoJ23/RgppzRv/ZWxWKX4xTPpbCeUN7yVUPRnFtZSngucicR4I1v/ iTvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729544725; x=1730149525; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z3ZA0BEr3sDTt6qlbLanXjDgNX5vwNVdkrw+XZQzJvg=; b=h5Im+/C3XHbjZLlI6uG02VtHF4neNuAi+382x5QJjfOAT0xIqFYPXJA5OJevesSZK4 Ce69Vo5Aj4HE+cpihsCjM+3jqq+wM03Kff1pVRR2G1jj139mkFA0FBKQTtJq6Q71KtMi vcQZBJnEnF8sVKjfOXh5Zm9PX7TL61MyzW0rQXA1dWC4RHQRSnnmLshXmvV+ehzlR7Ch HG9yW9ppb7uOOjWr0IWkq9qur1DWJc3SDiSq/OxtRX4IEOXBZGauvTjfqGK43iH3jwou z4YgH+xUXzzzxLXJKf/ru/6B3A4Wf6LyMRVN65kZ6M0Tcug5NiouOyCBEcAzDdQvIHyI b0mw== X-Forwarded-Encrypted: i=1; AJvYcCW7xJpwkSxi6PYE/uhqmmBpTk2FWvuOP9lHq1lWRGAHqYa8LWEBTq5R6x8dPVU40ofTnFC5hmsgvA==@kvack.org X-Gm-Message-State: AOJu0YwdxuFUxuT0aTqFRZOXt5mXqxFxC/x3w3VKNoZyjxxPy2Vp/+WY Me3JdbqlvxzVOd3lAAUXvtToku/DdhsRlsHVTzOPUcK4PfHSQS0fcM4zeWaOo5/hwP4/CAHDxnq HOVG5+j2u0kBGBsXGr8o22yPVq+4= X-Google-Smtp-Source: AGHT+IF4p9VCXNv3I35LReHx2HHPEOEoN+agJOqpiUVM3c3GMrqt1MqCrq9nelReSiuB50Im83TXrxKkTicpqrN2K1g= X-Received: by 2002:a05:622a:653:b0:45c:aa3c:6b21 with SMTP id d75a77b69052e-460aed54022mr216629251cf.19.1729544725516; Mon, 21 Oct 2024 14:05:25 -0700 (PDT) MIME-Version: 1.0 References: <20241014182228.1941246-1-joannelkoong@gmail.com> <20241014182228.1941246-3-joannelkoong@gmail.com> In-Reply-To: From: Joanne Koong Date: Mon, 21 Oct 2024 14:05:14 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] fuse: remove tmp folio for writebacks and internal rb tree To: Miklos Szeredi Cc: Shakeel Butt , linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, bernd.schubert@fastmail.fm, jefflexu@linux.alibaba.com, hannes@cmpxchg.org, linux-mm@kvack.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 7ymbgqesaroigb8jnf6a4654ugbxtx65 X-Rspamd-Queue-Id: 0FBF21C0019 X-Rspamd-Server: rspam02 X-HE-Tag: 1729544707-192108 X-HE-Meta: U2FsdGVkX19k40ngkSxG53P+YGPXn+DxeKq5uLDamAHxWNnL3bqS8lrUK9FByu5hIYxtdmAURg14DewMQwicy8z9zC4EVBIxbgxd4muAazItkp9AjTo3lY29Vd5G+jeHGjTLAdHpOR3/WNXMQ7p13HP9CCvnVCtxW1cUMKS4CKxVr9ASXKvACtXIzGfXBhZJKsfWnVq0UJcqjoIdFTcWd+YFqXQ3LUVFVv3sA9Gr00MNJRCas0wukbsIQdMiiW0NBfd8juDzxyOi/+qzJSSnc2wqt2M2ThPfLhN94kOVyoKshiX8T5voDwHFRU5mML/k54I/tgDXcTbF/1WCuYnr7tbbhb1wbU1DGcYS+SPYjfdp213PNVmVIKW6OLQVEtvBWgE1cDSEJA3Oei3xfZGrEBSura+aUiHRwAJBjPU1jBaglC2uiDvTuvIv7kJNtCXA8SnM+HwC9V0DBEvnAVVfH2ttQeFXhZ8taOdqldBb2KcofX4S3XZ/04TWZKpHljgR+FM6IArx4erWKkTs6s3Vg3mTij2sTideT2nyD/Q6zLmk6AfJ6vOqnQCw4P70Mv0mO5d540hbwlOmQ4mxO+ydpgBS4cCVV7dSTyuFZsT6emzUC90sBJ6lFOjZ94aXScOH+UY/j13DAx9U0HFqU68YZBdpPLvLZ6h6LD7XSsq8yOe8LJ5OMr9YdudMYFScuWqizz0g3KKj3aYecw1tEgbPkZoju8IVM6zZlZQnM/hh/NWl4KjZnqRuElUM7JPXhjLNriYGL+tpTMXpGYOnMsOSXvhctk17DtkANLpxdrSh+TzXkWkfwtcfR16a8NUR5Y8G1u/YBsBZUQNCaiXnmDZf/JBK1whU9uudfMNVf0LMJ6tpbvyOif468FH1fBhtBL6qpNYtKoAKmR7eEJUf3uZSEBFg4wOXcLwWse/0i6CGohstIBkqxG/0ZeNz8wh/ud0Fkx7mys7JR5Z6BwPthMS LD4PwhAQ 49ZJenXBitNy/TbZwdNc3704a1IACaKINR0/YR4po5pr9wpiuxkD3yKCLyUpVhDvstLCZbWWoJGnd2fJ9xwd3hNI+RkOTjbtR0mWrdeCEQK0nNa0GzW7aQMkB55kbP0Mjlv4/8dSTnONPvPfk3ojijJc8HFYYFzrVA/7iZbqei4iHocFH9cgFgnzFss8pYqiNZMH5H5HLm8HKBr/PXxmVWU+1zna0kl28yGyOwe56LREvF2Z5sxhFt4XMar/LtG5S/Xdw7C6VCWan+y7aFeF467cbAKNeJE/0WSNoHaThgcYk9L88xTOX65EFcTGjNkosUpsdxGUBNl2Dpkp/80Mzeomxb/yFUmL5S2YyEB6x8vjf5MBmv4jIkSR3DR0ldF/77c34oaiDnPydD2GCOkjpbFPQXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.030878, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 3:15=E2=80=AFAM Miklos Szeredi = wrote: > > On Fri, 18 Oct 2024 at 07:31, Shakeel Butt wrote= : > > > I feel like this is too much restrictive and I am still not sure why > > blocking on fuse folios served by non-privileges fuse server is worse > > than blocking on folios served from the network. > > Might be. But historically fuse had this behavior and I'd be very > reluctant to change that unconditionally. > > With a systemwide maximal timeout for fuse requests it might make > sense to allow sync(2), etc. to wait for fuse writeback. > > Without a timeout allowing fuse servers to block sync(2) indefinitely > seems rather risky. Could we skip waiting on writeback in sync(2) if it's a fuse folio? That seems in line with the sync(2) documentation Jingbo referenced earlier where it states "The writing, although scheduled, is not necessarily complete upon return from sync()." https://pubs.opengroup.org/onlinepubs/9699919799/functions/sync.html Thanks, Joanne > > Thanks, > Miklos