From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E24D1D88D for ; Tue, 15 Oct 2024 17:07:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 949956B0082; Tue, 15 Oct 2024 13:07:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F9CB6B0083; Tue, 15 Oct 2024 13:07:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C1966B0085; Tue, 15 Oct 2024 13:07:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5D2C96B0082 for ; Tue, 15 Oct 2024 13:07:06 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8088041651 for ; Tue, 15 Oct 2024 17:07:00 +0000 (UTC) X-FDA: 82676466516.07.A333B28 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf03.hostedemail.com (Postfix) with ESMTP id 813D020016 for ; Tue, 15 Oct 2024 17:07:00 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ltg+EyaR; spf=pass (imf03.hostedemail.com: domain of joannelkoong@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=joannelkoong@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729011950; a=rsa-sha256; cv=none; b=wx3cLspO/pDi6zCBAzWhuVyVv2f8/itG7nDxAMg/xo0vu+nxRb4STM3kgW3PUh2R4a5x9c caERIbuASny4Z9pn/09KlyTXRSJrxLEYCv95dNjtKlLmgu6Sy5Xx50+22ZG6jv+8B/KmzK IL/2/cQ1E1mdTkjpYR87VuQJZVCO1jg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ltg+EyaR; spf=pass (imf03.hostedemail.com: domain of joannelkoong@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=joannelkoong@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729011950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=crN2X5Z4zCtDQ4lFStD53ycDxLHyj4Rc7LATVvktE9U=; b=Y7PSmZCcqtJ44JtqMUbt9EepRNrqfKdyacM2B+/q+WKe371diB7EKHHkWXECZ04PuOqe/4 Dd03RAIogLfRw1CKz31xLOZv/NcYNpjmUeLyJhcsC3UdtNMVY7/4gfPcPaV6wPPu7wYauE 4N0jUGUuh0Z+2j5irWDaybjFY696u+0= Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7b11a28242eso327339885a.3 for ; Tue, 15 Oct 2024 10:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729012023; x=1729616823; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=crN2X5Z4zCtDQ4lFStD53ycDxLHyj4Rc7LATVvktE9U=; b=Ltg+EyaRMrXwmxAfDVTlXTDh6HDpuApLIQZgOAYcEtRyE9HfqRqmHu5FNNIt4lwyZ6 eF/zW+jcSLBKAOwl+/4P1waxCL66je4K5Yh9W/YgDoT5DWdMBb7nRRuqcUD0OPDqIeoK 6o6YpoaPgtrcUOW/ncz+4++l1tI7YArCNSqnEgFnuB/0/QJPvSNX9Qzoz0UFwBzlLIb6 vye1/hb57FGsk5su2IyJdW22rgQaJolle+ldMQ2itzv3ChUmGfm6OZuJonOaIbQwSv2U DxKC1LoMishpwMkg5RZkpYlZRS+5XzAwOBEMZy166QCdL7aHRjKjBxCtupAqeXieUftA P5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729012023; x=1729616823; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=crN2X5Z4zCtDQ4lFStD53ycDxLHyj4Rc7LATVvktE9U=; b=gDJbR9OsPGOUqMUCriCvXpWICYik7O7zBBBm2Eats662qRxtUGYpTpPjzUk+pmxWUZ ydY64q5o5wAT3dDLUBMnjwYpM4sS7A99cqBtQNaBMGW636RXxFCVHe0JQzANtg3McFQl 9o9lZRgPCybBVqXDruKWov/QW2BLU5rR2lfmVu5qzQHM3NItQ0qt/WocjcsAqYzD5ktu vFAXDvQUQQQC24hkfGJEBWAMZsVqWFHdD6H1bkv3zeb9Jolqi35qvLaws9Q4KLGszvod yuYOGvk0diqPXpiENE/3RuiVUA8wwCeK5aDTXlk5UiJnSYD1Nb5EhBc/OiMDcG5PhUca PtZA== X-Forwarded-Encrypted: i=1; AJvYcCWFYC787gYyEyQlXNBGjTgH626pPlsqPELlPEjt7WJLui0GBEpqiaSAiz2+DOH1/0SGCrcOpK6CUw==@kvack.org X-Gm-Message-State: AOJu0YwvPX7+ITMXzf1IAaHcmYfJ9udSS8vmoy1e4Pw9+soVEO/6yTXJ /AUOOrzcuOH3j5fgR8eGwm75vJkedtGAJjT8FR3pOEzx+Ja1VXr+A9gFaPPTZVfRmy9st98hwOf UXDuj2EfA5oAQDugkMMSPK28JgzU= X-Google-Smtp-Source: AGHT+IFkjWwqIzVz68R/NgtcOkitAJyQgcD8gWHaUaChRBh1qnzdsg55sHYZzFMka1Vb+cc9OgBIxCqmy+Z8Bq7+Lc8= X-Received: by 2002:a05:620a:1b92:b0:7b1:3f88:48ef with SMTP id af79cd13be357-7b13f884c4amr172178985a.46.1729012023113; Tue, 15 Oct 2024 10:07:03 -0700 (PDT) MIME-Version: 1.0 References: <20241014182228.1941246-1-joannelkoong@gmail.com> <20241014182228.1941246-3-joannelkoong@gmail.com> In-Reply-To: From: Joanne Koong Date: Tue, 15 Oct 2024 10:06:52 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] fuse: remove tmp folio for writebacks and internal rb tree To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, bernd.schubert@fastmail.fm, jefflexu@linux.alibaba.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, linux-mm@kvack.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: sgdndckm7b3a6mnaktozz43khtw8rm6t X-Rspamd-Queue-Id: 813D020016 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729012020-735774 X-HE-Meta: U2FsdGVkX19sQ/Rovkx/vhady4baMY0K7z1QVvv3DdEahLvschqDtFm/ZiCCEHsQ4H5GXfPBgdbhNj/gSs6Jt3yAvw9sK2lHIxH+IXXAPRZrLDcs7+I2ZAV2Fy3ndEgzSevJ9xsyfchxXJ8HzBfd/9iCb2c5ggKxn1g8Sbh23ZP4vFNGLFXwUHhKXCYUi4sRjvAERzDeJiLgfckXRlib0/H47MvCqgxK4En5MJvJOM0zB+EUxQiOtW4GanEuGSp9DRu48c9OPyO49mS0jKDAOfELqsLvgurQgbTtEe+s7nl0kx7+KLxYLNY6mkmB0qJycrpFx9yxEk1ecVNpTGAb0cU+Wd8fQXhx8XO/2q1c7gBzQK5M5EDZLEmkjuXx+rpD+Gpf8erYfuFxlA3EhdselT9o258RlC9WQFSvTxe9+iSZS2er4K5SEV9AP8xOWEdTm6wwKKE5y9LB90V4KFLxkTTxFbgCYzaiZ+XhFz792LmchWyH8YffIue0dcgDoC6ycak4QvWTj6IAwhEMkeR+Ckf+JpwOskhMLjofu9NeTBEhcWz9Dij/ns60xWweUJxXM9BcC0vgHY/Le4uXSwGPV55zGV00CS/7/K+p0/Tu783no8qC2DxDRo4rAiHCE7VXOe7kLhzmKESEjrto7PL4+LmCY5AFEM95rV7L3+6xv+uOF7rT7ofjgXyXR46+TMWbIuwTXdR1a8iy6fQ40OEjzc/SERw7668bvnhWN9r+TkbxzAIcZN60GDkpMX6/v3L0eRqWh7T9PX7PDfqXauzphxL6KU/cO27PYTdJjZPnwxYBvBunBfkeehIzM0LBva8GvUMhIqpxwdbPdrOK7Tm1N1j/WDgPB31XcW+3BPzhC2LPPbxc1Ib7LQRokiSocszXe2btr4R07IvuLseW4uFqlhf1BQT32vZF6bqKyYaYeGFQzcVsBhvSTDVA/d649OgA+4i+vlZpivEQ8HPs4S/ WwIfRgZV xt9p8GBqjM+Nb3rZ9esUE7lzTuJV5NaOsCITFlyxMBLDww4ZgU/sJ8EvqM7c1/RIGAVpHLCBbO21rgHN24YrBL7/sak91wLKlD/uYFZ3bmANWcJajXhdUR6qY04KmlCiUGSxjVNdQOdOEYr1MUHlIRJyO+MI4rXk6gr0G9MtV3/GwBOHlCcugg3DIQ2jMpo8L/SeFq2gCJmZ0x7gcMGdwg9izhYubrBtApV/zIE6S0eU5mUCY+wCPOe0SwYtTt9JO8GgG45SvvjVBVrGBlDOQ348FTf9wr8yEw4TCqwr0wvuU/jga06+mkWCVd7mMlBROYD0BkKOALP07lbety62XAKI+mA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.248827, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 15, 2024 at 3:01=E2=80=AFAM Miklos Szeredi = wrote: > > On Mon, 14 Oct 2024 at 20:23, Joanne Koong wrote= : > > > This change sets AS_NO_WRITEBACK_RECLAIM on the inode mapping so that > > FUSE folios are not reclaimed and waited on while in writeback, and > > removes the temporary folio + extra copying and the internal rb tree. > > What about sync(2)? And page migration? > > Hopefully there are no other cases, but I think a careful review of > places where generic code waits for writeback is needed before we can > say for sure. Sounds good, that's a great point. I'll audit the other places in the mm code where we might call folio_wait_writeback() and report back what I find. Thanks, Joanne > > Thanks, > Miklos