From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A9DED5D685 for ; Thu, 7 Nov 2024 19:22:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE2366B009E; Thu, 7 Nov 2024 14:22:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E911F6B00A0; Thu, 7 Nov 2024 14:22:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7F056B00A1; Thu, 7 Nov 2024 14:22:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B66716B009E for ; Thu, 7 Nov 2024 14:22:20 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7410240AE9 for ; Thu, 7 Nov 2024 19:22:20 +0000 (UTC) X-FDA: 82760269662.02.AECF1E0 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf13.hostedemail.com (Postfix) with ESMTP id A02332001E for ; Thu, 7 Nov 2024 19:21:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JSSgv7RG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of joannelkoong@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=joannelkoong@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731007168; a=rsa-sha256; cv=none; b=hzfFate1hCO/2A2zzWdDyPW7U1y4EtvovaW1VZbBlbhKNMz2/bz1Mo+OcgcdD6JEEAaIZ8 HS5rd+damOtlzdZMWWNuo9V9N8YZZfgegcwlsp0r/03jZk6JI+0x2/S29j6a5ApkXHqaX8 bAoTdlDzR630ozYvy0ucempllVAHzac= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JSSgv7RG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of joannelkoong@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=joannelkoong@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731007168; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iJ038givlOHAxZsUZqaQFQHlOuEAMqS/zK8h1yi+Z+w=; b=IeDrcCeVnGcMm665nm077b2hdQu0THwO9b0tAIOtpyw4cwJf/19WtpE320ah9SS6r/1lck z7hpcXfoYA7ak4D9eLjxl+2vHIVEPc5SscHfW+IYhfDP/+Aj64Qz6yr9bRpSBOVjpioE+E yZJZWNLE4O6x1dZqGxrU3CkM+9WUCto= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-460af1a1154so8581891cf.0 for ; Thu, 07 Nov 2024 11:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731007338; x=1731612138; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iJ038givlOHAxZsUZqaQFQHlOuEAMqS/zK8h1yi+Z+w=; b=JSSgv7RGtMMJO3EitbpCRF0dSgQvcl5N75Mi/2fuCigAaEsuy/Wq6h5bMZYZ1K3QgK AnN3ToTJupNRkHljADpdS3ej7OojnDsBG4qXgcK/pvtgSvCFnU7pxQMfkx4kb72tDP+h Nr8JkAzMLHCXBVeX+85vcLd1SCqzA34pzoqZ8w0c1BGn7A4iSEYpvI8IMl3gpM0Oo/Lb FH5nmP5JSzxcbbzlGOqh1D8n5I3MalFN+4xvgYiUcBIWnXOs6tppjJrW9k6URJP2Zf9C TWBAHLH8OAJkdf/kcM9gt04p3/fIQnGKkaHacaWmzpWBONsX32plGbjV/d4LpD7UlQ0k m1ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731007338; x=1731612138; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iJ038givlOHAxZsUZqaQFQHlOuEAMqS/zK8h1yi+Z+w=; b=OzlQmEQyvdhrUZvfrxTDONyPKJv60PnxAEu7GFKT320Mjy17Rz3O4vc/dYPnGr7mL/ RmUAwHS0RFFIfzvwbwNYrVFvbpfSwFoz+VtI+d7ocan5FpXnSog1lgRg9t8io06JqrxV d8OzpFd9+/qJM+XG+luD3+ynH9BMEHCRACC/zOSTctHe7zEDyh3i2cfa2okEV71tL/re 8CC99rZ+tRD4Qic5ZymU6PRcgDOuhBqDr5357oV33fANRmZpd/kAslEaXYhNRW9Fa34w jhCp+/AV/yblSVVGKVL1OPmv0GT2NX6Za7Rhwle6HqsW2n+l3NAKrLKWD73OKw1XTgCI 0EHA== X-Forwarded-Encrypted: i=1; AJvYcCWTzX/YwMFM8BKxVYS4EUpAZMK/KhkzTmd57vhz4lp0qJbBWQl9FPdXc9+ntrA4+OUpPFzbKGZ7pQ==@kvack.org X-Gm-Message-State: AOJu0YwR8xnGMbLPyMVcBRSADKIsiUU3Nb74rzuUStGeY0Z2uNlx18aR oT7AjCgOx3zoLD5L7fqN/ZlNtrahgzFz7QL2yjUpdPYZi3yylZId8Egvvb4rDZHkt5UAw2tqgKH nBvyKkSSIhYCpMmRJ1AGC7fcHEtk= X-Google-Smtp-Source: AGHT+IGwTBrz9BP7du+C/LXJjkuaIAOK8rSW9dQ1QAVWYEz8nx8W+iEmOTMrUE1s+u1rZUGO2DefgYEpNRfkSGfdieY= X-Received: by 2002:a05:622a:558e:b0:456:45c6:2c30 with SMTP id d75a77b69052e-463094174fdmr2631861cf.53.1731007337755; Thu, 07 Nov 2024 11:22:17 -0800 (PST) MIME-Version: 1.0 References: <20241107191618.2011146-1-joannelkoong@gmail.com> <20241107191618.2011146-6-joannelkoong@gmail.com> In-Reply-To: <20241107191618.2011146-6-joannelkoong@gmail.com> From: Joanne Koong Date: Thu, 7 Nov 2024 11:22:06 -0800 Message-ID: Subject: Re: [PATCH v3 5/6] mm/migrate: fail MIGRATE_SYNC for folios under writeback with AS_WRITEBACK_MAY_BLOCK mappings To: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org Cc: shakeel.butt@linux.dev, jefflexu@linux.alibaba.com, josef@toxicpanda.com, linux-mm@kvack.org, bernd.schubert@fastmail.fm, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: d4feozkbj3ruscswwers6ehapiqjprid X-Rspamd-Queue-Id: A02332001E X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731007301-505609 X-HE-Meta: U2FsdGVkX1/EscMpvUPmmOAQpuUe/xixEavJuXwSyTD5qfR/wOJw+zpmB7mzjgJ3Yn+2MTELExGEKzpzX832uiKSN7thFzgFOQcBPjLDuxXRuc5n1lm/FzsrAzS87/Wr/GkKIKdPYsU0LOTnAWY0aSWQjLUDXsR+wf2huxVc3efanhTsnoEy1PmlXNj+sn4eUv/hgebJ5/oX9OEP5NTpWzZBu10EU0dxnx2sDTfLhwe6VK9Mq/zbe7nX+gxk2ym1Ld6OmRw7s5/W9ea/1qyxec+EBDsEf29Z/smEf6fVwp1lXdWsegS6bYvurPBi2zSCYq/CB7mpjw/NeuhZd3ahZvF2gQ0pAde+WV1vAwEXiB6QsZEGjzg133JGtptira0xs4mveh9veMnwSFjmMf9eOK1X1/GTJ9LqM3GEYIuQ/ikHvHJzamyDsA70Pjo+PbbuBileJGLU+hyUnvKEbPRw0tiiQbtqOSYn4sjwVWARJYzPjEQG2H4Av1xZHOzuSGcUrjes/WifdC4nWvJTX3ikOwoPGSeTJQwIYeaV/ez4ti9SJSKT0WNLZzn+5iqQyyDzE+TO/1yNhL5Hwa+32LzsjzMxAlzMN1vErwA5bYRNVYhmWlIkR0tN5iPd7C4h5kPA1u6H1/q84Z1x0l0gW8PY4qQK4Kn4X66Xo9t1zrco/1L6Dcu9LmGLyy0xbCuqGZMj1g8tKKiCgimKqKaaxMQ+zKVw/uv3kcjTRy8U45dT4mfjqJ6yP5YyocFfKRwLa2AGkebGuqKR2ttFkQtJ3gj45WZIGGX6iJTc0LV4ib/FXciA8QM+Dnuq4wbCjy0m/f3h62tIxzaUmm1/pkrzJ/m6eWDaWo4fPyALVDs+aj/o0OGjhScGqsSp/ScZ4auPG90tJS6UniYv3HVoEa9rCRIwmFWxvn/8wEBMyO6/U2+gEv+5812WftE19wuxMTttf/iwJ+/aDV2EqRVv65Y94wE JrlqjAUT +cxcMICxHgQZOwvrjCp5D3uN87nAtb42rvXKGyGG5Olcvd0pCgY/mK8iNaW7x6YfMvsz7B4CLXmjgLbC74LnJ91DhdOWNw2sxvtR3AWOP2sqHs+RBZz9RbjY/BeKuRq2MFPSCrcNPX/gZbb3aSnBve+/KRtC9+1BBH7WQSjt6NBv/ZzKxvvFDIn4m4dGbJUArIY3tcTnZSpVcGAcVBN26Vw2nHDVYisJy8FWmILuz5mWqo7SCCNKaWwb8ntoUnWrF8RTJ6I8kYkR0QUocybwqM9XMw8pn9DCgi8JJxb+pnqydRK4ymJ++Czx70uoTl0bnxNlwi1NUq3uCieb2C7ueKlrYL+7p3fmzeZ6B0CqiKt4XK9yRV0xl0wrK9tmfVr73d8+uAwyyvBA6UVpIDO+kNI6bLMozXxpGpQ+W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 7, 2024 at 11:17=E2=80=AFAM Joanne Koong wrote: > > For folios with mappings that have the AS_WRITEBACK_MAY_BLOCK flag set > on it, fail MIGRATE_SYNC mode migration with -EBUSY if the folio is > currently under writeback. If the AS_WRITEBACK_MAY_BLOCK flag is set on > the mapping, the writeback may take an indeterminate amount of time to > complete, so we cannot wait on writeback. Please ignore this patch (i meant to delete it from my local repo but forgot before submitting) - it is superseded by https://lore.kernel.org/linux-fsdevel/20241107191618.2011146-7-joannelkoong= @gmail.com/T/#u, which is the same change but has a more correct commit message. The migration is skipped (see migrate_pages_batch() logic), not failed. Thanks, Joanne > > Signed-off-by: Joanne Koong > --- > mm/migrate.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index df91248755e4..1d038a4202ae 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1260,7 +1260,10 @@ static int migrate_folio_unmap(new_folio_t get_new= _folio, > */ > switch (mode) { > case MIGRATE_SYNC: > - break; > + if (!src->mapping || > + !mapping_writeback_may_block(src->mapping)) > + break; > + fallthrough; > default: > rc =3D -EBUSY; > goto out; > -- > 2.43.5 >