From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40707C19F2D for ; Fri, 5 Aug 2022 02:30:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 733E38E0002; Thu, 4 Aug 2022 22:30:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E31D8E0001; Thu, 4 Aug 2022 22:30:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AB9F8E0002; Thu, 4 Aug 2022 22:30:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 47BDC8E0001 for ; Thu, 4 Aug 2022 22:30:24 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1DA871C7207 for ; Fri, 5 Aug 2022 02:30:24 +0000 (UTC) X-FDA: 79763959968.31.C072CB4 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf24.hostedemail.com (Postfix) with ESMTP id BBC29180024 for ; Fri, 5 Aug 2022 02:30:23 +0000 (UTC) Received: by mail-wm1-f46.google.com with SMTP id ay36-20020a05600c1e2400b003a4e30d7995so3337690wmb.5 for ; Thu, 04 Aug 2022 19:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=f2BJAmcvvAY58PqydeJ3rqlXHLmAQBj3QTr5P4Kw3c0=; b=BCWgPMUiqsf6voBMKS3E1sVghsxihJNJYf6OZNBIW1EBgukFXdjKdpXkknYwboJZmV Oqg80QJnNRE9vRnhZrYEE6FN4M8zsYFhNRd87LrpXvgxVp8qO43AaJjaXBa5iwfOQPPa tw+vo0v2ZRV+Vh+ewQct2iJyX0WkhWWL3QVKiRwe1zLaZkLJjMbe6BY7qqb3qG83QcoG mA2Bdy+AaF8GIYwiIzNJsCbB4/XmlsTLrpKxAMW/r+ux6DKmla4N7synfrp3WyzfHslQ Hac9bUR4u4M6yF+OjPnj/60AKZ+lox08y6pAEGGbISYv9LBpsiVVoZNU7uzF9B57SMOx PNPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=f2BJAmcvvAY58PqydeJ3rqlXHLmAQBj3QTr5P4Kw3c0=; b=R9vZNxiMDz8YDgrxeDd9BlRq/pYzvZjl/B4TnwQajG/HBTg+D8SYyR8T7hJFCDNgYb j+7mTV+BFVvVBFsgEgjBRMAYFVwkc/EdLxCkBmfhyALc8L/ZapVXWL9drkWgLPHf0ZJF ngFkJ1lfcyvuGB/iXFG80Qetxtu4RejgecOI3jdSmQHvdpPVfI2HUfMr9kkPG5W/TP+u CeQKMPgY7flx1flddHTLYy3yiyToZjO1U4+fwSoG0IHDmxa68hMKjhAFOzJaDaTmRt/S FmtVAAszv09/M41bqxWAS1eJco57lePy4d6NMlbb0Y+4EyRt4Q4Lck77qW4DNbYOyfpc I9Mg== X-Gm-Message-State: ACgBeo3MO90sH1RYTQDDIW/D60Y+99jSRtbWYY/brKotnAGt1KwAP7nQ B0YY3zxZ9qPGCIheylm/2sh4ikU1/mUoWTG04ro= X-Google-Smtp-Source: AA6agR583zdSdbt9DGt/RdC+2iBD6u4dj1TSH3PYoKW9X3RGUMvo+oo42KBSOe0pORHN4Ma+l2lvwRbIQ1IeDD0Llow= X-Received: by 2002:a7b:cb55:0:b0:3a5:41a:829c with SMTP id v21-20020a7bcb55000000b003a5041a829cmr5524554wmj.153.1659666622409; Thu, 04 Aug 2022 19:30:22 -0700 (PDT) MIME-Version: 1.0 References: <20220804084135.92425-1-jiangshanlai@gmail.com> <20220804084135.92425-3-jiangshanlai@gmail.com> <20220804123520.1660-1-hdanton@sina.com> In-Reply-To: <20220804123520.1660-1-hdanton@sina.com> From: Lai Jiangshan Date: Fri, 5 Aug 2022 10:30:10 +0800 Message-ID: Subject: Re: [RFC PATCH 2/8] workqueue: Make create_worker() safe against prematurely wakeups To: Hillf Danton Cc: LKML , linux-mm@kvack.org, Petr Mladek , Peter Zijlstra Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659666623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f2BJAmcvvAY58PqydeJ3rqlXHLmAQBj3QTr5P4Kw3c0=; b=NyKd+CsmcAxtPC9O/Agx17qkt8fzFY+VioUeYPhdw6zpxgCaK0+mwWTAm3SoAGTd60FI5L ApgabDsCSi15Wxj7VJetfvABZVDmLxJxksW/vpSA1ZwRuwQdOkltqvgIiz3Tkqo9aiTTZz xUAUdqjAQ71qy4HJIBGwNTes2WBeL3E= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BCWgPMUi; spf=pass (imf24.hostedemail.com: domain of jiangshanlai@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=jiangshanlai@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659666623; a=rsa-sha256; cv=none; b=5MtBwhBZt/YLY8qBIygMV8MPZzBVEptJgbZLY8XH9IrwNObUwf8IGuTaMNY3b5aH6blDaX zd614jfeSQeW2ZbT6aKBTAMveRIErGP1xHLdDii9Bt96ch5fh3ksrqve/cx2ufwqeCzxz4 /6bk10JoHA0rGtiP0XaPuSnwE9cmE8I= Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BCWgPMUi; spf=pass (imf24.hostedemail.com: domain of jiangshanlai@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=jiangshanlai@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BBC29180024 X-Stat-Signature: qiwo8e3a98jkryq4a6wqfxjy18x6fzqz X-Rspam-User: X-HE-Tag: 1659666623-113561 X-Bogosity: Ham, tests=bogofilter, spamicity=0.003132, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: i On Thu, Aug 4, 2022 at 8:35 PM Hillf Danton wrote: > > On Thu, 4 Aug 2022 16:41:29 +0800 Lai Jiangshan wrote: > > > > @@ -1942,6 +1943,7 @@ static struct worker *create_worker(struct worker_pool *pool) > > goto fail; > > > > worker->id = id; > > + worker->pool = pool; > > > > if (pool->cpu >= 0) > > snprintf(id_buf, sizeof(id_buf), "%d:%d%s", pool->cpu, id, > > @@ -1949,6 +1951,7 @@ static struct worker *create_worker(struct worker_pool *pool) > > else > > snprintf(id_buf, sizeof(id_buf), "u%d:%d", pool->id, id); > > > > + reinit_completion(&pool->created); > > worker->task = kthread_create_on_node(worker_thread, worker, pool->node, > > "kworker/%s", id_buf); > > if (IS_ERR(worker->task)) > > @@ -1957,15 +1960,9 @@ static struct worker *create_worker(struct worker_pool *pool) > > set_user_nice(worker->task, pool->attrs->nice); > > kthread_bind_mask(worker->task, pool->attrs->cpumask); > > > > - /* successful, attach the worker to the pool */ > > - worker_attach_to_pool(worker, pool); > > - > > /* start the newly created worker */ > > - raw_spin_lock_irq(&pool->lock); > > - worker->pool->nr_workers++; > > - worker_enter_idle(worker); > > wake_up_process(worker->task); > > - raw_spin_unlock_irq(&pool->lock); > > + wait_for_completion(&pool->created); > > > > return worker; > > cpu0 cpu1 cpu2 > === === === > complete > > reinit_completion > wait_for_completion reinit_completion() and wait_for_completion() are both in create_worker(). create_worker() itself is mutually exclusive which means no two create_worker()s running at the same time for the same pool. No work item can be added before the first initial create_worker() returns for a new or first-online per-cpu pool, so there would be no manager for the pool during the first initial create_worker(). The manager is the only worker who can call create_worker() for a pool except the first initial create_worker(). And there is always only one manager after the first initial create_worker(). The document style in some of workqueue code is: "/* locking rule: what it is */" For example: struct list_head worklist; /* L: list of pending works */ which means it is protected by pool->lock. And for struct completion created; /* create_worker(): worker created */ it means it is protected by the exclusive create_worker(). > > Any chance for race above?