From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D7C2D2A53D for ; Wed, 16 Oct 2024 18:37:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDA6E6B0096; Wed, 16 Oct 2024 14:37:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C63516B0098; Wed, 16 Oct 2024 14:37:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADD5D6B0099; Wed, 16 Oct 2024 14:37:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F57F6B0096 for ; Wed, 16 Oct 2024 14:37:30 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1A7E31A09EC for ; Wed, 16 Oct 2024 18:37:12 +0000 (UTC) X-FDA: 82680322998.09.F353DBC Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf05.hostedemail.com (Postfix) with ESMTP id 4DEEC100009 for ; Wed, 16 Oct 2024 18:37:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=AX7ohKfr; spf=pass (imf05.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.167.48 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729103656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8mhi0Rm0NShxCRtmWPQ7JzqsI/SCo/BLHRuxW9NM0Ss=; b=oD931QQ/Nkp5pNy+ArLGDITDUHoXAtjbT7+SMYYfC2sLU6mA5A8pvAGICEuTUxl7fUTxCM riJTjb8ecBeUMTMB5zgmXbvuKBLgbtHp4OePVSs2GxzNgF6UtqATSEbZNhhIqJNXHxCB3h jqOpOM2H2uYFozu+vjWLaKcUSSPmcjI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=AX7ohKfr; spf=pass (imf05.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.167.48 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729103656; a=rsa-sha256; cv=none; b=khG/l+qWmtwZ7sGGcyt7V1nv5J1vAA+HKX2troye2qDrFUtQ+UyS990vKCtU2ajQUd42ka mhCKFbhSc8A1VpIJ3WICfPsXlIJ/Vu86z/OtvkwdA5FYN2stJDrGd26tD2LXkwYi00PRP8 o6Bc423WW81T9BxdVi1pVzNMQY9R+AI= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-539eb97f26aso141385e87.2 for ; Wed, 16 Oct 2024 11:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1729103845; x=1729708645; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8mhi0Rm0NShxCRtmWPQ7JzqsI/SCo/BLHRuxW9NM0Ss=; b=AX7ohKfrNYQSI5cVBrpCWPIznkfqv+wTYpr96zvpBjzfS++Puid1rPp/eNAD8WdN1z /Q+/o09g8S8xUi6ZuhR2GLSjpE6OkyFuh0TKeXltotjubxOA0k0m7EBeB/mgbpIOvJ64 RjQFl/Ldq+X83jRshFG5273OzVu4vmo/caQkA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729103845; x=1729708645; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8mhi0Rm0NShxCRtmWPQ7JzqsI/SCo/BLHRuxW9NM0Ss=; b=oGdEAXUhpC9GdoWZ11kyn42OmB0paZLVr0JxvXkmAeKFZxxmOIW2FqZ0khZ1+2/x1H DbCRinVW1Vq/ReBJC/P9Hnjb89jNEstn0PGT6MW51Q0G6qHmafPQNjzv1OFZAR2sH6kY LDOMgqvFDDnFFSe07hnLZAG2gbNCkA+j8Y5/UGpM5d7AKHjA/zOi9A5IsYjLRGCB/HaI Ph4sTs1uIjIemoePqlmGqMco8zpy4jf9d8OchM4s4GBHRxtGAlCvhbdWJFlR+VuxRsM/ LLQ991xR2BOxAhW6wBvH29allQbTzNOI6BxPY31+xaLOddEPwjrnW6Qs7lvdnuB3RUds o5Zw== X-Forwarded-Encrypted: i=1; AJvYcCVzLJ0XDH/7QiXyyWay6LjIK0r5k6psNzWA1m01flM8Ylre/PTcLc5WENKhYYttvggGEQitB04+Mw==@kvack.org X-Gm-Message-State: AOJu0YwAZDbKoHREam6cu6srFnRGcCsVAgeD5+B2cwl7p5pP7JNjFT/c HVn8G7lERTqBo930fIsvXBJVvKnYAOjyeMYiJ9zRX2kjMST16kkWLpxapNGNy7IL7FByVDuToic Zb8+9TjdWmIspYtM/N3mNMbHcVG+Rl4plZOrqWg== X-Google-Smtp-Source: AGHT+IHz8coHWueaTNwFQ4hAEABzC4JAn2gAGVKRhvtF1vLkK1xh18Om2BQVhHyhzZQ+in4UDqaMsTGbNRyKzQpVVa4= X-Received: by 2002:a05:6512:3b9d:b0:539:ebc8:e4ca with SMTP id 2adb3069b0e04-539ebc8e707mr7599340e87.10.1729103845064; Wed, 16 Oct 2024 11:37:25 -0700 (PDT) MIME-Version: 1.0 References: <20241014182228.1941246-1-joannelkoong@gmail.com> <20241014182228.1941246-3-joannelkoong@gmail.com> In-Reply-To: From: Miklos Szeredi Date: Wed, 16 Oct 2024 20:37:12 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] fuse: remove tmp folio for writebacks and internal rb tree To: Shakeel Butt Cc: Joanne Koong , linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, bernd.schubert@fastmail.fm, jefflexu@linux.alibaba.com, hannes@cmpxchg.org, linux-mm@kvack.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4DEEC100009 X-Stat-Signature: k8w1jcr838rqzcbxk7s1jorfs84rfqbt X-Rspam-User: X-HE-Tag: 1729103830-778799 X-HE-Meta: U2FsdGVkX18XcfgU2R2ZFea2FU3sDYWKPFPNIVjgOuxh9LKPbTVbeNB/BuTylIEUJuyPtAhJEfQFfw/zEliI8cGfNyJ1imDwpqAx/hSPONgE+qpEe0Wx9VBmpe5HXmin6ylzvWUarSA2gsvEULUHRjyHX10BIU5s8x8VTr0Px5Z/ErxPJx4F4uyX1KaVE1gNpxVMRlx99YdTs+C0MdH/Tk8fp221vGBQBh3zPVRZMqNTbVTVrTmBK9c6SKq+x09mttMFnjcOSfcmtrmhZ+LidTleJFneS3k6szQicW/RXbnNOTk87e+pXLN1MhoTwZIVCSkoEPuxo+RPF04qVQv22L3fDZ6I7YSqsYETLS3cDBvVCuIBuI4gyRrLSPFfYWP3gicrzMYKVtYNDUXkEtdlw4udlK+zdEw1iOYdohY6iMfogdSEXvKxRgb8AmX7xZOy/tX1P7qJ2uCJ0H2Mx0BtxClYvpeXSdA1VVQIGgjMfyfAjJ86maEYEGmmZIhOK6JGTuOtnTmx57pRW/czRQHaJbxINaLtd8CXtvNuoPcr8Plas0RQfmZfsf26OgnIMKHjQcBDY6xF6pj/6l0chjGv0vVZXiKzlXeW2gWjaDyNqPP2AGowOP9aEsZOBr5iWy8iz797zZyPRS5/9B2vT2CyceYf/1V4TFPwKN6x8kVJfpoK9Z9jNeS0wjlchlctQXevC5QxGPG7KRrFiVvEutK99TZWOwlpTZC+fFqek1NjvIXLm3yPu5nBco185d6ahMtGE+Qdu4YQzeQekkgjuNGbHa1sdhMIAUMUL3LcCtPAJ98/MYFftCXRiNPTmnIDy4EU1V9TxZHzoWQzZLT5xnpacvuXE0boImgMSUAqlxbZt2ubtZaQfLqPxkb/yPN9xHPGE9vzRbd0vbCFOlRKtxh4dicnMW8WjW3OTt6YvCJmaB0do7yNzsrOLEflWzRXCEgcql/9Xrbeb5CKRMagcUq SOp7I7Sc 0q8ntZ/lcwkm176P9hbfOJEv4oa6ovMxfvdAQhFcBR5Vs8+tOLO/quDyROL4FjTtoxAdrLBka+75a6dicLxRuKtRbLaFDG8MCHOaDx4FH8nvkLLjcfRgWio28aIDVVwNb+rFYQ5fRQBZbHMw7cddGj0E8oChxae0Z7WazQvEnfLpnvOEv4r4Hy94xDNxpv7hEAr1e X-Bogosity: Ham, tests=bogofilter, spamicity=0.199020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 16 Oct 2024 at 19:52, Shakeel Butt wrote: > If I understand you correctly, you are saying fuse server doing wrong > things like accessing the files it is serving is not something we need > to care about. I don't think detecting such recursion is feasible or even generally possible. > More specifically all the operations which directly > manipulates the folios it is serving (like migration) should be ignored. > Is this correct? Um, not sure I understand. If migration can be triggered on fuse folios that results in the task that triggered the migration to wait on the fuse folio, then that's bad. Ignoring fuse folios is the only solution that I can see, and that's basically what the current temp page copy does. Sprinkling mm code with fuse specific conditionals seems the only solution if we want to get rid of the temp page thing. Hopefully there aren't too many of those. Thanks, Miklos