From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B2FC636CC for ; Wed, 15 Feb 2023 15:32:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEE706B0078; Wed, 15 Feb 2023 10:32:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9E896B007B; Wed, 15 Feb 2023 10:32:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A662B6B007D; Wed, 15 Feb 2023 10:32:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 95D166B0078 for ; Wed, 15 Feb 2023 10:32:45 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 63166AB58B for ; Wed, 15 Feb 2023 15:32:45 +0000 (UTC) X-FDA: 80469918690.01.E4FA5D8 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf13.hostedemail.com (Postfix) with ESMTP id 3596220026 for ; Wed, 15 Feb 2023 15:32:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=pyNfe8Xn; spf=pass (imf13.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.208.54 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676475162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MgMa6EJ46w+TjF/u1gN/gW9+ztz/QXzmUwMpKJQYIyo=; b=5Vgz/s+lTKkEXX4juvgW1jUohx5I/HpFyQ1SwoiriBSKmKsqGC4+1NkUiNUyxkgd5lrJOL sNwDonT8shVnjVTHUXRtuKYDH6/wH0Bjq8HY4WOa8748WP7QjYmFzuoL9gKDF7SBNkX8Wn Bl9lG5PZjNx52EbaRrUGjHVWpkRzs9g= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=pyNfe8Xn; spf=pass (imf13.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.208.54 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676475162; a=rsa-sha256; cv=none; b=y1xZAnN+F3ufu7aZrmPgCIAvJo4PgEEDMp0OXBtLVE1ZCTanzL6HCpOx9KOkany7QXGo0J mwJ3o44ocNVSRbcx8W4/LdV64ASOTnrlPOhHt3D4NLwXiFW8hezfdvz9OpN7NC6JWwc5ih Wp3FoXWkHAimUbWJ6jIOrig95IilACY= Received: by mail-ed1-f54.google.com with SMTP id s11so14945578edd.10 for ; Wed, 15 Feb 2023 07:32:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MgMa6EJ46w+TjF/u1gN/gW9+ztz/QXzmUwMpKJQYIyo=; b=pyNfe8Xn4nvIZUJPkKZ3EaDZhM1x8wWbetMkTtOH0evncRwi4yKGLjXRdzWjQL+CGR zUU0rFXSeptYAzExzFvW5+hXf/mgKS+dwLmZL5MjnyEJlezTk5F+xWRqKbGGbiqg9+q9 EouNtTLiuyHyjSqyEs9gJGIWlHCjyVFL6bBpg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MgMa6EJ46w+TjF/u1gN/gW9+ztz/QXzmUwMpKJQYIyo=; b=d+S8AY0Yq4sDSrKPqMtSrX0P3AYfopdToU6AlMwSDTDUUS40aU1ClX5pHVusFYCVtt ssXjUR7vs8X89xJW6Li8gpmWLKJOXVdgKyA6hQFVYiL8tgpTtykVSR0i2Okna1m3Ezdx WikDiT+0aNLygSu0l14V3m5R5stCD9Bq+VWTEPE/AT6gNYRTAMTbw+8ethD0Ek1uP2Zg f17zmrsQTk+UtVrLY78anE5Xt6y2EQtB+fLJ97Jll1UYR3xOnv1RR0cxnlpWYsdHx2Wb +CWFLhvYg0Jr7wRE6Ll/mqTSt86npoOsg32xWK3hHgn1VdA59vJe9ry+zmso1dRmFEfN 0K3Q== X-Gm-Message-State: AO0yUKWrRbbE/pe5ocaCcg5wEcMJgQvOk9s30XFM6zo+3vJh0/KtGvpV 9uARoB+kUyQnnn45xBc6vZJyuTC6CHt1WXSqTb/74A== X-Google-Smtp-Source: AK7set+rq8teOzHKNYBPin6GVDaWwGDfSkNDQLU44vMY19ftzX6MLaAK4DBXIxvqGc9E5ohBKkFVnJp40DgTuL1DMUc= X-Received: by 2002:a50:ab5a:0:b0:4ac:c453:6d5f with SMTP id t26-20020a50ab5a000000b004acc4536d5fmr1332039edc.8.1676475160544; Wed, 15 Feb 2023 07:32:40 -0800 (PST) MIME-Version: 1.0 References: <20230214171330.2722188-1-dhowells@redhat.com> <20230214171330.2722188-6-dhowells@redhat.com> <3367219.1676473410@warthog.procyon.org.uk> In-Reply-To: <3367219.1676473410@warthog.procyon.org.uk> From: Miklos Szeredi Date: Wed, 15 Feb 2023 16:32:29 +0100 Message-ID: Subject: Re: [PATCH v14 05/17] overlayfs: Implement splice-read To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard , linux-unionfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ed76twzan1h1twdt9udjr9ma7dmwaw3x X-Rspamd-Queue-Id: 3596220026 X-HE-Tag: 1676475161-16814 X-HE-Meta: U2FsdGVkX18SSfzODNyqCNjmj2Q/l+gZeT8b8Jlt1OlfOOJdfc4eA3RA7OdKWnZsW9Z8zeXtXlc+sOaRaMRW5lP/C/b1AXqbMMD5zq8XT3ugGxbwC8SJHEYjmT/F3wzS4qNZsPDui+ZZb608EQGc73ap/Toz6KsTNbNfskfoF0zyADxqHilT/vs5wUMVNT5HuiI8jmWp684uVmEbzjIvmDyotDGkTTSFWVJzUms3vF2Ym4MINeyJkA4Vn1UOaKi35F2ucL1lYO7Y2SbqL6ftlKr5NCIKKLZYKPPfFXiQkvGO5Z3O5nEzJ47zTOPp4cbCRa3Oj1ZchyqZYQwHgoU8JFJgSSntx+GAkBLZ8LfpEYPpAtA6zw1RKkI6HbkIiaIsdnv0I5t5svI5bPfZbT+dhHPTKVUiY6biegjlzeuX/GcRDXq04XvY0jJtj5bEtWeNk4a7OKlGG8SwvUF73hD+VmL2+5t9khzE1TcV+zKmrIo23qsD3OMZEBZkLZKhJbTswNmvyZ3I1y7NXSwD75p4NSsjYaWuXlCkGKw0noUrN+91tHeVNjYiA7f12EKrjzyJiB3cfbfATTMSBAreqCcLAGgaIlTkO9GgW8UB197TIaQF5QD58EFKI5H4lNDRnaPe2aeFCnmUZkbBKsbNAXSxXmXwcVRoXfc6H4rfy4ouK1/Sne+bH2tVZoe9dzpr6vbhDEkHaJb8z8MdA5DEIKf6lWkj4YyuoMbk/eKxJnoxz+lJTi1+sagD3i27631joK9JGhyD8DHL0pEk+Vvzp/JICFUdBnyRzpicClZVF6DsxvW2ZhZvxjy4W1xTsycrPLjz3t3pZ/14eU7lDx2Xi23TMEs2LvHGjSnvAfvvI7afrkL+7HcxnONyLav74nVisisWj/uobM6Qx4Po7TE4sXzsL9Wt5ziW/wdUGQl005ZbpkhrBm147+hoARxvnhHGs8YdbTrOpeDD66R0XanGnPV TyseYHrU CAomOCY7Nqr0xpx2ujkbhNdJ+A+LvVRehJ986MjFOuKciEAaEPn3msVFnMQwMr24ZZj8h34YLZmBEA41jOUwcUCTAqyn/7ZzKdvSKrSxj2HXEZ+Z199pR8a5szsguqIe8fPbWM4BLV4G6rpRtqZpyK3KPh5OSWuegvLXpUhcnk9ogRGM+cND5gxv4tBF1IeKaAi7l1wYg71l9fgfz+kCp0ExJwrIrUzMXvNeSljqQ2syguC2apzBOaFuXnbkTSID34DwTiTgVkaUMou8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 15 Feb 2023 at 16:04, David Howells wrote: > > Miklos Szeredi wrote: > > > > + ret = -EINVAL; > > > + if (in->f_flags & O_DIRECT && > > > + !(real.file->f_mode & FMODE_CAN_ODIRECT)) > > > + goto out_fdput; > > > > This is unnecessary, as it was already done in ovl_real_fdget() -> > > ovl_real_fdget_meta() -> ovl_change_flags(). > > Does that mean ovl_read_iter() and ovl_write_iter() shouldn't be doing it, > then? That's a different thing, because ovl_*_iter() are checking on ki->flags, not f_flags. Thanks, Miklos