From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB754C43217 for ; Mon, 14 Nov 2022 13:26:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 354EC6B0072; Mon, 14 Nov 2022 08:26:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 304856B0073; Mon, 14 Nov 2022 08:26:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CC236B0074; Mon, 14 Nov 2022 08:26:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0D42E6B0072 for ; Mon, 14 Nov 2022 08:26:04 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D797DC04DF for ; Mon, 14 Nov 2022 13:26:03 +0000 (UTC) X-FDA: 80132121006.01.EF60EA0 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf30.hostedemail.com (Postfix) with ESMTP id 4780580007 for ; Mon, 14 Nov 2022 13:26:03 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id e13so8312101edj.7 for ; Mon, 14 Nov 2022 05:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7bOKX5TmubEFskw4ICGVY0HuA0Ifnh0YrvDjw0FPwIw=; b=plr7sz64IIJ+YKeOBQwdEF60I8YYhToAoTtQSWJnUoDLY3YmH8HfsKQMiRS9gK73Ap r4o35wxvxQ6WKXnvBasNO/C727QB0hG+oUbtEvc40Q2oGMS47LDr9i3Y0bj4F4FfJgfs 5JPmJw9gEHSraq/4D6scIf/o/11djiYIPp+bc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7bOKX5TmubEFskw4ICGVY0HuA0Ifnh0YrvDjw0FPwIw=; b=S511kmIbLWcGwqRKS9/21L5kECcFGb1EFXHtb7HOetaq2AyUQ9npTwA83KSn5M5eMz 0dJ0t/mY+ZSPQA+PMAUBl+y+0rcBoS4sioiWuYQCj+7PB4UuBSda2b8ldsHI49BkPby3 AZSgWeuaTAy4oxmumpQsG0Xi/4OVEYYfCHyyoARyMKJe2Cdx8jbMuPr1wkuZB7eh+k2f 8bGIykLlDTJN1VUPhol+sJSoIAjoZ4Gm0vO+NMAuSkh+EDhDSHpl8y0RTGz9EZvY4xJK Crh5zkoZjl87A93msXAccx80lZz4a+M9npYtF4gALLCXoX3Ofn8GCdpYYNtZF51N4lg6 g76w== X-Gm-Message-State: ANoB5pkYtSI/wf+xG8O6SVG1G/9QmthzKy4lTenT8HYMlEFqn+hi8QKX BchrBDniEkXI+0dXe5P0457d5BgyvAkG/qHLXm44Mg== X-Google-Smtp-Source: AA0mqf4GhiAmKUpwyR2O1bQEFuhJCU40aqld6qS+QNo0yXE8Q41MRiyRCsE8OEKSd35zVlY76dQfoEvIt9lj16tvF6E= X-Received: by 2002:a50:fa9a:0:b0:467:6c56:df3e with SMTP id w26-20020a50fa9a000000b004676c56df3emr9602096edr.270.1668432361653; Mon, 14 Nov 2022 05:26:01 -0800 (PST) MIME-Version: 1.0 References: <20221101175326.13265-1-vishal.moola@gmail.com> <20221101175326.13265-3-vishal.moola@gmail.com> In-Reply-To: From: Miklos Szeredi Date: Mon, 14 Nov 2022 14:25:50 +0100 Message-ID: Subject: Re: [PATCH 2/5] fuse: Convert fuse_try_move_page() to use folios To: Vishal Moola Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668432363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7bOKX5TmubEFskw4ICGVY0HuA0Ifnh0YrvDjw0FPwIw=; b=uXYlMyY4uElUmvpp1hV7JV9a0oT1ZEuyDBPENedHV4bqVyvyk/s2vyc+kAKH9sOEMX9AfH EE2XMz87AB32si9Lq1qzpWGiytNxR7v+oYK1xSvOMNGNVvdFQqAlK8nIAHdKPnQhzkWW8b uRZbMsHlbHIKQK/UGydEGdUG/AOokvc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=plr7sz64; spf=pass (imf30.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.208.48 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668432363; a=rsa-sha256; cv=none; b=KSkCqIW7rZrha/pCnwL2opG/bophmcsR/osW0pH91l2NvqDNz7lK6SrmBVyb7YYcgK/1kc 2guc70rmO1Th/ZjlBShK+Q4FdvkFSH4wEnH/Zuw89i9psi5h6wZGrxUn0asMQIkoRecrdq MA90gNFJRRQ4tGPU7F64P5/9ckUzh9k= X-Stat-Signature: 4usxhjuu1ctreocq3dcpn9ymy51scszn X-Rspamd-Queue-Id: 4780580007 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=plr7sz64; spf=pass (imf30.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.208.48 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1668432363-815544 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 10 Nov 2022 at 19:36, Vishal Moola wrote: > > On Tue, Nov 1, 2022 at 11:24 AM Matthew Wilcox wrote: > > > > On Tue, Nov 01, 2022 at 10:53:23AM -0700, Vishal Moola (Oracle) wrote: > > > Converts the function to try to move folios instead of pages. Also > > > converts fuse_check_page() to fuse_get_folio() since this is its only > > > caller. This change removes 15 calls to compound_head(). > > > > This all looks good. I wonder if we should't add an assertion that the > > page we're trying to steal is !large? It seems to me that there are > > assumptions in this part of fuse that it's only dealing with order-0 > > pages, and if someone gives it a page that's part of a large folio, > > it's going to be messy. Miklos, any thoughts? > > Miklos, could you please look over this patch? I think this should take care of the large folio case in fuse_try_move_page(): if (cs->len != PAGE_SIZE) goto out_fallback; The patch looks okay. Acked-by: Miklos Szeredi Thanks, Miklos