From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509F8C64EC4 for ; Wed, 15 Feb 2023 16:40:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E074A6B0074; Wed, 15 Feb 2023 11:40:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D90446B0078; Wed, 15 Feb 2023 11:40:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0A276B007B; Wed, 15 Feb 2023 11:40:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AC45C6B0074 for ; Wed, 15 Feb 2023 11:40:19 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7799A120189 for ; Wed, 15 Feb 2023 16:40:19 +0000 (UTC) X-FDA: 80470088958.06.218A1E2 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf27.hostedemail.com (Postfix) with ESMTP id 57D4840002 for ; Wed, 15 Feb 2023 16:40:16 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b="O1Sb/PuA"; dmarc=pass (policy=quarantine) header.from=szeredi.hu; spf=pass (imf27.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.208.51 as permitted sender) smtp.mailfrom=miklos@szeredi.hu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676479216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uRPFQs3djXckE7Oktaa+X2AruZRRb1EX46zdXuL2aNA=; b=ShDsMo2kPDTddtLV0NZAVbi9uiBkOAJwUVT4JFBT2XcljccGYjgSoqcFyDv6PyUvD6q+at soCGguJ54NugqXNqD74/v4zxdjoN2mvWucRljIQOZqxQLo0e0l0ljs2VeU7z7O4Wm+V94M P6EVjKW8SlsI6Sdz/hjPmzsLG3N4E7M= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b="O1Sb/PuA"; dmarc=pass (policy=quarantine) header.from=szeredi.hu; spf=pass (imf27.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.208.51 as permitted sender) smtp.mailfrom=miklos@szeredi.hu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676479216; a=rsa-sha256; cv=none; b=DHbtEwaZjww28L8O/EPiu2SDF4mPne+kvdWfWHFem8zkYnYIOVBxe6zQnbHhcisER/ocgD GDuIg7f59qHFQS2dBVl1uvT72ML0DXSt1xoldXRwI5BUHeT3MkHiXIi7ooNCaPw1wUjwap 1UH1zO/UiSVpuPM51f38UAeN1fQF6JE= Received: by mail-ed1-f51.google.com with SMTP id d40so21847575eda.8 for ; Wed, 15 Feb 2023 08:40:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uRPFQs3djXckE7Oktaa+X2AruZRRb1EX46zdXuL2aNA=; b=O1Sb/PuAScpXjzzcEcRfdw765yckWsrlp60Zyj2Buh5pRD57qJFkPGXYlYGCSzbLKZ 0OZJxcmxT4DRgg7vRAKUywcu+0OCNVsBpF50NrQuVlyfYQKR1YKZkGKhonllv6EdWSWj S4d4opyn+39fcS7g6apBLJVuIfqAPFopssH38= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uRPFQs3djXckE7Oktaa+X2AruZRRb1EX46zdXuL2aNA=; b=OuOle7kY/huMMD05fZvSDB0411AU3bzUzypue0/o+C3p14Nqd760RCR8qSUCetgTQU /4j+2zN6FuC+asaujfv1r4mCL8ABeSaAuIJTipcrhA0T4wvcPQd9aZim+BYqtaSXdU7J GiCPGmTI6f40OU3Iw6lkID0aQW2YT7R3tzqFO/xwGJkPltWGacwu7EbZwqEMGY5duQB0 Buo04SKf+ZqIuCWwR+4AkpelQLe4vFFPderDCY1axoH1AJJPFRCFJ0OxUC0Y74r+r4kH xzItRu9vu7Ox4BG+TsCMHsrfMuxAlMOhb4hgadCfXHCxbibyIsseAubxS0aGpuN7YnES AfvQ== X-Gm-Message-State: AO0yUKXSLnp8t/1lu36cAJ+/MZDYKx6SLLwURQow2Q+HN0WTGmCSBUw1 SAdoslhcx+d3lvUTW+YuuupC2E8R0Q5qzUFin2VdcQ== X-Google-Smtp-Source: AK7set/iPBXeldwcN/CINqXYZtP94LHe3RbLgypUPLbVvQFOUAvYldPBfIvqSUN53v/EVz7QuOACKnzaFEzlWm2AvNQ= X-Received: by 2002:a17:906:8604:b0:878:790b:b7fd with SMTP id o4-20020a170906860400b00878790bb7fdmr1331614ejx.14.1676479214862; Wed, 15 Feb 2023 08:40:14 -0800 (PST) MIME-Version: 1.0 References: <20230214171330.2722188-1-dhowells@redhat.com> <20230214171330.2722188-6-dhowells@redhat.com> <3370085.1676475658@warthog.procyon.org.uk> In-Reply-To: From: Miklos Szeredi Date: Wed, 15 Feb 2023 17:40:04 +0100 Message-ID: Subject: Re: [PATCH v15 05/17] overlayfs: Implement splice-read To: Matthew Wilcox Cc: David Howells , Jens Axboe , Al Viro , Christoph Hellwig , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard , linux-unionfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 57D4840002 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: i5gxxfj4o8csa4uim5m594nbsgfeac6i X-HE-Tag: 1676479216-311675 X-HE-Meta: U2FsdGVkX19IrT7500mTDwRZzroi3MS2j2+IJOrmJNOVaA7GiuuxYR2l9sNW8sLdVfDMFru7SOuAO3+lDCkrs8QZukudnuVnXYZj2ciBNQkiHWIJdZa04gSyyxekwJOdlky0TcYRHCDnWGiAK9tYBoBsuFmuGh502cizNMnN/CUENxo/BVR9Mf1tIfrE9Uph9km2moD9BSrw2+gKU4B6u3ZkvYGqiYKqyQUhQMeC8B6fHEKv8xkVT5Dsp3n+7+fLl1Rj+2ZclZirWbgpWn2VBi3hsvrXjcL5fSQ1OVWda3RuM/QLcNNfE/0qr9IsP5S4Pxy5jJuxBw2wCEfp1z8tcttssaSvC7aco0GgSXAfqzFQPrKCzo5m8J8v/3ETz3Rhc9qM8iIixmonmtRIcFIMscNZmRjjH/qvqqg7HYSKPKxAlGxiNslBNO4lLebhfVLcC38z+URrn96c1+jSFB53b4AOrCbyATZ/b0Oy6rJIHmokR1ah63wvLVcGuFKEfGuk51BzX972PnBnvfiSAvsT1ABSBicBqnlAccZcqvpNoXWXDBGdKjKzAG2hyNvPn9WNMCTqlT1Tea4pO4r/wPQt0+v+EKvS7wHwh/xYW+ohX+GAHwrgj7cGdstGZ3hsVHeOi/doBUPYdRIGh586aiU+dRNrzjsSAIcjB7qdt/zq/rPeeBQ06+DZGqBJQv8NGjf1S0Lcv7aphpD12f1SmkCZOfzylJtnF9qBWJAP1YFJZ1N9ySfi/C5Cw8kJpgKlUj0+6xBxZlFstXfJXCeb1WCYEpujprpPZkAS5MqwUroe0mmKSR+2rMlXv8BpL2YShQuzue16Mdx5RLiF9yO1kyKfWwfzigXo2kzf/9HJcbKNKqFI0GfjpA7fVOFwqeYeLYLLjhOxPwkq+rahuqOpAmItH37LbUsiP5RgqL6QZFIhQyHuDgE9nFIEJ1wvG5icneF6MvhEJzhEuMz81vRE0kh T1ULUc8g C3A7RHKKOxo/en8oObP0SP76mJTr+MPVBJHJOptSFWJSvottkwrJlusDERF/2pOUyUzcrDWQOzdvXBngIGXvIw+3Inf9XZUf5eCm+th7ds08tziB9tsPC3KjKkdOAHHoJ71cJ8xsNGUOlg50OQrqL83xLZxBPPaC7J7Ggaq1YqYycaeNMzwfxy3dFywaRsq1gmkHM2WZ12IVznzsgPb8yjCzEVV8Vrk60W1KWEYBWsaQY9kooB4gwKSQ5/j8VL6qd0wPuhVWXRBT40klKF3HN1I6cjbCrjt8sUJh3iKjv1lq8JBDXsERdUJ66Dw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 15 Feb 2023 at 16:53, Matthew Wilcox wrote: > > On Wed, Feb 15, 2023 at 04:50:04PM +0100, Miklos Szeredi wrote: > > Looks good. One more suggestion: add a vfs_splice() helper and use > > that from do_splice_to() as well. > > I really hate call_read_iter() etc. Please don't perpetuate that > pattern. I didn't suggest call_splice_read(). vfs_splice_read() would have the rw_verify_area() as well as the check for non-null ->splice_read(). Doing it that way from the start would have prevented two of the bugs that David introduced in the first version. Thanks, Miklos