From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB52DC001DE for ; Mon, 24 Jul 2023 13:55:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4901F8E0006; Mon, 24 Jul 2023 09:55:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 440538E0002; Mon, 24 Jul 2023 09:55:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 307BE8E0006; Mon, 24 Jul 2023 09:55:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 203048E0002 for ; Mon, 24 Jul 2023 09:55:38 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E1813C0A8D for ; Mon, 24 Jul 2023 13:55:37 +0000 (UTC) X-FDA: 81046653114.22.A1CAD0A Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf07.hostedemail.com (Postfix) with ESMTP id B1BEB40015 for ; Mon, 24 Jul 2023 13:55:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=gvHlyPxp; spf=pass (imf07.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.167.48 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690206936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cLuBTJcHgRw5Dz5uIr7zOsQg7JkLL64F6mhAMmK/Urg=; b=ygdbT82WzB0jCXCG4FBpHQyXJgv3wjI1E4SClb7davTOO5T3x3l/yIUSJ5Afsd4SIFrQPf UtoEpI5T/GCE0Dv+qgTamQlGQLAUspNaiA4jPSRhhV7qFzTSd4JS7JfaCkjcdj4njUWgXk Yi0o5wgfBQ5qCnwCkHVkAFCHzCAWWPo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690206936; a=rsa-sha256; cv=none; b=76QA9vntisxKMOfcuOd8lPFfa9GFl7w3Ku5gHgvhMfW+u5Se4Qch3yzFj+ZA7pXMs86KhE UgyLX5z/glPUUalafv52gMMKKLqXomwHNZiW1a31gcV1e+WazR0RgQ/b68eA4R58ea8H/N NHrUj1V7LxSkn9e5wJPmDEdOtMV5upc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=gvHlyPxp; spf=pass (imf07.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.167.48 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so6521652e87.2 for ; Mon, 24 Jul 2023 06:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1690206933; x=1690811733; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cLuBTJcHgRw5Dz5uIr7zOsQg7JkLL64F6mhAMmK/Urg=; b=gvHlyPxpUKDXveeruAvPPnL2uwW7r0Lm6j/W1meQaI6mI9bctOF+FA+qn05a9Sgtx6 YLUJNCG7B6Bg6YnKGdq4BjFBF218V2BzeuKMNMBnLqM1NwslZsz/em1+PzKJfEko3N5D Ki+Xww/RrchuUj/d3YykuEcicj0QjNcfotE4c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690206933; x=1690811733; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cLuBTJcHgRw5Dz5uIr7zOsQg7JkLL64F6mhAMmK/Urg=; b=fm8O2O5JkOTlXitmQfQEii67NLt0noYJ/je//V+vWCOZhwCyr58BxwSoCwtHvpQhXg lhHWv/U5qi7SyXOGo+q5jEAzdQX9O1yeibPMqH3FJFK4atiXjvC6a8cWahmwxWfjHotW KKJAsDTOFE5NboI7a+M3WH2X5lagF/jUoGYcbbrbfe1GirqPmjWz2pEUPHPiD/qJMgPE iqtwk5sftJwoPGVtgVYqBIS7YLbFnU1J6bVWz13K9tVauHiP7xeCWWBIiWn+zSVG5bFP DQ1zWItyQUnAKnHaHFekX4KRja8ABM6nTVJdU7JXgVC4EvzGhY5sPtRMIVc8KyMlPioQ EKtA== X-Gm-Message-State: ABy/qLZu2PrM8ULH2VWR1twfJN3p+eP5SkiNb9bCzx2ESD8+2VmvBYxn 6RFSOU2Aeew/+8fWeGylhIdlxjD3Vo0u6806anVBeg== X-Google-Smtp-Source: APBJJlFFevIadl9sawEPFI9I5OR2dPQnGvYtXsyb59paj5UKaXjSUkFCIk1mA0a3cy0sEARUqP5jmS4qlpHJ1cAJBSw= X-Received: by 2002:a05:6512:234c:b0:4fa:5255:4fa3 with SMTP id p12-20020a056512234c00b004fa52554fa3mr6246134lfu.5.1690206933287; Mon, 24 Jul 2023 06:55:33 -0700 (PDT) MIME-Version: 1.0 References: <20230629155433.4170837-1-dhowells@redhat.com> <20230629155433.4170837-2-dhowells@redhat.com> <63041.1690191864@warthog.procyon.org.uk> In-Reply-To: <63041.1690191864@warthog.procyon.org.uk> From: Miklos Szeredi Date: Mon, 24 Jul 2023 15:55:21 +0200 Message-ID: Subject: Re: [RFC PATCH 1/4] splice: Fix corruption of spliced data after splice() returns To: David Howells Cc: Linus Torvalds , Matthew Wilcox , Matt Whitlock , netdev@vger.kernel.org, Dave Chinner , Jens Axboe , linux-fsdevel@kvack.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: azgc4zzbbkuygatk858wxtywxfnb594a X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B1BEB40015 X-Rspam-User: X-HE-Tag: 1690206935-693624 X-HE-Meta: U2FsdGVkX19euc2+zNb06yVDx0E8wj4FXX6iyvalKXkNCZxMc8EZw2rUT138EZEflfd+o97AnI4FuxfQMxJ/0WXu4WEMgptK3AVc2mKOksGHLi2dX0VlZrRT3W3sRRyE120M0JnBYveT/cMsLnKaGXK7XqR18N8k8cUzzsy5fVyB2/Q9p6VR6p7BxYLEwFK+YyCeBN6bWgFU1hSdDq4ehsCMmvF3KipL8pgWwXzppn/M9IaZQ97rJPbUU8W0KcGhw3GLd2YGV/iKqxYsFcXkvbQDO2o3YNoSxx1iNjdPUnvIRXaTqO2Y+BycO87hEcoMHbMuYt2W6eNF+oU4+ONY6eJULAxLHRqlMxLNziu1lVrSKWgbCx7lHj70BRMUZhjgHTM50cR4FTFZL5xG9TKbnL2hsh8WhwaerTHF/zoILThTZ2bRNOmvCPauFvyfLw0TNNX4bYIhMs7ocNKYeHNvCxNFJUu8fJgrz0TC66dcv94DhC+pvoElZHahW5iCQYnsSkxUJR49a5RG9+gQ2n787xR5ePL0EKW8wRPTEPnvFG27EvrKKmFEK5H1QaC9Wj87k/he6T6jk3CiyP4n3yZhc+TNozzXTC30KwlV7a8aWVBfAOWAtl/ZkCElvyQ9cbvSl5pLmMgrJdsc0y9e+qY4SX1mfOJT0mwN40pDlXop2OZ+OnD7a3Vhgndkn7G3XzrRwoWqiNXJhtZUfVcdWqfjSKrydyxGgyfaMGFbjqqs2tb3iXBQdkXVuqidrv9XoFbIrHjM26ux3m5br7ONttJ7WEkWZuBK9rVeehzdRschUddq5D4CWUwEl50nEL9es7yF8rn97SgaG5YL88CKAAPQyZbNPYGqn7mv+qYP8zdRmygCLvifG0PTbTqJlfzIFwn/TpFpcu7WneRQdDWVLKgnQPkw/cIeTcr6Kgk7c231zIIg5X3PbjidQe7Yv6OnSDf9fwOHf+78S9jMukcRijM ZgHI/zTY NGLlE0WXjZah1YrLIupWl6vXIeOu0fzR0b5nS6RvI6Nk+pFOoZDdVLMMSSDow3JdY6w2+Z8JomrETfxuNgqbD8Oe7KN/B68JT9aXVvYkhL2ZjM/dOJWokEP00Q8inAzG/pHKyGlQ+Ix8QvF1lTyQ1LUv4xiZK1q2bLUclC9DkanZ0JMFcjVHEH4/IdkWYIYV1+J8MUYvc/vKA5GXt2EL1yADhpd902I60JH7WVbJcnmNN5QM4ApzEbc9r1BX0l2iphBXQ5sCy7ZMOqMalzZe+0ZxBpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Jul 2023 at 11:44, David Howells wrote: > > Linus Torvalds wrote: > > > > So what's the API that provides the semantics of _copying_? > > > > It's called "read()" and "write()". > > What about copy_file_range()? That seems to fall back to splicing if not > directly implemented by the filesystem. It looks like the manpage for that > needs updating too - or should that actually copy? Both source and destination of copy_file_range() are regular files and do_splice_direct() is basically equivalent to write(dest, mmap of source), no refd buffers remain beyond the end of the syscall. What is it that should be updated in the manpage? Thanks, Miklos