From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22CAECD11BF for ; Tue, 19 Mar 2024 16:14:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F7486B0082; Tue, 19 Mar 2024 12:14:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A6CA6B0085; Tue, 19 Mar 2024 12:14:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 747786B0087; Tue, 19 Mar 2024 12:14:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 62DC46B0082 for ; Tue, 19 Mar 2024 12:14:03 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D96D1811B9 for ; Tue, 19 Mar 2024 16:14:02 +0000 (UTC) X-FDA: 81914285124.26.326CE7D Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf19.hostedemail.com (Postfix) with ESMTP id 9A1681A0011 for ; Tue, 19 Mar 2024 16:14:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=Ql3c64Yw; dmarc=pass (policy=quarantine) header.from=szeredi.hu; spf=pass (imf19.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.218.46 as permitted sender) smtp.mailfrom=miklos@szeredi.hu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710864841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qssoFyi0EHVSMQZ8tvcNSLF8ll1cyBFfjAUL3WkFTKQ=; b=0cXSLZr59od8P0pJxXFDi1ftXke7oBHC5o0DjivFG+ehC45mirtBakMmyKC2HEkkWpaZGE nECM7hIw4JoRr+41R5Dt5eFiWyHTwM1CGeUdtxpQR4lyAo6YWDIVfkWTrx/aPCSB736spv iGPnGKRKgzikU9ECf/2noXGpNOXi4aM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=Ql3c64Yw; dmarc=pass (policy=quarantine) header.from=szeredi.hu; spf=pass (imf19.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.218.46 as permitted sender) smtp.mailfrom=miklos@szeredi.hu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710864841; a=rsa-sha256; cv=none; b=Ko447s0/uAoPGE6J/3qOx/CBBsWPzzyMceCwlfrqJE0ZZBkjYsrIEww8zapBBK3vVac/rY dM5DN0n4redD4hI4lMPg3H8EQa5q/Miyvju09eLJPkPA9bv7Ns+pvmJasCKKwJdcHurgg4 PlPfeo3VJlXNYarAJGDaF26EtGF8bbA= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a46cd9e7fcaso248820966b.1 for ; Tue, 19 Mar 2024 09:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1710864839; x=1711469639; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qssoFyi0EHVSMQZ8tvcNSLF8ll1cyBFfjAUL3WkFTKQ=; b=Ql3c64YwJ4sckizAwrMZsWIrMRVgfmW5VBmYjOHF+O1WOH+OQ0coe+uokky47qjIQZ 5GRfbAQ9T126mss20tZIbC3Er1KRDGoaC6A1DPyCExnAzeEcILV9wsUmrjsLNMQ88Eok kqwKCp06iXxQSMIofOOzRvBQnyL7mPA9ln6i0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710864839; x=1711469639; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qssoFyi0EHVSMQZ8tvcNSLF8ll1cyBFfjAUL3WkFTKQ=; b=fSTUEe5w5LDWw9kcq3pc/vShHdKiTWPeekQSBHIVW8vGs3SQ8qxkCBTE9wU7GUc1sX 1RSzb6OKJaT0c34NRvWXfaF1dkDtThlpuG0RX15cPO6gCw1qaD9OJhUiuMzPp41ef5Pl TM8KQO+TMbAzS8gO1FwM9s5tYlRnfyONbEuRqDGJfQQxjeCbNFhvhQB1/t8mr9PBEdYr fmGzJELn9RWLlBvq6n8MgXjUgt37T+eHhlGMdSxseQepQbYFC5Lc8ik1K0fphZ0nnhms FYg0aWnzAuuCM0ElIrnSEzyHkSwxFYZqPwLxRDNtOywrcJ7tDBF91W3jdqCiwYKxaEZr h4xw== X-Forwarded-Encrypted: i=1; AJvYcCVZBwvyobTNX/esvjO6jIB/mb5Ix5PwV+HNp47Dmgm2I8k4g7/JcmgBFJVWCCRPFkPLskfHe/G7l6Ox9rOetVxJ9Ew= X-Gm-Message-State: AOJu0YyyZpCuMyqUWmCVwxIRwhivCJRJxrngSj9z7YtoCEWywqtr68K7 T7MFF6p3Sx3aIHm1u2ysPvoouqrkPqBNgNY2fwbqgn24RkH2/U4pan0cFjHuu+fURWkJsfz3gZj nemOmNODJIdyhRo+e7knFpB7CkNwNS533FDZOIA== X-Google-Smtp-Source: AGHT+IG80idJ/eoHfs/tS8xY4ItmYTZEjrCulMFp8PsOW5O33PBCGW/QH9XqH6EWMgC+d4lP/zrFK1SKGKNE4vf/7pM= X-Received: by 2002:a17:906:af07:b0:a46:47bc:580b with SMTP id lx7-20020a170906af0700b00a4647bc580bmr2203920ejb.56.1710864838625; Tue, 19 Mar 2024 09:13:58 -0700 (PDT) MIME-Version: 1.0 References: <1668172.1709764777@warthog.procyon.org.uk> <1831809.1709807788@warthog.procyon.org.uk> <651179.1710857687@warthog.procyon.org.uk> In-Reply-To: <651179.1710857687@warthog.procyon.org.uk> From: Miklos Szeredi Date: Tue, 19 Mar 2024 17:13:47 +0100 Message-ID: Subject: Re: [RFC PATCH] mm: Replace ->launder_folio() with flush and wait To: David Howells Cc: Matthew Wilcox , Trond Myklebust , Christoph Hellwig , Andrew Morton , Alexander Viro , Christian Brauner , Jeff Layton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9A1681A0011 X-Stat-Signature: htofws8c8ckhns7hpy6nb1bjqx3iwn1t X-Rspam-User: X-HE-Tag: 1710864840-980060 X-HE-Meta: U2FsdGVkX195TFROHBGbCzsJP00TrE78BqTh0yBfZpcqc2tVDLJl7qC3O6b56/ZTPG5zKOfA1MGwsq4Q4IwP+iVuBMh7IJXRH7VBCwVQxftVwX44LlVDjliCSfFasV0Xflr25fN+F+pOZlsa3xwkXXtfk3lU7brSKYjT4PxLSNHDvh634MJhgSAKL5qz1z8FWRfZl7eNAghBLfaLNVg1zaZA6WN6Tkg+/7h+Sg6Mqi5PmVUDv1UMHaoEXlIluAsgog7fS2svbzSl69zUTIeOiVFe0MGayb8UcPUW4PQGHdncDb3cnzfpuL9+wTrB2AG15KyKA8l+HSOQxdrYOzHlv4CV+U9Zw6s6TYFx2jTr4+l+P12k6eDGohxH7Zh3/sFftn0tjxnBNo1FsRyTeOoKSqZNph1+7MKl1Z1kdedM+S7wECXadk5/zJTabHkRtSJ34VXT98appdzOom00d1zZsZrcFEV7yz/EKWbt7PsGttIPCjcpNYwz+Ub3B5t3FdPDTvGwKfBn/ewEE7nVsXXaGiDxxvaccetJCttxdZMwyOpW6m7w4mJ5nEjl1sqzCwAxwj9D5Uxwtw+z92KdEp+Ivb1N5wlIddIyTCQUWvPUddNeNQGzSuNdNoakdeqb6jSnxHJEfl8vdKiJy2bEZPtpcyH4Vcdv70P09GWZqf/dBuMy8cgfcUhDnVPGMPE6kJky/jfCufQjVRMRMGOO1VcxQlNxPhw67PV+0MuxttZ2IKwpo/LlSe3ABndd9V+qZ8A8cEli9dQ/Gn5AZdP+v9TM6lsUIv+EAE/Dw1b1a4wKziFxbzdYVBWEt0B9akVSiNbWhKuSecR45RBwZgeAK0VANI+3Vf9vUrV8tQ/9Jt8Ugh++jTpV1Uaj+auU9zN6u7y0aVZ2QRP1rb8Fa2oWq5mCBbme+mze+YzZG8WcDq+elCIGjQ8OPlj9+Ii9A1VNa83/+iYvITDaXvOJ2U3gTyH g/9SxdWC Y7Z+o+iNA2wI8rwALuswZ5zcXPO5VqjY1KFsYHoBav6+NQeaeBtW9GChXCHOT1A+XBCcJBFy/rUA9FM42A6HATkoYK4IQQRVz/U4/908halbG3gu6D3xgelFyuOzDHtuClDHYiSdOXOz6zisoXK7op0VcJ3I3Um1ge2RlPDU5YCptljilhLgQa3TiK+9vp/FYNuqXVCplre4Wg0Oq3Jowxvt+QH08x3jobHWT23EnXjGi+DRvTomqRuvSrlSEYGrAmvtD9ld3XlKkd7xb+d96ArXlzoiF35QEKfYzlSui0cK+xYY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000046, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 19 Mar 2024 at 15:15, David Howells wrote: > What particular usage case of invalidate_inode_pages2() are you thinking of? FUSE_NOTIFY_INVAL_INODE will trigger invalidate_inode_pages2_range() to clean up the cache. The server is free to discard writes resulting from this invalidation and delay reads in the region until the invalidation finishes. This would no longer work with your change, since the mapping could silently be reinstated between the writeback and the removal from the cache due to the page being unlocked/relocked. I'm not saying such a filesystem actually exists, but it's a theoretical possibility. And maybe there are cases which I haven't thought of. Thanks, Miklos