From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F40EECFC280 for ; Tue, 15 Oct 2024 10:01:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8118E6B0082; Tue, 15 Oct 2024 06:01:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C1566B0083; Tue, 15 Oct 2024 06:01:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B06C6B0085; Tue, 15 Oct 2024 06:01:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4FBD56B0082 for ; Tue, 15 Oct 2024 06:01:18 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2B54B1214BC for ; Tue, 15 Oct 2024 10:01:10 +0000 (UTC) X-FDA: 82675393542.08.DD68F59 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf11.hostedemail.com (Postfix) with ESMTP id 842C340022 for ; Tue, 15 Oct 2024 10:01:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=eHOPFzhT; dmarc=pass (policy=quarantine) header.from=szeredi.hu; spf=pass (imf11.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.208.43 as permitted sender) smtp.mailfrom=miklos@szeredi.hu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728986371; a=rsa-sha256; cv=none; b=CurgWVGiaLCPYzWodGnh+y7ADnX7y5T3n1ukzdZAonztDa7DEa/5I+Q2LEykLWBmunTgan EowRsAUVAzKR37hNGIbHVBY+QDirEfome3ckQEfWvG6AdJyGoL0Iw9qP5T9u+rKLWTsfgj BQ1LTkIeN0NCFq3Tfrb48q3FUWL/XJk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=eHOPFzhT; dmarc=pass (policy=quarantine) header.from=szeredi.hu; spf=pass (imf11.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.208.43 as permitted sender) smtp.mailfrom=miklos@szeredi.hu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728986371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZkXujz+AkPMr+hXtOemRGyDp0iKQ1I/BZJu2qkSfe2s=; b=AzzC3jrWFN46UyInrat7SYdU9mf0tuwVZyOgixlX2HqJV5nnooPBKEUk8qOTwIJO4XsW+m Sz9kriyocpwKqnsPrdT/LE0RvvbWpHF+NqFnNtH6wwlZ2d4T1ORCgsz+SHGFVQj28QHWyN myseCPxHX5n3K5vHJDiBcv0epIc0Zso= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5c984352742so1961186a12.1 for ; Tue, 15 Oct 2024 03:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1728986474; x=1729591274; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZkXujz+AkPMr+hXtOemRGyDp0iKQ1I/BZJu2qkSfe2s=; b=eHOPFzhTg5Ed9Ay2XbqnAVEAXBIOEFyynNi5qmgTaWkklZgirOeq74A9T0MjiCrZNG mt/tKFpqJBC7yjVn7J0FMUbc6DEoecEALHabqU2uP7SMcxUsOS3Cq9sYsJ11XTglXpVh 1mr/Oc4bVo3z05FA2LwnYJfYCjDEsuD59yFCU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728986474; x=1729591274; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZkXujz+AkPMr+hXtOemRGyDp0iKQ1I/BZJu2qkSfe2s=; b=NhmSfq0vWUB901FCjpS7UWNpD2ddJvS7eBIwCuJ5FBUvaEI88SGFSlWXQTqEBC53Gi +hsjYTyV0MDoUtzZluDOogQxwkiksvMBAMyD6x3dtBXAgExDTExgWMsc+Sbk/VqTu/kr hMzpCBRwZaMJaOgwMd4BKXblzXI3rY85LebgzMxfOat44Bf8cowPt97tudcsNplNyaaX 0omSWbBnkwGEWYqNwfpvlvj+k8dCGBqx2Qw5GqimMLdThy5MUynQyvJzaE/XSndVDXAT m/WpOkiZoYacgqYXUJBptvVuMUbUtUTGIpqAVb0WkVrbMx1gIk3npgLm1OyGVSnchIti B15Q== X-Forwarded-Encrypted: i=1; AJvYcCVzjAlbWNcaJ2qP0WEuhsb0dzin1dL0JCariauaiug+z0XSc9rXKLAproRYlGD4PABILa/AZE1K2g==@kvack.org X-Gm-Message-State: AOJu0Yy1UbfBZfJN+DuCFf5XW7SkDncQnxpQEdrGfWVOJyjOOE97NdO0 9BbYccRfpT/1hDTU5KqLWAW3Oed0s6QoQJZGEdNP5q8cKPxhAszuwY+9vxlKOmtSCaF0871dRbs ae0aVu4oHupTrWJbai7Q2peXt50KWQTZ6kfAVPA== X-Google-Smtp-Source: AGHT+IGVXoQx9gJzbIH3x6IQ9zFCkGUg4As7h8fjBdik3kQjUSrUhjbURXqnVglvr0JZ1FSxYtJee0vidTJZcPmCSGA= X-Received: by 2002:a17:906:4fcd:b0:a99:e505:2089 with SMTP id a640c23a62f3a-a99e50522d4mr1095725866b.45.1728986473980; Tue, 15 Oct 2024 03:01:13 -0700 (PDT) MIME-Version: 1.0 References: <20241014182228.1941246-1-joannelkoong@gmail.com> <20241014182228.1941246-3-joannelkoong@gmail.com> In-Reply-To: <20241014182228.1941246-3-joannelkoong@gmail.com> From: Miklos Szeredi Date: Tue, 15 Oct 2024 12:01:02 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] fuse: remove tmp folio for writebacks and internal rb tree To: Joanne Koong Cc: linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, bernd.schubert@fastmail.fm, jefflexu@linux.alibaba.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, linux-mm@kvack.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 842C340022 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: zfzqbqrx54fw1os9yieo788swf7d7woj X-HE-Tag: 1728986467-832472 X-HE-Meta: U2FsdGVkX18ftRu7ICbiNvamdyndFLUEjjanhjrQqIrvblRBXywnyJ2o9mMa+0peavSyg28GzIJmBjIlynPPOUpoYyrUCmY5+2MERuW3C42ama4h6SxxyX67RCkebT2xHp4tu28XO9id5CaPTosYo+HSNnMinAS3VgkezVYxY9gWrkRSesgLuqgup6oUwfkiBGbZGDBMzM4eEELu2sCwTr93+xo/zAH/GX7uy5YDQNZiLxP7apJa+bvloQ/0eA0EMCAFT7rTjvNb8bJ9vOxqs6W8Klu5C8WC4jbF6FXfgNlD2JehUWWclbr2RNSoEgHNk6WKo39Dt67OZHeahM4C5bv0iw64ONirItUoXWQ9F/vcWJyjuw3rTFzVYiTgu/+2vNl7HHongLIFPPSf5eBB8jdyvbolK3cyrRURZNn8d0hOQAS73ubdrQ3JBUmdMye9cNJP5i6LwYTL6KIXRYTrcJDqFP3mzLqp/NvuaiqvJ6t/Wsls80Z2vbmBqzTgFzCLntTS2pyCF2xQEVTY9+5lDr5cek+trgyKlTAWmEFgXxPBkX6lRi61WjEsZKF2BOW32fR59QH2YV2+k+TiX505MD4LAx8UPzu4np2bc8qOTZGOqMTb9CgRA3ZhlKlcJrFGLrvNkAKd53PtO5HPqPt9IYNEeyE4TnqXsNZs+hB6w9NuTIs+r/pWqgzJsoWhbZ+0bQJsq1oOIkyMMpSRrloMd1rF8N+KjX4fZVjTbsLa3lnXVQTquDoBWBJDGtJB0DtxOL1J3eLIWYNvC7WIosCpg+V5wmlY8BE/+OYi145lbuoo2yjJ5bdj2eDf4anSxXPcMMTfhxSu5g3RQAX+6ScfSla0bAvURVsVnvy1ONUYoeDeqKYB5oy4A1AMlQ/OdWCkDiuYeGOTTfJK99M23rVCZ6GILWfaL2smGb/uZfC2rp4phUuS8u9NSWlT+6Cfv33YILx31H1eDIkiXGyqZ75 kviZGorx RjTm+MGHdtGJjhNbSEOODtFDq7ozAoCHj6kBSC+iSjcjUStEvFCV0MlKKcpX3G03yU/FcXvl1Wa6zIAUE3DUxckQy/ZLjO1CqfZcsOp2J0SB9yEQzSRMA5iu03HJZjb6EGmbKFc5u7sNRjeOu+xMvQi2lBM7XzlOpL9sgplnKKncpYMFFo9s1QkYx/aqkmcmouS92ZcbnFInoBLQRivgC26p4eH9XuhgGDvLW X-Bogosity: Ham, tests=bogofilter, spamicity=0.021252, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 14 Oct 2024 at 20:23, Joanne Koong wrote: > This change sets AS_NO_WRITEBACK_RECLAIM on the inode mapping so that > FUSE folios are not reclaimed and waited on while in writeback, and > removes the temporary folio + extra copying and the internal rb tree. What about sync(2)? And page migration? Hopefully there are no other cases, but I think a careful review of places where generic code waits for writeback is needed before we can say for sure. Thanks, Miklos