From: Hillf Danton <dhillf@gmail.com>
To: Linux-MM <linux-mm@kvack.org>, Hillf Danton <dhillf@gmail.com>
Cc: Michal Hocko <mhocko@suse.cz>,
Michel Lespinasse <walken@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] rmap: recompute pgoff for unmapping huge page
Date: Mon, 4 Mar 2013 20:23:00 +0800 [thread overview]
Message-ID: <CAJd=RBDfEJnEQETd-FFZo8ERRTfKV+-TXvM_c50OgY9UD_+s7A@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
We have to recompute pgoff if the given page is huge, since result based on
HPAGE_SIZE is inappropriate for scanning the vma interval tree, as shown
by commit 36e4f20af833(hugetlb: do not use vma_hugecache_offset() for
vma_prio_tree_foreach)
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/mm/rmap.c Mon Mar 4 20:00:00 2013
+++ b/mm/rmap.c Mon Mar 4 20:02:16 2013
@@ -1513,6 +1513,9 @@ static int try_to_unmap_file(struct page
unsigned long max_nl_size = 0;
unsigned int mapcount;
+ if (PageHuge(page))
+ pgoff = page->index << compound_order(page);
+
mutex_lock(&mapping->i_mmap_mutex);
vma_interval_tree_foreach(vma, &mapping->i_mmap, pgoff, pgoff) {
unsigned long address = vma_address(page, vma);
--
[-- Attachment #2: Type: text/html, Size: 1505 bytes --]
reply other threads:[~2013-03-04 12:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJd=RBDfEJnEQETd-FFZo8ERRTfKV+-TXvM_c50OgY9UD_+s7A@mail.gmail.com' \
--to=dhillf@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox