Re: [PATCH] arch/tile: support multiple huge page sizes dynamically

[Hillf Danton <dhillf@gmail.com>]

Hello Chris

On Sat, Mar 31, 2012 at 3:37 AM, Chris Metcalf <cmetcalf@tilera.com> wrote:
> This change adds support for a new "super" bit in the tile PTE, and a
> new arch_make_huge_pte() method called from make_huge_pte().
> The Tilera hypervisor sees the bit set at a given level of the page
> table and gangs together 4, 16, or 64 consecutive pages from
> that level of the hierarchy to create a larger TLB entry.
>
> One extra "super" page size can be specified at each of the
> three levels of the page table hierarchy on tilegx, using the
> "hugepagesz" argument on the boot command line.  A new hypervisor
> API is added to allow Linux to tell the hypervisor how many PTEs
> to gang together at each level of the page table.
>
> To allow pre-allocating huge pages larger than the buddy allocator
> can handle, this change modifies the Tilera bootmem support to
> put all of memory on tilegx platforms into bootmem.
>
> As part of this change I eliminate the vestigial CONFIG_HIGHPTE
> support, which never worked anyway, and eliminate the hv_page_size()
> API in favor of the standard vma_kernel_pagesize() API.
>
> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
> ---

[...]

> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index a876871..4531be2 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2123,6 +2123,9 @@ static pte_t make_huge_pte(struct vm_area_struct *vma, struct page *page,
>        }
>        entry = pte_mkyoung(entry);
>        entry = pte_mkhuge(entry);
> +#ifdef arch_make_huge_pte
> +       entry = arch_make_huge_pte(entry, vma, page, writable);
> +#endif
>
Would you please make arch_make_huge_pte() the way
that arch_prepare_hugepage() is implemented, or similar?

>        return entry;
>  }
> --
> 1.6.5.2
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>