From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx179.postini.com [74.125.245.179]) by kanga.kvack.org (Postfix) with SMTP id 40B316B0044 for ; Sat, 4 Aug 2012 09:54:58 -0400 (EDT) Received: by vcbfl10 with SMTP id fl10so1844850vcb.14 for ; Sat, 04 Aug 2012 06:54:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1343875991-7533-5-git-send-email-laijs@cn.fujitsu.com> References: <1343875991-7533-1-git-send-email-laijs@cn.fujitsu.com> <1343875991-7533-5-git-send-email-laijs@cn.fujitsu.com> Date: Sat, 4 Aug 2012 21:54:57 +0800 Message-ID: Subject: Re: [RFC PATCH 04/23 V2] oom: use N_MEMORY instead N_HIGH_MEMORY From: Hillf Danton Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Lai Jiangshan Cc: Mel Gorman , Paul Menage , Rob Landley , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Greg Kroah-Hartman , Johannes Weiner , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Christoph Lameter , Pekka Enberg , Matt Mackall , Jarkko Sakkinen , Matt Fleming , Andrew Morton , Yinghai Lu , David Rientjes , Bjorn Helgaas , Wanlong Gao , Petr Holasek , Djalal Harouni , Jiri Kosina , Laura Vasilescu , WANG Cong , Hugh Dickins , Naoya Horiguchi , Konstantin Khlebnikov , Sam Ravnborg , Paul Gortmaker , Rusty Russell , Peter Zijlstra , Jim Cromie , Pawel Moll , Henrique de Moraes Holschuh , Oleg Nesterov , Dan Magenheimer , Michal Nazarewicz , Mel Gorman , Gavin Shan , Wen Congyang , Rik van Riel , KOSAKI Motohiro , Wang Sheng-Hui , Minchan Kim , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, containers@lists.linux-foundation.org On Thu, Aug 2, 2012 at 10:52 AM, Lai Jiangshan wrote: > N_HIGH_MEMORY stands for the nodes that has normal or high memory. > N_MEMORY stands for the nodes that has any memory. > > The code here need to handle with the nodes which have memory, we should > use N_MEMORY instead. > > Signed-off-by: Lai Jiangshan > --- Acked-by: Hillf Danton > mm/oom_kill.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index ac300c9..1e58f12 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -257,7 +257,7 @@ static enum oom_constraint constrained_alloc(struct zonelist *zonelist, > * the page allocator means a mempolicy is in effect. Cpuset policy > * is enforced in get_page_from_freelist(). > */ > - if (nodemask && !nodes_subset(node_states[N_HIGH_MEMORY], *nodemask)) { > + if (nodemask && !nodes_subset(node_states[N_MEMORY], *nodemask)) { > *totalpages = total_swap_pages; > for_each_node_mask(nid, *nodemask) > *totalpages += node_spanned_pages(nid); > -- > 1.7.1 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org