From: Hillf Danton <dhillf@gmail.com>
To: Dave Jones <davej@redhat.com>, Hillf Danton <dhillf@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: unused swap offset / bad page map.
Date: Fri, 23 Aug 2013 17:08:31 +0800 [thread overview]
Message-ID: <CAJd=RBCcq=yM4YCKxo9GH0S0yzx5E0FWtvfkuOOHVCX0GM_3fw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Fri, Aug 23, 2013 at 11:53 AM, Dave Jones <davej@redhat.com> wrote:
>
> On Fri, Aug 23, 2013 at 11:27:29AM +0800, Hillf Danton wrote:
> > On Fri, Aug 23, 2013 at 11:21 AM, Dave Jones <davej@redhat.com> wrote:
> > >
> > > I still see the swap_free messages with this applied.
> > >
> > Decremented?
>
> It actually seems worse, seems I can trigger it even easier now, as if
> there's a leak.
>
If leak, add missing swap_free() for another case of reused page.
--- a/mm/memory.c Wed Aug 7 16:29:34 2013
+++ b/mm/memory.c Fri Aug 23 16:46:06 2013
@@ -2655,6 +2655,7 @@ static int do_wp_page(struct mm_struct *
*/
page_move_anon_rmap(old_page, vma, address);
unlock_page(old_page);
+ swap_free(pte_to_swp_entry(orig_pte));
goto reuse;
}
unlock_page(old_page);
--
[-- Attachment #2: Type: text/html, Size: 1588 bytes --]
next reply other threads:[~2013-08-23 9:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 9:08 Hillf Danton [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-07 5:51 Dave Jones
2013-08-07 10:04 ` Hillf Danton
2013-08-07 15:30 ` Dave Jones
2013-08-08 15:20 ` Hillf Danton
2013-08-08 15:36 ` Dave Jones
2013-08-19 23:18 ` Dave Jones
2013-08-20 4:39 ` Hillf Danton
2013-08-21 20:49 ` Dave Jones
2013-08-22 0:35 ` Hillf Danton
2013-08-22 3:21 ` Hillf Danton
2013-08-23 3:21 ` Dave Jones
2013-08-23 3:27 ` Hillf Danton
2013-08-23 3:53 ` Dave Jones
2013-08-26 3:45 ` Hillf Danton
2013-08-26 19:08 ` Dave Jones
2013-08-26 20:15 ` Linus Torvalds
2013-08-26 20:46 ` Linus Torvalds
2013-08-26 22:08 ` Hugh Dickins
2013-08-26 22:28 ` Dave Jones
2013-08-27 8:37 ` Cyrill Gorcunov
2013-08-27 16:24 ` Dave Jones
2013-08-27 16:32 ` Cyrill Gorcunov
2013-08-26 23:15 ` Linus Torvalds
2013-08-27 5:44 ` Cyrill Gorcunov
2013-08-26 20:18 ` Cyrill Gorcunov
2013-08-26 20:37 ` Dave Jones
2013-08-26 20:42 ` Cyrill Gorcunov
2013-08-26 21:37 ` Cyrill Gorcunov
2013-08-26 21:42 ` Dave Jones
2013-08-26 21:49 ` Cyrill Gorcunov
2013-08-26 21:59 ` Dave Jones
2013-08-07 15:54 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJd=RBCcq=yM4YCKxo9GH0S0yzx5E0FWtvfkuOOHVCX0GM_3fw@mail.gmail.com' \
--to=dhillf@gmail.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox