From: Hillf Danton <dhillf@gmail.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Hillf Danton <dhillf@gmail.com>
Subject: [patch] hugetlb: correct page offset index for sharing pmd
Date: Fri, 3 Aug 2012 20:56:45 +0800 [thread overview]
Message-ID: <CAJd=RBB=jKD+9JcuBmBGC8R8pAQ-QoWHexMNMsXpb9zV548h5g@mail.gmail.com> (raw)
The computation of page offset index is open coded, and incorrect, to
be used in scanning prio tree, as huge page offset is required, and is
fixed with the well defined routine.
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/arch/x86/mm/hugetlbpage.c Fri Aug 3 20:34:58 2012
+++ b/arch/x86/mm/hugetlbpage.c Fri Aug 3 20:40:16 2012
@@ -72,12 +72,15 @@ static void huge_pmd_share(struct mm_str
if (!vma_shareable(vma, addr))
return;
+ idx = linear_page_index(vma, addr);
+
mutex_lock(&mapping->i_mmap_mutex);
vma_prio_tree_foreach(svma, &iter, &mapping->i_mmap, idx, idx) {
if (svma == vma)
continue;
- saddr = page_table_shareable(svma, vma, addr, idx);
+ saddr = page_table_shareable(svma, vma, addr,
+ idx * (PMD_SIZE/PAGE_SIZE));
if (saddr) {
spte = huge_pte_offset(svma->vm_mm, saddr);
if (spte) {
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2012-08-03 12:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 12:56 Hillf Danton [this message]
2012-08-03 13:32 ` Michal Hocko
2012-08-10 9:48 ` Michal Hocko
2012-08-10 12:07 ` Hillf Danton
2012-08-10 12:27 ` Michal Hocko
2012-08-10 12:37 ` Hillf Danton
2012-08-10 12:51 ` Michal Hocko
2012-08-10 12:53 ` Hillf Danton
2012-08-10 13:16 ` Michal Hocko
2012-08-10 13:21 ` Hillf Danton
2012-08-10 13:39 ` Hillf Danton
2012-08-10 13:48 ` Michal Hocko
2012-08-12 4:08 ` Hillf Danton
2012-08-12 9:31 ` Michal Hocko
2012-08-13 12:10 ` Hillf Danton
2012-08-13 13:09 ` Michal Hocko
2012-08-13 13:24 ` [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach Hillf Danton
2012-08-13 13:49 ` Michal Hocko
2012-08-13 13:51 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJd=RBB=jKD+9JcuBmBGC8R8pAQ-QoWHexMNMsXpb9zV548h5g@mail.gmail.com' \
--to=dhillf@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox