From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx163.postini.com [74.125.245.163]) by kanga.kvack.org (Postfix) with SMTP id 528056B0068 for ; Sat, 29 Dec 2012 02:25:57 -0500 (EST) Received: by mail-oa0-f48.google.com with SMTP id h2so10246946oag.7 for ; Fri, 28 Dec 2012 23:25:56 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <50DC6C6F.6050703@iskon.hr> References: <50D24AF3.1050809@iskon.hr> <50D24CD9.8070507@iskon.hr> <50DC6C6F.6050703@iskon.hr> Date: Sat, 29 Dec 2012 15:25:56 +0800 Message-ID: Subject: Re: [PATCH] mm: do not sleep in balance_pgdat if there's no i/o congestion From: Hillf Danton Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Zlatko Calusic Cc: Linus Torvalds , Andrew Morton , Mel Gorman , Hugh Dickins , linux-mm , Linux Kernel Mailing List On Thu, Dec 27, 2012 at 11:42 PM, Zlatko Calusic wrote: > On 21.12.2012 12:51, Hillf Danton wrote: >> >> On Thu, Dec 20, 2012 at 7:25 AM, Zlatko Calusic >> wrote: >>> >>> static unsigned long balance_pgdat(pg_data_t *pgdat, int order, >>> int >>> *classzone_idx) >>> { >>> - int all_zones_ok; >>> + struct zone *unbalanced_zone; >> >> >> nit: less hunks if not erase that mark >> >> Hillf > > > This one left unanswered and forgotten because I didn't understand what you > meant. Could you elaborate? > Sure, the patch looks simpler(and nicer) if we dont erase all_zones_ok. Hillf -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org