From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx107.postini.com [74.125.245.107]) by kanga.kvack.org (Postfix) with SMTP id D13366B004F for ; Mon, 26 Dec 2011 07:35:48 -0500 (EST) Received: by werf1 with SMTP id f1so6832249wer.14 for ; Mon, 26 Dec 2011 04:35:47 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1324808519.29243.8.camel@hakkenden.homenet> References: <1324437036.4677.5.camel@hakkenden.homenet> <20111221095249.GA28474@tiehlicka.suse.cz> <20111221225512.GG23662@dastard> <1324630880.562.6.camel@rybalov.eng.ttk.net> <20111223102027.GB12731@dastard> <1324638242.562.15.camel@rybalov.eng.ttk.net> <20111223204503.GC12731@dastard> <1324808519.29243.8.camel@hakkenden.homenet> Date: Mon, 26 Dec 2011 20:35:46 +0800 Message-ID: Subject: Re: Kswapd in 3.2.0-rc5 is a CPU hog From: Hillf Danton Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: "Nikolay S." Cc: Dave Chinner , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Sun, Dec 25, 2011 at 6:21 PM, Nikolay S. wrote: > > Uhm.., is this patch against 3.2-rc4? I can not apply it. There's no > mem_cgroup_lru_del_list(), but void mem_cgroup_del_lru_list(). Should I > place changes there? > > And also, -rc7 is here. May the problem be addressed as part of some > ongoing work? Is there any reason to try -rc7 (the problem requires > several days of uptime to become obvious)? > Sorry, Nikolay, it is not based on the -next, nor on the -rc5(I assumed it was). The following is based on -next, and if you want to test -rc5, please grep MEM_CGROUP_ZSTAT mm/memcontrol.c and change it. Best regard Hillf --- --- a/mm/memcontrol.c Mon Dec 26 20:34:38 2011 +++ b/mm/memcontrol.c Mon Dec 26 20:37:54 2011 @@ -1076,7 +1076,11 @@ void mem_cgroup_lru_del_list(struct page VM_BUG_ON(!memcg); mz = page_cgroup_zoneinfo(memcg, page); /* huge page split is done under lru_lock. so, we have no races. */ - MEM_CGROUP_ZSTAT(mz, lru) -= 1 << compound_order(page); + if (WARN_ON_ONCE(MEM_CGROUP_ZSTAT(mz, lru) < + (1 << compound_order(page)))) + MEM_CGROUP_ZSTAT(mz, lru) = 0; + else + MEM_CGROUP_ZSTAT(mz, lru) -= 1 << compound_order(page); } void mem_cgroup_lru_del(struct page *page) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org