From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx200.postini.com [74.125.245.200]) by kanga.kvack.org (Postfix) with SMTP id F1F1A6B002B for ; Fri, 10 Aug 2012 09:39:22 -0400 (EDT) Received: by vcbfl10 with SMTP id fl10so1895885vcb.14 for ; Fri, 10 Aug 2012 06:39:22 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20120803133235.GA8434@dhcp22.suse.cz> <20120810094825.GA1440@dhcp22.suse.cz> <20120810122730.GA1425@dhcp22.suse.cz> <20120810125102.GB1425@dhcp22.suse.cz> <20120810131643.GC1425@dhcp22.suse.cz> Date: Fri, 10 Aug 2012 21:39:21 +0800 Message-ID: Subject: Re: [patch] hugetlb: correct page offset index for sharing pmd From: Hillf Danton Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Mel Gorman , Andrew Morton , Linux-MM , LKML , KAMEZAWA Hiroyuki , David Rientjes On Fri, Aug 10, 2012 at 9:21 PM, Hillf Danton wrote: > On Fri, Aug 10, 2012 at 9:16 PM, Michal Hocko wrote: >> Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for >> vma_prio_tree_foreach >> >> 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page >> from vma) fixed pgoff calculation but it has replaced it by >> vma_hugecache_offset which is not approapriate for offsets used for >> vma_prio_tree_foreach because that one expects index in page units >> rather than in huge_page_shift. >> Using vma_hugecache_offset is not incorrect because the pgoff will fit >> into the same vmas but it is confusing. >> > > Well, how is the patch tested? You see, Michal, it is weekend and I have to be offline now. See you next week ;) Hillf -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org