From: Hillf Danton <dhillf@gmail.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [patch] hugetlb: correct page offset index for sharing pmd
Date: Fri, 10 Aug 2012 21:39:21 +0800 [thread overview]
Message-ID: <CAJd=RBAOu9b5FRmYxbY7dKRp5G8VmOxvtgHLE7jwin1ZgqMmLw@mail.gmail.com> (raw)
In-Reply-To: <CAJd=RBDtnF6eoTmDu4HOBGfHnWnxNsXEzArR51+-XhzFCwOmOQ@mail.gmail.com>
On Fri, Aug 10, 2012 at 9:21 PM, Hillf Danton <dhillf@gmail.com> wrote:
> On Fri, Aug 10, 2012 at 9:16 PM, Michal Hocko <mhocko@suse.cz> wrote:
>> Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for
>> vma_prio_tree_foreach
>>
>> 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page
>> from vma) fixed pgoff calculation but it has replaced it by
>> vma_hugecache_offset which is not approapriate for offsets used for
>> vma_prio_tree_foreach because that one expects index in page units
>> rather than in huge_page_shift.
>> Using vma_hugecache_offset is not incorrect because the pgoff will fit
>> into the same vmas but it is confusing.
>>
>
> Well, how is the patch tested?
You see, Michal, it is weekend and I have to be offline now.
See you next week ;)
Hillf
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-10 13:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 12:56 Hillf Danton
2012-08-03 13:32 ` Michal Hocko
2012-08-10 9:48 ` Michal Hocko
2012-08-10 12:07 ` Hillf Danton
2012-08-10 12:27 ` Michal Hocko
2012-08-10 12:37 ` Hillf Danton
2012-08-10 12:51 ` Michal Hocko
2012-08-10 12:53 ` Hillf Danton
2012-08-10 13:16 ` Michal Hocko
2012-08-10 13:21 ` Hillf Danton
2012-08-10 13:39 ` Hillf Danton [this message]
2012-08-10 13:48 ` Michal Hocko
2012-08-12 4:08 ` Hillf Danton
2012-08-12 9:31 ` Michal Hocko
2012-08-13 12:10 ` Hillf Danton
2012-08-13 13:09 ` Michal Hocko
2012-08-13 13:24 ` [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach Hillf Danton
2012-08-13 13:49 ` Michal Hocko
2012-08-13 13:51 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJd=RBAOu9b5FRmYxbY7dKRp5G8VmOxvtgHLE7jwin1ZgqMmLw@mail.gmail.com' \
--to=dhillf@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox