From: Hillf Danton <dhillf@gmail.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] mm: hugetlb: add might_sleep() for gigantic page
Date: Tue, 27 Dec 2011 21:38:59 +0800 [thread overview]
Message-ID: <CAJd=RBAAbghkCK1R3VbzHyLN5aW6QgE1y+yjGofHUCxZjdTwvg@mail.gmail.com> (raw)
In-Reply-To: <20111227133021.GI5344@tiehlicka.suse.cz>
On Tue, Dec 27, 2011 at 9:30 PM, Michal Hocko <mhocko@suse.cz> wrote:
> On Tue 27-12-11 21:21:18, Hillf Danton wrote:
>> On Tue, Dec 27, 2011 at 8:59 PM, Michal Hocko <mhocko@suse.cz> wrote:
>> > On Fri 23-12-11 21:41:08, Hillf Danton wrote:
>> >> From: Hillf Danton <dhillf@gmail.com>
>> >> Subject: [PATCH] mm: hugetlb: add might_sleep() for gigantic page
>> >>
>> >> Like the case of huge page, might_sleep() is added for gigantic page, then
>> >> both are treated in same way.
>> >
>> > Why do we need to call might_sleep here? There is cond_resched in the
>> > loop...
>> >
>>
>> IIUC it is the reason to add... and the comment says
>
> cond_resched calls __might_sleep so there is no reason to call
> might_sleep outside the loop as well.
>
Yes, thanks. And remove it in the huge page case?
Hillf
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-27 13:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 13:41 Hillf Danton
2011-12-26 7:32 ` KAMEZAWA Hiroyuki
2011-12-27 12:59 ` Michal Hocko
2011-12-27 13:21 ` Hillf Danton
2011-12-27 13:30 ` Michal Hocko
2011-12-27 13:38 ` Hillf Danton [this message]
2011-12-27 13:39 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJd=RBAAbghkCK1R3VbzHyLN5aW6QgE1y+yjGofHUCxZjdTwvg@mail.gmail.com' \
--to=dhillf@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox