From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f200.google.com (mail-io0-f200.google.com [209.85.223.200]) by kanga.kvack.org (Postfix) with ESMTP id 8CD806B025E for ; Fri, 6 Jan 2017 12:58:49 -0500 (EST) Received: by mail-io0-f200.google.com with SMTP id j13so33275670iod.6 for ; Fri, 06 Jan 2017 09:58:49 -0800 (PST) Received: from mail-io0-x233.google.com (mail-io0-x233.google.com. [2607:f8b0:4001:c06::233]) by mx.google.com with ESMTPS id c3si2808543ith.14.2017.01.06.09.58.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jan 2017 09:58:49 -0800 (PST) Received: by mail-io0-x233.google.com with SMTP id f103so40013593ioi.1 for ; Fri, 06 Jan 2017 09:58:49 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170105163527.d37a29d6e7b3bfdafd7472d2@linux-foundation.org> References: <20170103181908.143178-1-thgarnie@google.com> <20170105163527.d37a29d6e7b3bfdafd7472d2@linux-foundation.org> From: Thomas Garnier Date: Fri, 6 Jan 2017 09:58:48 -0800 Message-ID: Subject: Re: [PATCH] Fix SLAB freelist randomization duplicate entries Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Linux-MM , LKML , John Sperbeck On Thu, Jan 5, 2017 at 4:35 PM, Andrew Morton wrote: > On Tue, 3 Jan 2017 10:19:08 -0800 Thomas Garnier wrote: > >> This patch fixes a bug in the freelist randomization code. When a high >> random number is used, the freelist will contain duplicate entries. It >> will result in different allocations sharing the same chunk. > > Important: what are the user-visible runtime effects of the bug? It will result in odd behaviours and crashes. It should be uncommon but it depends on the machines. We saw it happening more often on some machines (every few hours of running tests). > >> Fixes: c7ce4f60ac19 ("mm: SLAB freelist randomization") >> Signed-off-by: John Sperbeck >> Reviewed-by: Thomas Garnier > > This should have been signed off by yourself. > > I'm guessing that the author was in fact John? If so, you should > indicate this by putting his From: line at the start of the changelog. > Otherwise, authorship will default to the sender (ie, yourself). > Sorry, I though the sign-off was enough. Do you want me to send a v2? -- Thomas -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org