From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28569C433E0 for ; Tue, 19 May 2020 15:59:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DDBDD207C4 for ; Tue, 19 May 2020 15:59:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDBDD207C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 650D0900003; Tue, 19 May 2020 11:59:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60112900002; Tue, 19 May 2020 11:59:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53F8F900003; Tue, 19 May 2020 11:59:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 3E2B5900002 for ; Tue, 19 May 2020 11:59:27 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 05F54613D for ; Tue, 19 May 2020 15:59:27 +0000 (UTC) X-FDA: 76833928374.24.sink30_8cae46b64a246 X-HE-Tag: sink30_8cae46b64a246 X-Filterd-Recvd-Size: 2779 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 May 2020 15:59:26 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id b18so726020oti.1 for ; Tue, 19 May 2020 08:59:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EChIuRDHBE2fP/nhZePuBoCI4yW9gOzMTOOZxaha+Mc=; b=jGb9pklrINblt+ZI4D4/Bw2EzWeVukecG/wwy9lxDcOg/LSsoWXY1SUAuuV8LMtpLh Hky+5Ovi+uab8SlUjz6+bDIhkqCxeWJpeuJaLXbpZfO2l08TJWnTdS9rUZNccJLr1yG8 4C1J+u+gJjdwm72XMMcMqlru1x4rKognLjJnnOnUpmUV2c92/TxheRX9OerhLST9luFw vClw6wws7innjCIRM8xPlUVQ3dLv784LErxbCjhvtMq3imH/+SRM0ZepT/djPhmwPzwy jgHPSFpy/bG8hAyNJwsAAoH61v8EMCYDr2o/omJAJxpEwdVEed5hq6xVxhLMJ9wtlbdi hlJA== X-Gm-Message-State: AOAM533RF4FOm8Hi5xb1fed2H3EHoxwGAF+mtzvZ5j0dINtx4NGXwCEY TDynuiNutN9svDDdqaPonsDtulMfpjIwUjXHTzo= X-Google-Smtp-Source: ABdhPJwAtkbCgsui0+h1xBcvCEqFP0J6q3SWQt/hKKidr/kXNdClt4Q1ZYDyL2hyzmh5V8EvoEwCGPA6GQfLuvx6Sr0= X-Received: by 2002:a05:6830:10ce:: with SMTP id z14mr15933980oto.118.1589903966068; Tue, 19 May 2020 08:59:26 -0700 (PDT) MIME-Version: 1.0 References: <20200507080456.069724962@linux.com> <20200507080650.439636033@linux.com> In-Reply-To: <20200507080650.439636033@linux.com> From: "Rafael J. Wysocki" Date: Tue, 19 May 2020 17:59:15 +0200 Message-ID: Subject: Re: [PATCH 1/1] hibernate: restrict writes to the snapshot device To: Domenico Andreoli Cc: "Rafael J. Wysocki" , "Darrick J. Wong" , Pavel Machek , Christoph Hellwig , Al Viro , "Ted Ts'o" , Len Brown , Linux PM , Linux Memory Management List , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It would be better to paste the patch instead of attaching it. Anyway, note that the snapshot special device is not the target block device for saving the image, so it would be good to avoid that confusion in the naming. I.e. I would rename is_hibernate_snapshot_dev() to something like is_hibernate_image_dev() or is_hibernate_resume_dev() (for consistency with the resume= kernel command line parameter name). Thanks!