From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D4B6C3DA58 for ; Thu, 17 Aug 2023 17:42:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A59D28003E; Thu, 17 Aug 2023 13:42:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9547B940009; Thu, 17 Aug 2023 13:42:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81BCE28003E; Thu, 17 Aug 2023 13:42:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 71855940009 for ; Thu, 17 Aug 2023 13:42:35 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 31EB5B2971 for ; Thu, 17 Aug 2023 17:42:35 +0000 (UTC) X-FDA: 81134316270.07.7038747 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by imf24.hostedemail.com (Postfix) with ESMTP id 7641718001E for ; Thu, 17 Aug 2023 17:42:32 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf24.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.161.47 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692294152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SbKSS3dbtmxuOxHslNWQ0jBSymfmz4ReQayKmard/fU=; b=SiC0Z/4gA+iHF+NRIJo2Osh0zuHt0kNqec3sx4/kpJ9cRwP23Rz8K2dvu2ir9sEkC03JM0 JN2W3oWpsECJ2bpHvQVyw0w0Yl2kdC6u6PweQo0EV4OtIaj4ehlJyrcFDlS2G0qRDV+Suy JdTAmnvgzpQPMWj/L4seP+26ljQJg5Y= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf24.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.161.47 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692294152; a=rsa-sha256; cv=none; b=RPGwVFTnTGOKtT9a4wRj0dS3aiOm0ZQPn5pMm/eRVC0aUaA77zAsV6euMCtEGty+OIrsBB DyWLvPfthaMPOdUMkBZxDYdcK6aPFFFOoRxNjrDA6E6QBZttykVYy0isYVIjBZwSZ7kHON h0iFKqtWFtC4gTZ/8UAKwSPz6bvYfrs= Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-56cae50792fso16352eaf.1 for ; Thu, 17 Aug 2023 10:42:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692294151; x=1692898951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SbKSS3dbtmxuOxHslNWQ0jBSymfmz4ReQayKmard/fU=; b=hITTVfVwdqCU94ijWH4gOHF6A5LdlSH+GFlSHIyiywUdjQ13H7ucTVktNgVJlc82LJ 495jRYfImmWIt15VvbfdJcqj4whBX6r77tRIXdrTt2GZLwLY4L0LFo70UeuUVuNVwMNu ZHE3UV7yZ1U1k+gamPuGXH0yc1DOF7/H60MZQNYLdtwfqG0BEOO87zdHZaplGzPuluwv xEIs8vZCetsGVV9TwXhi8Cg2mmwxR3Vt19e1jXHDNSpJKx13vmG+uxCZoo4qd98nXZLU AcbQVyjn6PygSWf1cIKcgBY61dRezl5M56IiMZOJRPODwJzn2zH8hU4h+6ilBVBhiJvS hhKg== X-Gm-Message-State: AOJu0Yxbx57vmoK7SWGZqQ2lTuwtseXMrDiNBXL7qn2dqThQLktpYMP8 YExqB9LQMx6pTz2fObb7x8an8UgqzDlNOsIM7X8= X-Google-Smtp-Source: AGHT+IGt8tO+aZwGEy2r7Ioxzk3ccY4xwluoQTDNQn/dr49mrftA2TviKHvbBAGgENCBk6dlXXMg//68Gn00p/30J5w= X-Received: by 2002:a4a:e684:0:b0:56d:6bd4:4db5 with SMTP id u4-20020a4ae684000000b0056d6bd44db5mr546709oot.0.1692294151461; Thu, 17 Aug 2023 10:42:31 -0700 (PDT) MIME-Version: 1.0 References: <20230802092856.819328-1-lizhijian@cn.fujitsu.com> In-Reply-To: <20230802092856.819328-1-lizhijian@cn.fujitsu.com> From: "Rafael J. Wysocki" Date: Thu, 17 Aug 2023 19:42:20 +0200 Message-ID: Subject: Re: [PATCH] acpi,mm: fix typo sibiling -> sibling To: Li Zhijian Cc: akpm@linux-foundation.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, rafael@kernel.org, lenb@kernel.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, aneesh.kumar@linux.ibm.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: pd3t4ryth5xjfhzxdfadjkesacm8fmq6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7641718001E X-HE-Tag: 1692294152-258779 X-HE-Meta: U2FsdGVkX1/VbiNqraLmfzJiYN/vXk2pYtEuKHVbs7E1120dT36S+FTdkFMEbQ0qP36Jm4/fCcdVK8TattvJ0EPyftufXHhW8B1vThofc4o3YzWcwiT5wKAeXzRUZMHPwJR0vSM7PzJ7aNi8HHXKhHc8rjzv/n7acZ+IAjsViVSaKX2bJPI0S7ZSTJMFounrKhCTw36eG+tx4Vep9gmKE9DgHv1SEsjjBeMM8WNb5VOh7W2NVlzeYJR0TpR/zHXe74Kn1Xk8bgqeAs3OjjURa2R20LSOMe+QDC5Lix+YlJvZxjOMWd5HDua71PRDcTqX82N13bIBS5PI7/sJNLdTMCS69mNDB/G9w0cVw4HpRDi+OXo7UN+QjZe5khmEfvQAAwM4E5opNX4hG1XqVQEL4hVfP7tB5u2PwKrRRDrNRgeFH36ygBVDbJ3TX5g5I2ezbQ0QY63N+nmCjlc3WRCDtLKio1J9IKo5uybef4traV/2R9KU7WZ+M3HBd084ZibCWgZjI9S7SXhzmkURA5qh/Pq6td4icsHQFQxFa6RkrbipCq1JrVSrCD7dXj5LPH7uu28id8kmfOC+qddwKh8j6LL7pmbPXmPoWCItJIq6I6837jViydTSL8sdU0idPnuVZvOTnjgy6YWyuiT/QAtjZFyiNchFzx5aAdHAiIfbten7ZbOpGJh1KA3Bt/mp7kCzxcaL3WkaKoDFtpajOCYbpAsrVmUcApNyLXB82AerMKXFpez1rtXMFJdou1bMzMax9KaeD4uGWr6j5k0Jy7EwBgOgVy9OmWfPYas2ZVzrCHWUtgTJOElFgI45w9ECjOGWLcp98MOPwYPmCZgyFsg9JG2lH/hayUNzosybx+i9KEd4wEyr2oGv7B1sgSXSY3IqwezEKiINgOSiAfshXh3DiQkAM5Y4pmkjobyWW4fl4Qba8+PM/2HVMZKMbQKKRLjGBmCZH3akBmonKR8rAG/ bWoQcmAE bnZSRdNN752K3hFylIxNwpziYagjM9fpDSIPDVMVPKjBXkq0DEoYMc1hw0lENFbAcEwEywe02hrf3o3ZE+/nqORno3q643UKeFDElR7sdVw7H3H3zVGabzsI8NvadeBwN+tYHH3FPBVAVzabYD5Xix0WrmLPUe4rZ4VvYIutfDR0d5q1qTL0jZEmJ8DCxCPibrP7BsJ/4L+IgNgNYkNRMSdkG19hY4saloN75oUbMJjugqy4Mitnm3NojrBlOCV/iATkR7/p9PvLzURQB3jFXl0aZNzmnmQQcXRIxWD6FzLZXImnpRsqZ/LkVs2soWEssFpT8DfijvFq86ZFGIogLOIwCBha5wg7LPD3Mj9qqbPecmT0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 2, 2023 at 11:30=E2=80=AFAM Li Zhijian wrote: > > First found this typo as reviewing memory tier code. Fix it by sed like: > $ sed -i 's/sibiling/sibling/g' $(git grep -l sibiling) > > so the acpi one will be corrected as well. > > Signed-off-by: Li Zhijian Please post the ACPI and mm changes as separate patches. Thanks! > --- > drivers/acpi/acpi_pad.c | 2 +- > include/linux/memory-tiers.h | 2 +- > mm/memory-tiers.c | 10 +++++----- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c > index 7a453c5ff303..7f073ca64f0e 100644 > --- a/drivers/acpi/acpi_pad.c > +++ b/drivers/acpi/acpi_pad.c > @@ -100,7 +100,7 @@ static void round_robin_cpu(unsigned int tsk_index) > for_each_cpu(cpu, pad_busy_cpus) > cpumask_or(tmp, tmp, topology_sibling_cpumask(cpu)); > cpumask_andnot(tmp, cpu_online_mask, tmp); > - /* avoid HT sibilings if possible */ > + /* avoid HT siblings if possible */ > if (cpumask_empty(tmp)) > cpumask_andnot(tmp, cpu_online_mask, pad_busy_cpus); > if (cpumask_empty(tmp)) { > diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h > index fc9647b1b4f9..1e6c8ddcaa92 100644 > --- a/include/linux/memory-tiers.h > +++ b/include/linux/memory-tiers.h > @@ -22,7 +22,7 @@ > struct memory_tier; > struct memory_dev_type { > /* list of memory types that are part of same tier as this type *= / > - struct list_head tier_sibiling; > + struct list_head tier_sibling; > /* abstract distance for this specific memory type */ > int adistance; > /* Nodes of same abstract distance */ > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index a516e303e304..56c22470c96d 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -115,7 +115,7 @@ static __always_inline nodemask_t get_memtier_nodemas= k(struct memory_tier *memti > nodemask_t nodes =3D NODE_MASK_NONE; > struct memory_dev_type *memtype; > > - list_for_each_entry(memtype, &memtier->memory_types, tier_sibilin= g) > + list_for_each_entry(memtype, &memtier->memory_types, tier_sibling= ) > nodes_or(nodes, nodes, memtype->nodes); > > return nodes; > @@ -174,7 +174,7 @@ static struct memory_tier *find_create_memory_tier(st= ruct memory_dev_type *memty > * If the memtype is already part of a memory tier, > * just return that. > */ > - if (!list_empty(&memtype->tier_sibiling)) { > + if (!list_empty(&memtype->tier_sibling)) { > list_for_each_entry(memtier, &memory_tiers, list) { > if (adistance =3D=3D memtier->adistance_start) > return memtier; > @@ -218,7 +218,7 @@ static struct memory_tier *find_create_memory_tier(st= ruct memory_dev_type *memty > memtier =3D new_memtier; > > link_memtype: > - list_add(&memtype->tier_sibiling, &memtier->memory_types); > + list_add(&memtype->tier_sibling, &memtier->memory_types); > return memtier; > } > > @@ -527,7 +527,7 @@ static bool clear_node_memory_tier(int node) > memtype =3D node_memory_types[node].memtype; > node_clear(node, memtype->nodes); > if (nodes_empty(memtype->nodes)) { > - list_del_init(&memtype->tier_sibiling); > + list_del_init(&memtype->tier_sibling); > if (list_empty(&memtier->memory_types)) > destroy_memory_tier(memtier); > } > @@ -553,7 +553,7 @@ struct memory_dev_type *alloc_memory_type(int adistan= ce) > return ERR_PTR(-ENOMEM); > > memtype->adistance =3D adistance; > - INIT_LIST_HEAD(&memtype->tier_sibiling); > + INIT_LIST_HEAD(&memtype->tier_sibling); > memtype->nodes =3D NODE_MASK_NONE; > kref_init(&memtype->kref); > return memtype; > -- > 2.31.1 >