From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 042D3C433F5 for ; Tue, 1 Mar 2022 18:00:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9132C8D0003; Tue, 1 Mar 2022 13:00:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C3558D0001; Tue, 1 Mar 2022 13:00:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B29C8D0003; Tue, 1 Mar 2022 13:00:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 6E7DF8D0001 for ; Tue, 1 Mar 2022 13:00:15 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 38E5861B1A for ; Tue, 1 Mar 2022 18:00:15 +0000 (UTC) X-FDA: 79196581590.08.6CEEE16 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf08.hostedemail.com (Postfix) with ESMTP id 6C884160009 for ; Tue, 1 Mar 2022 17:58:35 +0000 (UTC) Received: by mail-yb1-f178.google.com with SMTP id f5so4990187ybg.9 for ; Tue, 01 Mar 2022 09:58:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MBGf7BonI3ap2E4zIN9sAwq7uxa0Dhwh8KKVMelMOeA=; b=FMi530DEqtXQme6kPlDYZz/GrOtxR5seST5rYJaWHK3ZFZt5FC1AsHssshotRyFwsU WEfaPQfLX2uEFpeWSxFKOpxRkMkjcrKbOkSEbQ2xDmD3ALmmLvnanIXM5mlDgXfbth3b wHdY2gp/pkBK8VdEK5TohxNgrVVHUOm50ygLmfQ3E44Kwgqn0ckyadWANO46VEHho7Hq 5q8VATM9czAy95TaiZe/VsnzzI27/Map1rMKi7928zXBzVEVtQ3JbAO7qyGmJyFQ7GOA dEUVko0PmP96HDd1Cv1YE1lfg6tY+fwwYktgv9WRv1fQ4DXENOzrpNQPvpd/U7SHiB9W 2Udw== X-Gm-Message-State: AOAM530DO9gKnllSqbffo1TLife3be1DWtQ5iQVk6EmdcofmAmxyhK8/ 7gRr/QjnMIw13aPVrGBeTVevTmNDqQ/SXOlqofI= X-Google-Smtp-Source: ABdhPJz5SZhw0CpuWATFioDafwyrSWmIvZN1RYk6r8PiHn3hcphDNq4zDYVsLeEr0gv7HOVI7tgDAvIIHoyQqSMVLXQ= X-Received: by 2002:a25:3a41:0:b0:628:86a2:dbc with SMTP id h62-20020a253a41000000b0062886a20dbcmr2572961yba.633.1646157513220; Tue, 01 Mar 2022 09:58:33 -0800 (PST) MIME-Version: 1.0 References: <202203011104.TkmvSjFD-lkp@intel.com> <20220301032854.GA65991@baa819af95e9> In-Reply-To: <20220301032854.GA65991@baa819af95e9> From: "Rafael J. Wysocki" Date: Tue, 1 Mar 2022 18:58:22 +0100 Message-ID: Subject: Re: [RFC PATCH linux-next] powercap/drivers/dtpm: dtpm_node_callback[] can be static To: kernel test robot Cc: Daniel Lezcano , kbuild-all@lists.01.org, Linux Memory Management List , Ulf Hansson , "Rafael J. Wysocki" , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6C884160009 X-Stat-Signature: 6x1jm6jsqm7beytk46z6pbepkinteb9c Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646157515-677100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 1, 2022 at 4:29 AM kernel test robot wrote: > > drivers/powercap/dtpm.c:525:22: warning: symbol 'dtpm_node_callback' was not declared. Should it be static? > > Fixes: 3759ec678e89 ("powercap/drivers/dtpm: Add hierarchy creation") > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > drivers/powercap/dtpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c > index 414826a1509b6..6d890d8cf9169 100644 > --- a/drivers/powercap/dtpm.c > +++ b/drivers/powercap/dtpm.c > @@ -522,7 +522,7 @@ static struct dtpm *dtpm_setup_dt(const struct dtpm_node *hierarchy, > > typedef struct dtpm * (*dtpm_node_callback_t)(const struct dtpm_node *, struct dtpm *); > > -dtpm_node_callback_t dtpm_node_callback[] = { > +static dtpm_node_callback_t dtpm_node_callback[] = { > [DTPM_NODE_VIRTUAL] = dtpm_setup_virtual, > [DTPM_NODE_DT] = dtpm_setup_dt, > }; Applied, thanks!