From: "Rafael J. Wysocki" <rafael@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH linux-next] powercap/drivers/dtpm: dtpm_node_callback[] can be static
Date: Tue, 1 Mar 2022 18:58:22 +0100 [thread overview]
Message-ID: <CAJZ5v0jQcNUN-mQPu9+tsb=cfdrCaH16U77yMoAPZ2Si2gKX2Q@mail.gmail.com> (raw)
In-Reply-To: <20220301032854.GA65991@baa819af95e9>
On Tue, Mar 1, 2022 at 4:29 AM kernel test robot <lkp@intel.com> wrote:
>
> drivers/powercap/dtpm.c:525:22: warning: symbol 'dtpm_node_callback' was not declared. Should it be static?
>
> Fixes: 3759ec678e89 ("powercap/drivers/dtpm: Add hierarchy creation")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> drivers/powercap/dtpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c
> index 414826a1509b6..6d890d8cf9169 100644
> --- a/drivers/powercap/dtpm.c
> +++ b/drivers/powercap/dtpm.c
> @@ -522,7 +522,7 @@ static struct dtpm *dtpm_setup_dt(const struct dtpm_node *hierarchy,
>
> typedef struct dtpm * (*dtpm_node_callback_t)(const struct dtpm_node *, struct dtpm *);
>
> -dtpm_node_callback_t dtpm_node_callback[] = {
> +static dtpm_node_callback_t dtpm_node_callback[] = {
> [DTPM_NODE_VIRTUAL] = dtpm_setup_virtual,
> [DTPM_NODE_DT] = dtpm_setup_dt,
> };
Applied, thanks!
prev parent reply other threads:[~2022-03-01 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 4:19 [linux-next:master 3353/9295] drivers/powercap/dtpm.c:525:22: sparse: sparse: symbol 'dtpm_node_callback' was not declared. Should it be static? kernel test robot
2022-03-01 3:28 ` [RFC PATCH linux-next] powercap/drivers/dtpm: dtpm_node_callback[] can be static kernel test robot
2022-03-01 17:58 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jQcNUN-mQPu9+tsb=cfdrCaH16U77yMoAPZ2Si2gKX2Q@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox