From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C552AC43464 for ; Fri, 18 Sep 2020 16:02:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50D3B2388E for ; Fri, 18 Sep 2020 16:02:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50D3B2388E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 937EC6B005A; Fri, 18 Sep 2020 12:02:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C03D6B005C; Fri, 18 Sep 2020 12:02:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 788486B005D; Fri, 18 Sep 2020 12:02:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id 5F8406B005A for ; Fri, 18 Sep 2020 12:02:12 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1CBCE824999B for ; Fri, 18 Sep 2020 16:02:12 +0000 (UTC) X-FDA: 77276648904.19.value54_0e0abbb2712c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id BE88A1AD1B2 for ; Fri, 18 Sep 2020 16:02:11 +0000 (UTC) X-HE-Tag: value54_0e0abbb2712c X-Filterd-Recvd-Size: 3811 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 16:02:11 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id y6so7605997oie.5 for ; Fri, 18 Sep 2020 09:02:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CLWLadygFzbacUrStlzsUwiQts54prWGYIH+pDEwe0A=; b=oXt1lsJFE6eaG/EztlWAFmjxsBsJ5D99v6duIM7bzbd6SkpG9jJxCu0m9vhCJAUhn4 Um/DGSZiy5rssCZNesHX0WoWovBXto+NuPErQjp0MjJszgOTOkwZSDuo1uYmEvHAR9JI JXG/2FGLItNxdJr8RDSLFgvkPpeSu/xTQYAh130i2SkSPW2pV7h0fSUd9DAfWY4mtWe9 H7u6rv3Beo3dN5GiJ0GAPSGNYvNcOEYZYMivJ6w2f1izLly4wmUjW6+LGlG1/5FsaISR 3VRWXNktErMQSP8HY1KqGj7dDMoreMI6ffiz0mCvYVFlksX+hxPC2m9mB647OZGobJHv NwMA== X-Gm-Message-State: AOAM533Yan6utbg8hOtKv+23VnPJ9Dp20YaUhXSOcdHCWPZCjsxm6eLj k+g1Bk4dUkDR40uKDqpy3nIKdwPAWoRIdCtjJaI= X-Google-Smtp-Source: ABdhPJygTxTyjBXaRmjiZjnzUB9+LiiCBE3DDYWxmdEXB/AZO3s12ola6t96FwD5p8jaLrRmcTTRjtSYPzdoh/tzvoc= X-Received: by 2002:aca:df84:: with SMTP id w126mr10401882oig.103.1600444930764; Fri, 18 Sep 2020 09:02:10 -0700 (PDT) MIME-Version: 1.0 References: <20200917165720.3285256-1-hch@lst.de> <20200917165720.3285256-14-hch@lst.de> In-Reply-To: <20200917165720.3285256-14-hch@lst.de> From: "Rafael J. Wysocki" Date: Fri, 18 Sep 2020 18:01:59 +0200 Message-ID: Subject: Re: [PATCH 13/14] PM: mm: cleanup swsusp_swap_check To: Christoph Hellwig Cc: Jens Axboe , Josef Bacik , Minchan Kim , Stefan Haberland , Jan Hoeppner , Joseph Qi , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Andrew Morton , Linux Kernel Mailing List , nbd@other.debian.org, "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Linux PM , Linux Memory Management List , linux-block@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 17, 2020 at 7:39 PM Christoph Hellwig wrote: > > Use blkdev_get_by_dev instead of bdget + blkdev_get. > > Signed-off-by: Christoph Hellwig Acked-by: Rafael J. Wysocki > --- > kernel/power/swap.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/kernel/power/swap.c b/kernel/power/swap.c > index 9d3ffbfe08dbf6..71385bedcc3a49 100644 > --- a/kernel/power/swap.c > +++ b/kernel/power/swap.c > @@ -343,12 +343,10 @@ static int swsusp_swap_check(void) > return res; > root_swap = res; > > - hib_resume_bdev = bdget(swsusp_resume_device); > - if (!hib_resume_bdev) > - return -ENOMEM; > - res = blkdev_get(hib_resume_bdev, FMODE_WRITE, NULL); > - if (res) > - return res; > + hib_resume_bdev = blkdev_get_by_dev(swsusp_resume_device, FMODE_WRITE, > + NULL); > + if (IS_ERR(hib_resume_bdev)) > + return PTR_ERR(hib_resume_bdev); > > res = set_blocksize(hib_resume_bdev, PAGE_SIZE); > if (res < 0) > -- > 2.28.0 >