From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f70.google.com (mail-oi0-f70.google.com [209.85.218.70]) by kanga.kvack.org (Postfix) with ESMTP id 35CA06B0253 for ; Wed, 1 Feb 2017 16:05:17 -0500 (EST) Received: by mail-oi0-f70.google.com with SMTP id v85so440264542oia.4 for ; Wed, 01 Feb 2017 13:05:17 -0800 (PST) Received: from mail-ot0-x243.google.com (mail-ot0-x243.google.com. [2607:f8b0:4003:c0f::243]) by mx.google.com with ESMTPS id h190si8569828oib.325.2017.02.01.13.05.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2017 13:05:16 -0800 (PST) Received: by mail-ot0-x243.google.com with SMTP id f9so46835535otd.0 for ; Wed, 01 Feb 2017 13:05:16 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170201161311.2050831-1-arnd@arndb.de> References: <20170201161311.2050831-1-arnd@arndb.de> From: "Rafael J. Wysocki" Date: Wed, 1 Feb 2017 22:05:15 +0100 Message-ID: Subject: Re: [PATCH] initity: try to improve __nocapture annotations Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Arnd Bergmann Cc: Kees Cook , pageexec@freemail.hu, Emese Revfy , Linux Kernel Mailing List , Josh Triplett , yamada.masahiro@socionext.com, minipli@ld-linux.so, Russell King - ARM Linux , Andrew Morton , jlayton@poochiereds.net, Robert Moore , Lv Zheng , "Rafael J. Wysocki" , ACPI Devel Maling List , "devel@acpica.org" , linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, Linux Memory Management List On Wed, Feb 1, 2017 at 5:11 PM, Arnd Bergmann wrote: > There are some additional declarations that got missed in the original patch, > and some annotated functions that use the pointer is a correct but nonobvious > way: > > mm/kasan/kasan.c: In function 'memmove': > mm/kasan/kasan.c:346:7: error: 'memmove' captures its 2 ('src') parameter, please remove it from the nocapture attribute. [-Werror] > void *memmove(void *dest, const void *src, size_t len) > ^~~~~~~ > mm/kasan/kasan.c: In function 'memcpy': > mm/kasan/kasan.c:355:7: error: 'memcpy' captures its 2 ('src') parameter, please remove it from the nocapture attribute. [-Werror] > void *memcpy(void *dest, const void *src, size_t len) > ^~~~~~ > drivers/acpi/acpica/utdebug.c: In function 'acpi_debug_print': > drivers/acpi/acpica/utdebug.c:158:1: error: 'acpi_debug_print' captures its 3 ('function_name') parameter, please remove it from the nocapture attribute. [-Werror] > > lib/string.c:893:7: error: 'memchr_inv' captures its 1 ('start') parameter, please remove it from the nocapture attribute. [-Werror] > void *memchr_inv(const void *start, int c, size_t bytes) > lib/string.c: In function 'strnstr': > lib/string.c:832:7: error: 'strnstr' captures its 1 ('s1') parameter, please remove it from the nocapture attribute. [-Werror] > char *strnstr(const char *s1, const char *s2, size_t len) > ^~~~~~~ > lib/string.c:832:7: error: 'strnstr' captures its 2 ('s2') parameter, please remove it from the nocapture attribute. [-Werror] > > I'm not sure if these are all appropriate fixes, please have a careful look > > Fixes: c2bc07665495 ("initify: Mark functions with the __nocapture attribute") > Signed-off-by: Arnd Bergmann > --- > drivers/acpi/acpica/utdebug.c | 2 +- > include/acpi/acpixf.h | 2 +- > include/asm-generic/asm-prototypes.h | 8 ++++---- > include/linux/string.h | 2 +- > lib/string.c | 2 +- > mm/kasan/kasan.c | 4 ++-- > 6 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/acpi/acpica/utdebug.c b/drivers/acpi/acpica/utdebug.c > index 044df9b0356e..de3c9cb305a2 100644 > --- a/drivers/acpi/acpica/utdebug.c > +++ b/drivers/acpi/acpica/utdebug.c > @@ -154,7 +154,7 @@ static const char *acpi_ut_trim_function_name(const char *function_name) > * > ******************************************************************************/ > > -void ACPI_INTERNAL_VAR_XFACE > +void __unverified_nocapture(3) ACPI_INTERNAL_VAR_XFACE Generally speaking, there is a problem with adding annotations like this to ACPICA code. We get that code from an external project (upstream ACPICA) and the more Linux-specific stuff is there in it, the more difficult to maintain it becomes. Thanks, Rafael -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org