From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D2DDC021B8 for ; Wed, 26 Feb 2025 17:06:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2415828000B; Wed, 26 Feb 2025 12:06:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F15828000A; Wed, 26 Feb 2025 12:06:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B89D28000B; Wed, 26 Feb 2025 12:06:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E0DA928000A for ; Wed, 26 Feb 2025 12:06:48 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5AD78532F7 for ; Wed, 26 Feb 2025 17:06:48 +0000 (UTC) X-FDA: 83162725296.28.9AD768B Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf27.hostedemail.com (Postfix) with ESMTP id 4731F4001C for ; Wed, 26 Feb 2025 17:06:41 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="LE/EsJFb"; spf=pass (imf27.hostedemail.com: domain of rafael@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rafael@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740589601; a=rsa-sha256; cv=none; b=z1+O3lY9vUbYjxqGslL5W60H/vleURje2lDa/39DuS03LpjabP1BwbCz/8BubgyugOUCH9 zBZKXLxNSg/GpkkF6GSqIrb87M5utxKjMBJFnkfQkYwwhg029QCbVESwnd/SFHIkbNtIwn OOt5YYvkyopY4PZI2t1XQ/txjE2Op/c= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="LE/EsJFb"; spf=pass (imf27.hostedemail.com: domain of rafael@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rafael@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740589601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qisJX0KlDEfyncTpZkM4mXFt+zH37TPsccRpiJT3Gbw=; b=afRj52heQn75Bu2WJ9IBQjDv+7QHLR7BZZItf02AL495/PEceG/OMueh9rV0C0nF8lJ8vp K8whn4tU5lBuLp7kIwfw8cCeSDxPZxBYGtxWCwTGo1o/6n4pkW4YNJxB7AssfHzPO/Byoz XO2/Do/DDHEFOvd3QPjY20FYUmK1ZG4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 3F7B461F28 for ; Wed, 26 Feb 2025 17:06:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90EF0C4CEF2 for ; Wed, 26 Feb 2025 17:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740589598; bh=2R180IJ7APaALd1g+yyfkVhGYnf3hIvGDgk8lsKLG8A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LE/EsJFb2o+sN6h6c7yw0PHl5LhhPL9w8R/xJBOUGLGKDVwUw+DydCDSC471vysSD LISAoC1I0aiD8HNK6hiavbFjTbfVfWIEA7L1eR8HxQRMg/ixQsSCjCxDSnpuH93a4L GCYdnB4nMh2Uh3YepPtKutGEeO2DQhULDzCHc6Nmg97rhggPf9UGwulKmuba0a5e14 Fut9ocBXr94N7Mio3eJQCaAchxPD9Vb3fOa/QCj05mhi1rXU+hZPsAb4Rqgn+WDUss WjKjp98yld7wOpGGXJkV0gW0zSbgW8vBFR+SvA0x4pwGWtiPCI/wGL2XwY5vCJxhqr 99NfBGQtHYXJA== Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5fcd811d939so580377eaf.0 for ; Wed, 26 Feb 2025 09:06:38 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXCLoAj1cK49QAHyqH1ksu1YFULd+mhbj9XffHp+NJya+gbGGCxm1pSe7oKX0wwjcWXL13ijVbGOQ==@kvack.org X-Gm-Message-State: AOJu0YxOHrx58qn4S4I+5AsrLThC/71ujM0zmk2aIfqxk5HO5lrxmnl8 SpFUMqmccMuK+c5RdTHPepJVpblUlMTSuGRvpJnSEY2k89hhLWXRLXacGi2CyZHjYmUBCm4spI7 FywdjIBbRgUprv3aWWPcOt02taUs= X-Google-Smtp-Source: AGHT+IHyPLVjXp7kw5kgInAMNb4jd7h5cWQZCWKEZs0yMGYHKslrekdKrqf86zX892n/fj3IchT6bMpb2Dem6Q8+U3o= X-Received: by 2002:a05:6871:d20d:b0:2bd:286:d713 with SMTP id 586e51a60fabf-2c155700434mr67466fac.11.1740589597661; Wed, 26 Feb 2025 09:06:37 -0800 (PST) MIME-Version: 1.0 References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> <20250221-rmv_return-v1-14-cc8dff275827@quicinc.com> In-Reply-To: <20250221-rmv_return-v1-14-cc8dff275827@quicinc.com> From: "Rafael J. Wysocki" Date: Wed, 26 Feb 2025 18:06:26 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AQ5f1Jo18T3Py72uAV75_Jf5fdQvWu4rZ8JYWNQWcMOGXjnJR1QY3tpi4Yj9mbE Message-ID: Subject: Re: [PATCH *-next 14/18] PM: wakeup: Remove needless return in three void APIs To: Zijun Hu Cc: Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Johannes Berg , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Bartosz Golaszewski , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Zijun Hu , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4731F4001C X-Stat-Signature: ejzoeoy6b1ououozn4ig8pd8bhxb91fh X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740589601-925175 X-HE-Meta: U2FsdGVkX199a/a0yEILpMIMw2xMslhhVltAWGNhhNamXIS8qE2bGJon4aw/411KKXIinGotsSUG4dOXvLxpIEQcMqQ6HiTeAHpuhL3e2XUgDgSYVtoFuP5PpVu6hwu4ucIPV9lVRRdTP4/hzzY8WqPUTr81DurZSFTfL7FEujpYn5UFEH3nOP8IcgJAQ3Yw1mOWoRdujpN4z/Di3n7gvKbmlI/roy9EL9188hTz/2g5tRomk07nCLtnUkzU2b1r5ljkdIzJRGZHbsrbNz84c2iXr0SdbybkiYO9qe64Guu02Lq1n56xUKHHb45/MCEoP0Oac0YN2xxUNYA91XfTJ/0R4sEClESlJCTfjzcnmyYXVOx11pI1cGdvK7MUvxHuMwlVZ3LZSMme3BAPQIZFAjddZ19WyWvuiOjubaB485xOStQDovRePscUDWiz/c8aCdQgBOdfrygypgDDZ1s1mLza29aYEjRbWT+dwmtno8vRs8WakuqAmiCg6ks89ufDdGRHhKBfhZ67NIhLoE2bbe6pG1BdXJpNQSOa/atavrzGrJ0S3BG8dZhUPrKir8Uap8BbBb1x70aUXU1sZd+lCAhsmJn70+XfE9euYtjhIKWO4XKw+IYVouYquIPcwG5/zsAnFx1/m5o6BdgiyvYhRKpxV6xpwB+s65O1oKlo5hhK62v3R4xvDJFqE3VsgEbeRSPdASvEOVi2b63DyMB0pbwNnK4mOYkm7Fj/s0a3MzMdC0KlTd4sA+fYdIblRSkdP6QOyGbJVqe2xsjIKaJMwbwGmTDxMoxXeINmK/a+66z/p5jIhSmfiZsL4j6J6Ewg5k6n4iOHQMOC3DmIjjMnXV8NjK1c4ytmfBphgtsQiwSx2D/lzv84qXx0y0eh0qBin7XMRIiuyzhxEQpAbZNnchK8A6MzuQOfvYd7JsSfgpSYu0kRagsYL1xeL2Net2GLGtmoP2duZorADQpXGH1 358Rw3OX hatMaKc73XxDmecb8m6sdxIj2OqnlR6khvW3/biBHZbaYjNMJAS89SwC0D0rCA0jRT69QSY5ZU4KNXthxrY1ww+UIjJ0E11pAYvwayUgChBLn7InAdu6K8Z3mqPOFpSGX8iyY351P5PNLay3iiAC+wHaOKj1dQQh5+D6URnm801OF8fAt8a+x1bq2OhEEXbHzzp6OjOdz8r6FiGv1p1R81tFGGao00+HSeWv0nLgRcCXrMXL4XlDEDgLy33r0FZ/LeFvcI8tWIU9DbF63fNeHp/MwDymIrOnPdI8nhBRQIxV2d1BJJeEMMycCbWPhuati4U3nxyjle9+HwF4aPWV7OxqeBCj211cufsEYjwziN+5d55z8kN53u5azRKuUVmx5+bet7tzdJ/mTF0+BycM5HY4wQzFz419Wfvuy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 21, 2025 at 2:03=E2=80=AFPM Zijun Hu = wrote: > > Remove needless 'return' in the following void APIs: > > __pm_wakeup_event() > pm_wakeup_event() > pm_wakeup_hard_event() > > Since both the API and callee involved are void functions. > > Signed-off-by: Zijun Hu > --- > include/linux/pm_wakeup.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/pm_wakeup.h b/include/linux/pm_wakeup.h > index d501c09c60cd..51e0e8dd5f9e 100644 > --- a/include/linux/pm_wakeup.h > +++ b/include/linux/pm_wakeup.h > @@ -205,17 +205,17 @@ static inline void device_set_awake_path(struct dev= ice *dev) > > static inline void __pm_wakeup_event(struct wakeup_source *ws, unsigned = int msec) > { > - return pm_wakeup_ws_event(ws, msec, false); > + pm_wakeup_ws_event(ws, msec, false); > } > > static inline void pm_wakeup_event(struct device *dev, unsigned int msec= ) > { > - return pm_wakeup_dev_event(dev, msec, false); > + pm_wakeup_dev_event(dev, msec, false); > } > > static inline void pm_wakeup_hard_event(struct device *dev) > { > - return pm_wakeup_dev_event(dev, 0, true); > + pm_wakeup_dev_event(dev, 0, true); > } > > /** > > -- Applied as 6.15 material, thanks!