From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA7FC4332F for ; Wed, 13 Dec 2023 11:17:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C0536B0492; Wed, 13 Dec 2023 06:17:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86EED6B0493; Wed, 13 Dec 2023 06:17:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737696B0494; Wed, 13 Dec 2023 06:17:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5FA806B0492 for ; Wed, 13 Dec 2023 06:17:51 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 24A19120150 for ; Wed, 13 Dec 2023 11:17:51 +0000 (UTC) X-FDA: 81561545142.24.103176B Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by imf11.hostedemail.com (Postfix) with ESMTP id 7DF664000A for ; Wed, 13 Dec 2023 11:17:48 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.160.51 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702466268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XNLoG4nUXAsx6vBgHdkrIn4zBXAXuSNtZk8J+ON1EM4=; b=mz1/vX6IEexHwLATkd2I25mZtJJOmzedlSheu7YgyUhJVfl0BE8W5oH1GfeSJadWNsGzlj V/9kM129SsDmJDsi3ZSJwCsfdHNF7EGN3X2tBRzKZub3oVhJ5R3H/H+hWar83n60792zSH Yg3hhQfttI4c6kOKYG2lVy54atbHdrk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702466268; a=rsa-sha256; cv=none; b=4O81OwX+kBA1k/EymAgSl+3++Lg0pwULAAWe1zbuAXgaMobQRcCHfztEpqD1kaTf3YqSK+ 4uySc/y3iFAjVV4k5VAJqw1q1kGbD+QpISZrkGtiY9EVvlPxa8kdROrleSe9koHCr7+t0h 48CCk8MmkonDJwVTV94/aJn273lKQ7Y= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.160.51 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-203223f3299so13903fac.0 for ; Wed, 13 Dec 2023 03:17:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702466267; x=1703071067; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XNLoG4nUXAsx6vBgHdkrIn4zBXAXuSNtZk8J+ON1EM4=; b=tuN/NjqSokX8xi5amX7vVvKLPmf2/LGXuryw87EYXsclZZwNzcJCQUrJVdhsPl1AkK ihTuYy8wF3XooA3bfgU7m9jIM5LvYxltY45ltKaLsa7OJKBxxqQeCZmMe1Gul94w1+vL MNOig7rYUXydxzIUR+hMBYr7OTiYZDJ/sVhJhXqUWQ8gZU5KIuV117Q0QP3vzOtdxrK3 s91g1UL2oi5IXIWyPYjR94zf8/29aOjq2zBYWXcy748frsR7v0xf1FSXrmfv5xNFs28l 4If1M4XYvRTSQTfhcHylDwpp+XOePqJnSVYScSYgKtSF+nlYB/7jZIUJPzk+5OAagVwY UEJw== X-Gm-Message-State: AOJu0YyugmqRe7Q4IcWer1yrURBLAdQro50HnPErPYfvYsFm9SgFxzCl kw8gL/4TOBO3inxmN6RAJS9GmrhWd9jKtlFp25Y= X-Google-Smtp-Source: AGHT+IFuc0IEXGieZuwKzcH4cWGGwtxSg5TCytshMq8/GNtX4sTuSMIPBNAccwoW3sZeSBuNwsC8RniVNPztB1mNyEg= X-Received: by 2002:a05:6870:1484:b0:1fa:f0ee:ba9c with SMTP id k4-20020a056870148400b001faf0eeba9cmr14964434oab.2.1702466267588; Wed, 13 Dec 2023 03:17:47 -0800 (PST) MIME-Version: 1.0 References: <20231213090906.1070985-1-haokexin@gmail.com> In-Reply-To: <20231213090906.1070985-1-haokexin@gmail.com> From: "Rafael J. Wysocki" Date: Wed, 13 Dec 2023 12:17:34 +0100 Message-ID: Subject: Re: [PATCH] mm: ksm: Remove unnecessary try_to_freeze() To: Kevin Hao Cc: linux-mm@kvack.org, Andrea Arcangeli , Andrew Morton , "Rafael J. Wysocki" , Pavel Machek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7DF664000A X-Rspam-User: X-Stat-Signature: jdwoeu8n83rz61k4b8kjc86wqko5hm48 X-Rspamd-Server: rspam03 X-HE-Tag: 1702466268-354475 X-HE-Meta: U2FsdGVkX1+rhXeBlmrxKZV4rsqmOF6Gk0V9xk30khSOvNGOQbqrbwFTkMa4buXXLUJU8GPse+nuuWkCnlQPTOCwhkAMV85wlq8iFvue8OWNkk2rK16VR5Cnt03wPRdNwagVry/93/hyeYlzNA7AzTudoDSRKq/TyDMnir4e993fMAScYZBecVhB75dbkpmuuWZ8Hz286Vbh8I0IFptT5KnbpCiIRbM09RBg3QCQGTeobUAumV5X3OpEz8ETGfR4LBq6aXe19w9Q3Pha1FgbpLGyLDafiyhDiBxUkzIxwn1gHiobN9ioHCS+vw6T+VaR+VmdrjDSLTMDLwMsic4mjWnrtC9D0Bms31qfw9ZKfEQubDE3iiROB3gKEEQPWKi05/MJbNEU8F95bwrUdJrv/r4Ny8m3p98tbSW3VXQdflOphzj9fuzZ1Nrus4MuDoOJ2v1FGI76nBGbcsKk5IHg9KPyFP03YGnKiZr40RWB7g6VSuBMiYG7ddmDGcJiU4+XIuxWT9UOcWHtt7cl74Av1+zLBnbnWN8WBmB1F5vWHfrgMQLPC8vXVzNECLucUvqCWpkSbWdL4v3HRFiyrk26Sx1dtnilVHGiJeMGXSXSnySokGAxBdHFsPwCnBNtw8y80EQ//wya3tBX/MPK439rE1xA689Xk46ipo6PvEIB/SCJv37BhRY8COKhQ3p/uRsXzKhuUmIVK4noGKaFPxPbWxiyC8Trz5s5nx64T/Y4OAAPhGuUgqDs5lDTwMzNUxHADEm3zzY/x+6FXnSaLcoT0YFKFIOlJTuoJvJBZJXdIf6abBT84TtJg9duzyySTI9qQV8PEQn+dP+IBS7z+ESJ9KCKqwOti/l9jdvaS/s3P0ufdMZoMXhDRWSqcIrhG0e9DiblLx5x5c1E+zzszdN60jTGIizxw8WYvMxdHGqzV9z9CwBURINCcJPDjc+WmarK9r8TDdvNYc71u4nhw+o TZsQFC2j WPDkSlCvBaGZO+/2hdrFdopDS0pgeP6Fuj4/AsXwhP0l5NWLvRma0zcU9u2LDOtiZLuCcIjiqhpeAeWIXeG+RpoQG9+uKPpA/V6SBkfoeupGWvGwBWSJr9IuTKtd+57pM0cJIElzzrImfXc3WFcVEuyvhJFV13gK/JjTy8Ikg2vDyI1PeZQNOQducBr+oXGBbcVN8QJdtPQ5A3EeytvrIki7tcuUXerFrBY76G/adXa+04ZzIn53NoMlONmKuVtl5SPZYtuxixcdHT1AzZDCpC0Z2yeSxyRoyaUWdXMkF0HRwWR2Z2DQgGRiEj1+wGhZ00dOrTvkxvqEid12QAm2DatbQU5vYOxDsMzRxqrvLBR9DsVJlkljKYHG/wyuVfq9eHD4iRjNa7ykTnUFq0ESgbCFUEs4E2wEAytnyiTT2FRNViWQV3qNkON6v6ufNFOgiSnJw08NLtIHtHbCcvriwHL27u4F9DjLbCPhGW8o2DhLqKNxWyGNqwk9s+nvYjU3rXMGt0Y+8v/P/4BG1duZGKMWCasyXvfDTMfBh+Qfu5ROc2Xw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023 at 10:09=E2=80=AFAM Kevin Hao wro= te: > > A freezable kernel thread can enter frozen state during freezing by > either calling try_to_freeze() or using wait_event_freezable() and its > variants. However, there is no need to use both methods simultaneously. The changelog doesn't match the patch IMV. > Signed-off-by: Kevin Hao > Cc: Andrea Arcangeli > Cc: Andrew Morton > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > --- > mm/ksm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 16532fa85a46..e2ce850c2739 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -2604,11 +2604,9 @@ static int ksm_scan_thread(void *nothing) > ksm_do_scan(ksm_thread_pages_to_scan); > mutex_unlock(&ksm_thread_mutex); > > - try_to_freeze(); > - > if (ksmd_should_run()) { > sleep_ms =3D READ_ONCE(ksm_thread_sleep_millisecs= ); > - wait_event_interruptible_timeout(ksm_iter_wait, > + wait_event_freezable_timeout(ksm_iter_wait, > sleep_ms !=3D READ_ONCE(ksm_thread_sleep_= millisecs), > msecs_to_jiffies(sleep_ms)); > } else { > -- > 2.39.2 >