From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C32ACC7EE2F for ; Wed, 17 May 2023 13:48:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E7CE900004; Wed, 17 May 2023 09:48:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39829900003; Wed, 17 May 2023 09:48:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26033900004; Wed, 17 May 2023 09:48:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 134F9900003 for ; Wed, 17 May 2023 09:48:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 34A6540596 for ; Wed, 17 May 2023 13:48:20 +0000 (UTC) X-FDA: 80799876360.13.7989F36 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf18.hostedemail.com (Postfix) with ESMTP id 60D041C0003 for ; Wed, 17 May 2023 13:48:17 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684331297; a=rsa-sha256; cv=none; b=pihLd6GTWzAW8sx1h351xauSdl8GYHUAMHJ6AaS2uBpO2pJl/SLM2Dn5PCK/D40HzAokxM TgStmswPb9hn+zV5WpkV7IlszoWS5TAbeplQtqf0dxeZWFlWDaGDRUg5C9+NtmrnoHhqIH OKDm7VHh2Z5ga9Ra29+pAvgIck2jLs8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684331297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ktinit9wKE6dNmLgC8Q+hzsuqEwfbXOj0+wtuIuj7PA=; b=2QgoBRM9goCVceS9aopHEh323IJFtfoKHx53VX9kV3IrGe3k+xZuSHeJHaGzLXL9Aqp8a3 HmQSlHLXp8ZzJLFvwr6D4NmNX+e5bLDHn+OFN3eJAPOHCgSpWcJno8BYsJI19aeLbWFcDC BPZ+7ycwKvpifWmkSHFobv0Qg3YDex0= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-50d8d4efd13so197887a12.0 for ; Wed, 17 May 2023 06:48:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684331296; x=1686923296; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ktinit9wKE6dNmLgC8Q+hzsuqEwfbXOj0+wtuIuj7PA=; b=hSc0AISP0JRktOmzH3Iz96AnbTl8Pz+xHYZEZiRXb3GIBTkG+1PxQ5E7X8ENU8lqwn saGYc52/fGIroTuewpCtJlwPW92/mR3mxlCvDNgtxc4RupAK7mtv6N0ND9MJeLqI19SC /GaP7MLy8eGprIpAyOHu4Zr05W+z3sBAEGqAyIUgrVgZwTunv4FA44QIUxH5I91v1kyf oU1QtngEmW+skmxkoBhoq3hvKVlWXtyyHdEcwtmQnPLAmoNba5YI7PMn0SNhl7qHcyHo 93XWBz7HhjUeWITuCFtqJR5JyI9BrBx407dOkh9/F38WrcQ8zukr6EZaBXW522I4pzuk sdMg== X-Gm-Message-State: AC+VfDygFuT1x1GQQnFEoh2mV+2wdtDUngzX638Wf5DvEOkK8CiLhQ5w BJFvt0/L1bTcFjcL76KT/W59KYEVUlqSHTT5fxs= X-Google-Smtp-Source: ACHHUZ6M9EgcbaCbKF8EZaqyFXATppYniPvZEHcewZCPT/QYkFrutGUliTGcVVnKvC2nG18eSQY5J4nCD2m1yx3JtWA= X-Received: by 2002:a17:906:778a:b0:92e:f520:7762 with SMTP id s10-20020a170906778a00b0092ef5207762mr2003855ejm.6.1684331295491; Wed, 17 May 2023 06:48:15 -0700 (PDT) MIME-Version: 1.0 References: <20230517131102.934196-1-arnd@kernel.org> <20230517131102.934196-11-arnd@kernel.org> In-Reply-To: <20230517131102.934196-11-arnd@kernel.org> From: "Rafael J. Wysocki" Date: Wed, 17 May 2023 15:48:04 +0200 Message-ID: Subject: Re: [PATCH 10/14] suspend: add a arch_resume_nosmt() prototype To: Arnd Bergmann Cc: Andrew Morton , linux-mm@kvack.org, Arnd Bergmann , Russell King , Catalin Marinas , Will Deacon , Michal Simek , Thomas Bogendoerfer , Helge Deller , Michael Ellerman , Palmer Dabbelt , Heiko Carstens , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "Rafael J. Wysocki" , Paul Moore , Eric Paris , Dennis Zhou , Tejun Heo , Christoph Lameter , Pavel Machek , Peter Zijlstra , Waiman Long , Boqun Feng , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, audit@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 60D041C0003 X-Stat-Signature: xzbpobjff9mqsacjs8yfe3otfgbzma1p X-HE-Tag: 1684331297-144344 X-HE-Meta: U2FsdGVkX1/tbeBqY9huxQcZ33BInQOXm7uGG0iH8IdL6ftnpvRiT1qGSd0pGbT17wpRIb55CLwlU1E80lYtwEFqh+2RUbuYWjtCXHnuRSNSDOdbyvCHeuIX5cxxIiWacOG7VJz8Prh6N4lOqMzKQFI5ZRvLFfJoMc/Un0yd5klh8m7mNA5UHEZG00X5+5j/FXwuE9rQTI1jaRK/1AXB/qCkLNvqx3MAU4gXfIXFXMCzRDdD5muDwL4NBcYcseI5m4cpAEQUrZAEnuVLNAjxpMUwGhNCLaYkH6rnwnr8Uut7uo6ObKMWwxo6m+LdJ8p6WKPwQPyun8wAcc6T7+QWKSy1vT8eskozhVcflkG+vfu96rWtiqZluxiIv99OzSxV8A2fpmycX0FLu6vir0dh2LTicPvIDrHTiu1FE0nHbk6q3/DHENRi4zN1Rd/2/WXJRL7YJuw6ag3WrOyHGUPmCu9vDdn6F9beXteiB6M5BYrzfv7OGzpxpYjshcXifh2em31EfrkDI2fFwZCXYQgEM+h2rthl9RmIY0qC6WGm5EjWhXgCTaFL/9jlYN7elynVH7OqLZBB8xGUD+MRuOZZXmFHanMIJ0ughn53TlbNYx6Sl5Rx+qadKThvaUjT4ge1csnOw02t/IgOT/Gjul18UNYsh5jryJdESsXQQ7NU9X83Imqbs0fQth2MLIRRjTOieTVkXS0uiAqOQ7WwiOlmXQTmUO6U9rLdlPhDDv4t049doKJJX/XYYz9diFwN10gQRfM0S2uDBuB5GjlO+M/RK4NUUm9tviaTmR9Vusgx7o4Uh1IzBcC1asnv/ZBrYbK0C82L8t2JRRxFu1OdzVt5JFAXqxQyJjqpR5Ga6ZTdgXHbwBRcmKP1jR5RvISHpaG8kzcg81l7FjbzOF1I+o2KjOLUcYj7+vhcTTpuCWo9Q+wAaiUZclQhEjjlFuzWQJNI0Fr/M6Wrbm2qZrQ0sbq LAljD4O6 h/bMJBcO+YeQpcwiwEO+PkpoGUMP4z4UmgnwxYdDyaFCP+yTgEyCpDK4jyTCPpE24xVpKV9XfKmmqBZA4/C5YrvH6lCb4fRiL1K67mTEQzgDqEnxU9NVOzDobDgkFysMk8Q8rKxDuKGegpFi7bejZ7Q6IvtqD2vU0NjUQMCJEEZUhgKrY/SiQ/ZjCC/tJzYPdsqyMByU1LLmitYfv4fizOjFK+rql1oHYJupaD29Fne+M7OkEdr8YzyXM/1bMK61dntgx0aA6cTKu/ggeHi9a+9J6rq4G37Berg+ScBcM6mO75fq51wYaVuzPzQT3G+wOIvXL7HdvYjyMQfkmRIKknemaXZrJo+nEeCF/vwlurhT3eweNjJMrjX7T2D/XRxmajFJEnsX8yC+97bLBXyv1wBkaaY6R+FlwbfMO6mHY0rjsy+IwdFJpiNP7wt8w+hd60x3A6GK2cSr+GFv+PBqfz5OKtmFBuhyDiZbMkYayAmFFjltlXB93xGHLQJAdqqWbPrhkQIjBWofMgSE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 17, 2023 at 3:12=E2=80=AFPM Arnd Bergmann wro= te: > > From: Arnd Bergmann > > The arch_resume_nosmt() has a __weak definition, plus an x86 > specific override, but no prototype that ensures the two have > the same arguments. This causes a W=3D1 warning: > > arch/x86/power/hibernate.c:189:5: error: no previous prototype for 'arch_= resume_nosmt' [-Werror=3Dmissing-prototypes] > > Add the prototype in linux/suspend.h, which is included in > both places. > > Signed-off-by: Arnd Bergmann Do you want me to pick this up? If not Acked-by: Rafael J. Wysocki > --- > include/linux/suspend.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/suspend.h b/include/linux/suspend.h > index f16653f7be32..bc911fecb8e8 100644 > --- a/include/linux/suspend.h > +++ b/include/linux/suspend.h > @@ -472,6 +472,8 @@ static inline int hibernate_quiet_exec(int (*func)(vo= id *data), void *data) { > } > #endif /* CONFIG_HIBERNATION */ > > +int arch_resume_nosmt(void); > + > #ifdef CONFIG_HIBERNATION_SNAPSHOT_DEV > int is_hibernate_resume_dev(dev_t dev); > #else > -- > 2.39.2 >