From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24BA4C77B73 for ; Wed, 24 May 2023 17:33:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F277900015; Wed, 24 May 2023 13:33:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A1F6900002; Wed, 24 May 2023 13:33:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 769CC900015; Wed, 24 May 2023 13:33:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 63A30900002 for ; Wed, 24 May 2023 13:33:20 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2B6DB12067D for ; Wed, 24 May 2023 17:33:20 +0000 (UTC) X-FDA: 80825844960.19.95CF87D Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf09.hostedemail.com (Postfix) with ESMTP id 5417D14000F for ; Wed, 24 May 2023 17:33:18 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684949598; a=rsa-sha256; cv=none; b=jK3+KIlXfXRr2FPFXQz2zVmp9NNCmv2c2tdlv7+88NNvt9X5/+PyV0S5onpW7MoPr6G8Hy ChBPKEVerOiCoJCp4zVDgp0u0/kVJ/s7MdBAXTOAfIPVMEvi7v4ZXxaNRpQ6foZNPdaxXL 6XoVzIcacBnhj8FqrSlyn7T5PHZmkI4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684949598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LCSKoj+QaYMGiALxKIVygFGEfEGQMG7Gw+jdrUBXjYI=; b=VgaAt6t9HpxUAJCx3W3ww7WaEj1+tItceSE0tGXxnuM6rS436aOiknm5iRCNS5rfBc4cIP 0VmTvK8vkwrr9+0n2dX8bJxuvzOwu0HRP3q+yVoxeMIO/qbdpaJpAtEQtHTCl/HDzztoyD LcvI5B2jn1yjjzIt23gXM62TLmy9jYU= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-96f44435d92so35531166b.0 for ; Wed, 24 May 2023 10:33:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684949597; x=1687541597; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LCSKoj+QaYMGiALxKIVygFGEfEGQMG7Gw+jdrUBXjYI=; b=fdWnu5fTq3VnhU3PzZKD4yL/PI0CgjdOrY2u6RGd1PgfnlSSCmlUXQPh2wq7WFp+0J QpLX8MWcDgalK2i+qCpol0BQFDp6lvMQ+uuXJq/0SW/D+ktUe3CB6ZCHqzdIMBt4lMzK Tcg6zzjdTC3lhbSsUEuHcy076rOX0U18SaT71Uf+8nzmNjdsc/UbE2nNZ/k03tDArkdW oNVVdKtmXV5oQgC6D47/nIMrxBJZqvbkHh2oXrie+IGG9kToxzPr6KGqRChgY1pageHk UMRqorFgX9nGRcQsSTCSDK6K56sTTnwi1FuJ420f6CoVuKA1oOZoWKNYfwZNUwsk8x1j aPDQ== X-Gm-Message-State: AC+VfDwDy/5RQRO4uZQ8aQXqf5cgZuVLaJj3i5OwmKVu6fYZL7Jqnqce jz5fgWVGIX9ZEwQYXuet4NU6GK3s7g1ofbgUhEQ= X-Google-Smtp-Source: ACHHUZ75t5LOoP5fPEw1B3B8AOZ5QAW3p/uA3PR3RjFQ63NrJQ3bU0l+qjgSiV2WQ1zsptMKJ1KiCOsk0UIwyQ0utjI= X-Received: by 2002:a17:906:2218:b0:96f:4c38:4b1a with SMTP id s24-20020a170906221800b0096f4c384b1amr16403004ejs.5.1684949596574; Wed, 24 May 2023 10:33:16 -0700 (PDT) MIME-Version: 1.0 References: <20230517131102.934196-1-arnd@kernel.org> <20230517131102.934196-11-arnd@kernel.org> <6b7f6f66-7890-47a3-a22d-e29f2944823a@app.fastmail.com> In-Reply-To: <6b7f6f66-7890-47a3-a22d-e29f2944823a@app.fastmail.com> From: "Rafael J. Wysocki" Date: Wed, 24 May 2023 19:33:05 +0200 Message-ID: Subject: Re: [PATCH 10/14] suspend: add a arch_resume_nosmt() prototype To: Arnd Bergmann Cc: "Rafael J . Wysocki" , Arnd Bergmann , Andrew Morton , linux-mm@kvack.org, Russell King , Catalin Marinas , Will Deacon , Michal Simek , Thomas Bogendoerfer , Helge Deller , Michael Ellerman , Palmer Dabbelt , Heiko Carstens , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Paul Moore , Eric Paris , Dennis Zhou , Tejun Heo , Christoph Lameter , Pavel Machek , Peter Zijlstra , Waiman Long , Boqun Feng , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, audit@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5417D14000F X-Stat-Signature: n8tku7n6dryugu83m6dkzmq8ecxdq67o X-HE-Tag: 1684949598-803401 X-HE-Meta: U2FsdGVkX18283GMfoomWFhSEOxYd1RI5Jjigi8e6ivTElmZbipT/atbkRjTTOBRTBKNc2j03KTh5PZIsN6KyXvZsYC9SgtTJdb+K1OZeHALo6K756LwgIkG9G4Nx7AP3Ct9iAoAfdKM6Ex7xmKiz6uMChq6VQV3Qy0m+Vh7O7NUXW4DzrwY5j4AYGIXe1TBTs70DRWQylx1TCNTRhVhdR+WTyAZWTaUydKV1FO3HJXx9tJlggGJ7mORFgIn6SKNb+5PvHl3ExSfCcj+5PH8s3gaEJnBm3ipiWriEZMgln9qbpn9YYHEetMrSSkZYsRHrVmSuMTaPSCmPqLOqhvj4Mcp+BmPqS0B6ZyCYxs7NA0eHsb9WZTmcvl1wWgwvMLLjTfMfJGOuYdoINdP+6K2lYHRWFmz2RovRZavQdlViJPCZpQYwmlGLT8TmqppDZbxa+QoV/h8noI1J5hP45I/h6L6xalXbTu+OMCck+yrLWgr25E6gO7gM5gNeoe6ykvS/8Ehjq4Fve55RtbgvFWkq0sYpV1+9BunJBtPXUlLoJlmx50452ZlcRJ0GcvrCH21+I47Db3uOBXg6MfzZeXvbeEECpEccTvTgTs/NCiKm2d/wVl9XxHXe9AM4JUXsgKuDQbARYo3intQ5wkQ/gc8tmEbIhxpfp/wsZvXaIezLDbs+/3na3jhMdz+tUWrfPkSTl4h+FYqNXQasDbVaADkrWmC8eJdr8tjAqf+v0yZDKF5psezHVc4ueVB/fgQ26xtc7GU2Zb57OmsOmae8OKjaNVjJypfkSnyKRNB8kK9Q++uB7wjBXL3PHyU5eTlURUQZDtb/uezSp6CezxxxKEcT42osNFmC660Way34bNm+Tzan6jOepnrdLfbBE47z5I7Hvlh04xmO/UXHVTQFA+6OwEimbH4APyrBeo2MVQkSkro9D8UaBiAhHpoWxcG/pHEPRyqOllGm88PpyZHkJh MY/dljDR 6UbxwsjvWYLE3qMxX6Rxp2Mi2vlbgQ+VJEB9t75MmUReUSbeZpGA7Tx8G9jMVWsf8H2FbNZ7LW8efNNkzlMM9IONkEppEtND9y2M6EjchZsZGl8inpF0/nAqi2KXXxIrmx06CaCH+cOTjtoZHEnSUr5Z7B2VhDQ8EBKEwp06jyYTDe0UOFLkYgGOKWxugbR6YBXQvvgNV2Ab9nUT4KzbIFA/698VLdjHP5FLq/hYm7Qv2reA73oYKJ8i1dkW5TpDBwLdlHbFoTE0IQ7HOKZFfMztiEcGwhMWI9XidrF7B2IfRhN2MGNfs8RvA+NsXRnbi89+Dr8JIHgJm6aI40Qmd3NQlwWzOR1DbnZwsGoKempSTTLwNWvfrxDaJKIFez5rOJEbhfeQGJFrGJeyQBJKyiIts/V9i4DiIYGGq7/vF8Qlevnw1QSFnSJ/u8sAr/VIde9GZ3QFRYcj5XkG5zmerolMIuyJ/vezPAMswAtf8OpOd3dVeWdyWsvRArm7Djhy2X/3SPWrzHS+00Ho= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 17, 2023 at 4:52=E2=80=AFPM Arnd Bergmann wrote= : > > On Wed, May 17, 2023, at 15:48, Rafael J. Wysocki wrote: > > On Wed, May 17, 2023 at 3:12=E2=80=AFPM Arnd Bergmann = wrote: > >> > >> From: Arnd Bergmann > >> > >> The arch_resume_nosmt() has a __weak definition, plus an x86 > >> specific override, but no prototype that ensures the two have > >> the same arguments. This causes a W=3D1 warning: > >> > >> arch/x86/power/hibernate.c:189:5: error: no previous prototype for 'ar= ch_resume_nosmt' [-Werror=3Dmissing-prototypes] > >> > >> Add the prototype in linux/suspend.h, which is included in > >> both places. > >> > >> Signed-off-by: Arnd Bergmann > > > > Do you want me to pick this up? > > Yes, please do. Thanks, Done, thanks!