From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572C1C433EF for ; Tue, 26 Apr 2022 16:24:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF1A46B0073; Tue, 26 Apr 2022 12:24:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7B6B6B0074; Tue, 26 Apr 2022 12:24:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1B536B0075; Tue, 26 Apr 2022 12:24:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 9F9766B0073 for ; Tue, 26 Apr 2022 12:24:16 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4E56F266A8 for ; Tue, 26 Apr 2022 16:24:16 +0000 (UTC) X-FDA: 79399552512.29.1FC02DE Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf10.hostedemail.com (Postfix) with ESMTP id C60B3C0053 for ; Tue, 26 Apr 2022 16:24:07 +0000 (UTC) Received: by mail-yb1-f176.google.com with SMTP id r189so33898393ybr.6 for ; Tue, 26 Apr 2022 09:24:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yRoS0e78MQ3Aw94WaIb6fXl1gKLeuGuUg52q3sQRmzY=; b=GMUENLlWFPW9STFQRerzqxqcx+eyfSxQktIPQwMYNmZdsX35eChlsId+R7W2XNH1Q9 wA21WPVGMG4MY9n6DyrVTBmpxkvUU82SoiH2OTYd9EAE8rJmzKv3soGpMSacqnEZf+nU 2Uda/cmxk+Bo/qGqpi/DGIU7ZhXQfC4JynfclvS5yLRhTPyMJZmbTyIzyVQ34R8AAQxf kLhLYL+jSY7PFtu+wU32Svs9NEycVXXuuYhGCw2iFx1rW42whGaLBqCVrUgekP9m/mj0 NOLJy8gIgQHMM4geiBR65DaN4KtmlNiHcVJ57encCxNnT49D3M0fHXSrTl1RHiHEbfjw vhxQ== X-Gm-Message-State: AOAM5325Z/zWIpifjyMMsgVqowdqM12b/6s9eRISIg3P0DYaOSqhovtg X4sgjn9OA/z2CV0QiW7/wGY7UkLNS1eBqskV3dc= X-Google-Smtp-Source: ABdhPJwx/0sG065EFEG6R3FAqY53TNDROIzT+SSV1rhw4vfnS5Bq5793FT0nC8rO8MYbenwgZB7rlOBFIPJrRMSrcRY= X-Received: by 2002:a05:6902:352:b0:63e:94c:883c with SMTP id e18-20020a056902035200b0063e094c883cmr20762254ybs.365.1650990255156; Tue, 26 Apr 2022 09:24:15 -0700 (PDT) MIME-Version: 1.0 References: <20220423182410.1841114-1-matthieu.baerts@tessares.net> In-Reply-To: From: "Rafael J. Wysocki" Date: Tue, 26 Apr 2022 18:24:04 +0200 Message-ID: Subject: Re: [PATCH v2] x86/pm: fix false positive kmemleak report in msr_build_context() To: Borislav Petkov Cc: Matthieu Baerts , "Rafael J. Wysocki" , Pavel Machek , Thomas Gleixner , Ingo Molnar , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Chen Yu , Pawan Gupta , Catalin Marinas , Linux Memory Management List , Mat Martineau , Ingo Molnar , "Rafael J. Wysocki" , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C60B3C0053 Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-Rspam-User: X-Stat-Signature: o18zgkxif7ifsixptmap8uufpr3zxsw4 X-HE-Tag: 1650990247-773825 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 5:22 PM Borislav Petkov wrote: > > On Sat, Apr 23, 2022 at 08:24:10PM +0200, Matthieu Baerts wrote: > > diff --git a/arch/x86/include/asm/suspend_64.h b/arch/x86/include/asm/suspend_64.h > > index 35bb35d28733..bb7023dbf524 100644 > > --- a/arch/x86/include/asm/suspend_64.h > > +++ b/arch/x86/include/asm/suspend_64.h > > @@ -14,9 +14,13 @@ > > * Image of the saved processor state, used by the low level ACPI suspend to > > * RAM code and by the low level hibernation code. > > * > > - * If you modify it, fix arch/x86/kernel/acpi/wakeup_64.S and make sure that > > - * __save/__restore_processor_state(), defined in arch/x86/kernel/suspend_64.c, > > - * still work as required. > > + * If you modify it before 'misc_enable', fix arch/x86/kernel/acpi/wakeup_64.S > > Why does before misc_enable matter? > > arch/x86/kernel/asm-offsets_64.c computes the offsets and there is a > member like saved_context_gdt_desc which will get moved after your > change but that's not a problem because the offset will get recomputed > at build time. > > Hm? So can the comment be dropped entirely?