From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A74DC02180 for ; Mon, 13 Jan 2025 19:10:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 245946B00A6; Mon, 13 Jan 2025 14:10:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CE416B00AA; Mon, 13 Jan 2025 14:10:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 047C76B00AB; Mon, 13 Jan 2025 14:10:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D86916B00A6 for ; Mon, 13 Jan 2025 14:10:40 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9BAF542C6A for ; Mon, 13 Jan 2025 19:10:40 +0000 (UTC) X-FDA: 83003370240.03.CB9C25C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id A58AB1C000D for ; Mon, 13 Jan 2025 19:10:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QfZKqT2b; spf=pass (imf20.hostedemail.com: domain of rafael@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rafael@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736795438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OWvS7Vmc4XZMPDTtxblR/3oRUfKSe3CHUlcIQiI1h5s=; b=RbKxQasOdgyGx6eFronpW2oQjc+Mi1AmJEbjKLbmN/2xIgBPjSb18apgULny2xjtxE5To8 gCEjo7OhX7FcZffWrChNTSksk2Z008oNfcAXMr/+Wm+VUL8xui9o81PpXaKSFSygZa2TiF bd4jt1BGVnr47w37GvSSqmLXodA2S8A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736795438; a=rsa-sha256; cv=none; b=hiWdkwOpv2tJ9Ly9rEaaRcYYO06gQc+stf5h83WasJF1iJjLKLWySVhQF+g4SvrpxJW0FY 0FjxoSeGX+wlFO08MLgT/YbSPfChDrTolAvWBafH+iQuJ5e+ttiTp5QU/4P8gnPDwU1FGb 15vwgM/+4o6Aw3toT/EbyobjQfWY7oA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QfZKqT2b; spf=pass (imf20.hostedemail.com: domain of rafael@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rafael@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B3D2E5C57AC for ; Mon, 13 Jan 2025 19:09:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEE41C4CEEA for ; Mon, 13 Jan 2025 19:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736795436; bh=bTCFDf8vCyq8nYMCcZs1lYvphn31XnUPAGDIocgH0TE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QfZKqT2bWMTV/3L/AcUNm1kI0/42VI/83XLFG+qRjhnr8V5mZlg9LNN+N56COT0ny w3gWs9QaxKfLzQydZoQubYcwkQUy12ZQOMvGC8/UHpzXalH9dFtUNBlgDEza/UtyAF zEvqO2XlEcSPgu4T0D4otttk3Q9WJqmUCUQ0TbnostfDoFd6cahXn84D3Bx3KUa1JK zsoqEGyiGQFjuW+ve/HszINNuYpSTNypmmHJefmnyDVaOKjktQ5UdQHmlRdWNJSz14 fKN6KkX0++qnil9MFVfOqtBw1HAdHSHgCft9oL4iwBIFdw1E+0oN5e8q0yAMfsCak2 ehAE19pqC1cPA== Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2a3bf796cccso2167565fac.1 for ; Mon, 13 Jan 2025 11:10:36 -0800 (PST) X-Gm-Message-State: AOJu0YycuAjDwGRaFP7RriClEg348Zs77DvPLP9Jrviz6md2v4goxqCk DI9CQ/1QwSjwiHWXq7jtJPats1Fy/Ri44GaY3JnDgE0Jw8JUtI6XfK59oDzk0+OLAxhLmRhfVw+ DkoUmgwRU+XE33hya/ARpIBzgfIM= X-Google-Smtp-Source: AGHT+IHbOkT372wvF7l4NndlribXQWuRLbK8G76+BOB3qhvYxzram7wGgZ0+Qn1COcLDTgfu52NR/4dzjR3YhbbyM/M= X-Received: by 2002:a05:6870:ef11:b0:29e:34ef:bd7d with SMTP id 586e51a60fabf-2aa06647c89mr12263944fac.2.1736795436000; Mon, 13 Jan 2025 11:10:36 -0800 (PST) MIME-Version: 1.0 References: <20250113174439.1965168-1-gourry@gourry.net> <20250113174439.1965168-4-gourry@gourry.net> In-Reply-To: <20250113174439.1965168-4-gourry@gourry.net> From: "Rafael J. Wysocki" Date: Mon, 13 Jan 2025 20:10:24 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AbW1kvbwxtKXkdt67DuIfKDHva3LhOsCwSa18Z-abQ2l0M082G5kljHn9SOjGqk Message-ID: Subject: Re: [RESEND v7 3/3] acpi,srat: give memory block size advice based on CFMWS alignment To: gourry@gourry.net Cc: linux-mm@kvack.org, linux-acpi@vger.kernel.org, kernel-team@meta.com, x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, rppt@kernel.org, bfaccini@nvidia.com, haibo1.xu@intel.com, dave.jiang@intel.com, Fan Ni Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A58AB1C000D X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 4b8to1o6uxr7rupdixsryumrbycc8f78 X-HE-Tag: 1736795438-263113 X-HE-Meta: U2FsdGVkX1/yl7UWpdw32Qw3A90qP/5emEwKKSnMWUnXcWeU2CEs6+L2O39G5nRNf7/7qpMAN2dnAClD3q8Jtnj0ij2vsUzW1hInhJc+CfLOngxa794BftY5vR1ymgRu4YmjW2QiBLmM6WJPfCKtlD5QcZv0MmIht/8GdvPQ3aZKRTp9R8GN+KqPCnT2r/m1cAix5wPnBiaDk5VjmvVmgXgcRDxr9gPtocaNUTKG1Zdq7AlbI7jMWTZ6YuH9JfrXjT/OwlVhtohwVF6Fg37AxbULfUI8eVOvrdJ/aSLdbNHXSQCnCvCUhZF5YZj2Bcl1lWggePBRxYsjsnWPKBSwuTm32ZKqRdKJH/UBV/0GAPWA/8haXsgnwWQoNT9510tE36Ys24h27betAbDRJXJEDiO2e+0EkFGgf44jxzEo7Y4LPYINanC5acoJokvcRLwUpg/gGD7BypKQ6ITqr0Yr6D0vq5xlyqH5yJqqb8sxgNsndMI17pynVBg31rZ/whgM7PcfeqxCEW511QIqb6fF+OSu1kq4XEM1zCe7jCTulYMH9XywcH7GotG6UmgyfxbU4gN9GSRcQjJYDWBOyIpWzlAHbw4dIrdbviUJvJQRh36pwbQfBivECruizJKaqHQ8NNUrBkRDrlcAvpbpjMBAbeeE6UY137B6oezb5MGB5lb6bemInkjxYnxO2PkrkuBW2Twdpd/sdHxafsbmXIZ462gHy/f6KRCv5dT7bWgWvtNBYiyKW2NZ/BqSFKM/QQdGdNUcLSpByc2Tb60HgXZ5OEw5kud98hK1DilkyGmBb5Dgb3FmC9Kdn+d5E/VVYg+lYq2mdVNJZcd8NyxfP6rDtswmhrg/O29tTai11KaF9WY3Fb9APLSPNaBRbOypFfcbSa50uJ9puImZQYyUkjELXDvNI+2IGsn7Wdo52oFsGgaJDdjYK6jnJaDsEIYTYPDhftCKegVtKR8UKArGeEl Zw4whD4P XdocQXDhAi9RadJvMVkV+zEZihsdI6FFcDoQlzr95RR4EVinN0k5/UTKZzgPo4nh+WzCMB8KQUZzPZ+j0782Xcd08xXhTl3TEE9U6s7jzjyNZvd1mbQvajtIxeQTs/OXlHcAM+xsExAbnu31/0cpWH72azT2GPKnT6fyCYTlJC+ig4dLdWvVvaKlcfG6cziVW5D0gOp2/d9ZRQ+XrlSG+B9zkSgx2iGjIaaIaDlV6KMwhGOMPTyMW0cSJmCkYftg0wzx+YAUArKUwAu5SfQG+AoLjglUGgBdheSGHyu9lwXA2uxYMXotKwOsesAw1L0P6vAflDNXWJmhUXDe7UI9qkUNB36FhxkUwzAsjAUIHpGhZ4tIlTYXoHKzFODiiAR2I4wtQHLxD8t5q7kRVxpiUxcklHXxcl+XmZz4R1ep1+FHk+oCQQNY2cb2lzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 13, 2025 at 6:44=E2=80=AFPM Gregory Price w= rote: > > Capacity is stranded when CFMWS regions are not aligned to block size. > On x86, block size increases with capacity (2G blocks @ 64G capacity). > > Use CFMWS base/size to report memory block size alignment advice. > > Suggested-by: Dan Williams > Signed-off-by: Gregory Price > Acked-by: Mike Rapoport (Microsoft) > Acked-by: David Hildenbrand > Acked-by: Dan Williams > Tested-by: Fan Ni Acked-by: Rafael J. Wysocki > --- > drivers/acpi/numa/srat.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 59fffe34c9d0..7526119fe945 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -425,13 +426,22 @@ static int __init acpi_parse_cfmws(union acpi_subta= ble_headers *header, > { > struct acpi_cedt_cfmws *cfmws; > int *fake_pxm =3D arg; > - u64 start, end; > + u64 start, end, align; > int node; > > cfmws =3D (struct acpi_cedt_cfmws *)header; > start =3D cfmws->base_hpa; > end =3D cfmws->base_hpa + cfmws->window_size; > > + /* Align memblock size to CFMW regions if possible */ > + align =3D 1UL << __ffs(start | end); > + if (align >=3D SZ_256M) { > + if (memory_block_advise_max_size(align) < 0) > + pr_warn("CFMWS: memblock size advise failed\n"); > + } else { > + pr_err("CFMWS: [BIOS BUG] base/size alignment violates sp= ec\n"); > + } > + > /* > * The SRAT may have already described NUMA details for all, > * or a portion of, this CFMWS HPA range. Extend the memblks > -- > 2.47.1 >